1299669 - New Tab toolbutton has too much padding

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[Alice0775 White]

Attachment: Screenshot

[Tracking Requested - why for this release]:

Build Identifier:
https://hg.mozilla.org/mozilla-central/rev/506facea63169a29e04eb140663da1730052db64
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:51.0) Gecko/20100101 Firefox/51.0 ID:20160831030224


Steps To Reproduce:
1. Enter Customize Toolbar
2. Move new tab button[+] to NavBar
3. Exit Customize Toolbar


Actual Results:
New Tab toolbutton has too much padding
See screenshot

Expected Results:
Not so


Regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=9a737024c5cc7632fa66a559ba9a4ae09a1a9451&tochange=08e4eadbb77d5789e41559ced20dc3fef8b93002

Regressed by: Bug 1272256

Comment 1

[Marcia Knous [:marcia]]

tracking 51+ for this UI regression.

Comment 2

[Dão Gottwald [:dao]]

Fixed by backout.

Comment 3

[Gerry Chang [:gchang]]

Un-track for 51 because it's fixed by backout bug 1272256.

Comment 4

[Alice0775 White]

[Tracking Requested - why for this release]: UI layout regression

Relanded bug 1272256 in 52.
And the problem reappear. :(

Comment 5

[Jonathan Kingston [:jkt] he/him]

So besides Bug 1317190 I can't seem to reproduce the same issue any more. Is it exactly the same size as your previous screenshot?

Comment 6

[Alice0775 White]

Attachment: screenshot of Nightly52.0a1(2016-11-13)

See screenshot

Exactly same problem

Comment 7

[Jonathan Kingston [:jkt] he/him]

Attachment: Selection_424.png

Is your screenshot Windows or Mac? On Linux I can't replicate the issue anymore.

Comment 8

[Alice0775 White]

(In reply to Jonathan Kingston [:jkt] from comment #7)
> Created attachment 8810274 [details]
> Selection_424.png
> 
> Is your screenshot Windows or Mac? On Linux I can't replicate the issue
> anymore.

Windows10

Comment 9

[Jonathan Kingston [:jkt] he/him]

Attachment: Bug 1299669 - Fixing new-tab-button padding when dragged to the navbar in Windows and containers is enabled.

Review commit: https://reviewboard.mozilla.org/r/94130/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/94130/

Comment 10

[Jonathan Kingston [:jkt] he/him]

Dao please note I tested this by applying the Windows theme to Linux which meant I was able to replicate the issue and fix it. However I have not tested on an actual Windows machine. Checking the Mac theme now if it has the same issue.

Thanks!

Comment 11

[Jonathan Kingston [:jkt] he/him]

Confirmed the issue isn't present on the OSX theme.

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/76e0b210a4fc
Fixing new-tab-button padding when dragged to the navbar in Windows and containers is enabled. r=dao

Comment 13

[Jonathan Kingston [:jkt] he/him]

Comment on attachment 8812358 [details]
Bug 1299669 - Fixing new-tab-button padding when dragged to the navbar in Windows and containers is enabled.

Approval Request Comment
[Feature/regressing bug #]: 1272256
[User impact if declined]: Windows users will have incorect spacing if they move the new tab button to navbar and containers is enabled.
[Describe test coverage new/current, TreeHerder]: None
[Risks and why]: Windows users could have more breakage of the button in question.
[String/UUID change made/needed]:

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/76e0b210a4fc

Comment 15

[Julien Cristau [:jcristau]]

Comment on attachment 8812358 [details]
Bug 1299669 - Fixing new-tab-button padding when dragged to the navbar in Windows and containers is enabled.

fix windows theme regression in aurora52

Comment 16

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e2b684e88818

Comment 17

[Mohammad Maruf Rahman]

I have reproduced this bug with Nightly 51.0a1 (2016-08-31) on Windows 7 , 64 Bit !

This bug's fix is verified with latest Aurora and latest  Nightly

Build   ID  20161126004005
User Agent  Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:52.0) Gecko/20100101 Firefox/52.0

Build   ID  20161126030207
User Agent  Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:53.0) Gecko/20100101 Firefox/53.0
 
[bugday-20161123]

Comment 18

[Farhadur Reja Fahim]

I have reproduced this bug with Nightly 51.0a1 (2016-08-31) on Linux Mint 18, 64 bit!

The bug's fix is now verified on latest Nightly 53.0a1.

Nightly 53.0a1:

Build ID 	20161129030222
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0

[testday-20161127]

Comment 19

[nagarajnaidu921]

[bugday-20170125] bug verified 
os: Ubuntu 16.04 LTS
I reproduced the bug and its fixed

Comment 20

[suba4598]

[bugday-20170331] bug verified

Comment 21

[Moneshb7]

[bugday-20170322]
Operating System: Windows 10(64 bit)
Browser: Firefox 53.0b

The new tab tool button has perfect padding , the bug is fixed and verified.