If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

driver.js is leaking observers

RESOLVED FIXED in Firefox 57

Status

Testing
Marionette
RESOLVED FIXED
a year ago
a month ago

People

(Reporter: whimboo, Unassigned)

Tracking

({mlk})

Trunk
mozilla57
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox57 fixed)

Details

(Reporter)

Description

a year ago
I can see two possible lines of code where we leak observers in driver.js:

https://dxr.mozilla.org/mozilla-central/rev/b7f7ae14590aced450bb0b0469dfb38edd2c0ace/testing/marionette/driver.js#59

https://dxr.mozilla.org/mozilla-central/rev/b7f7ae14590aced450bb0b0469dfb38edd2c0ace/testing/marionette/driver.js#66

In both cases we add the observer listener but once fired don't remove it anymore.
THis is not a priority. Some of this code is going to be removed in the "near future" since it is B2G
I think with the changes that have happened in the last year I don't think that this bug is still valid
Status: NEW → RESOLVED
Last Resolved: a month ago
Resolution: --- → INVALID
(Reporter)

Comment 3

a month ago
(In reply to Henrik Skupin (:whimboo) from comment #0)
> I can see two possible lines of code where we leak observers in driver.js:
> 
> https://dxr.mozilla.org/mozilla-central/rev/
> b7f7ae14590aced450bb0b0469dfb38edd2c0ace/testing/marionette/driver.js#59

Removed via https://hg.mozilla.org/mozilla-central/rev/a9deb69ab381 (bug 1395176) for Firefox 57.

> https://dxr.mozilla.org/mozilla-central/rev/
> b7f7ae14590aced450bb0b0469dfb38edd2c0ace/testing/marionette/driver.js#66

Removed via https://hg.mozilla.org/mozilla-central/rev/55ee9540dd12 (bug 1315611) for Firefox 55.
status-firefox57: --- → fixed
Depends on: 1395176, 1315611
Resolution: INVALID → FIXED
Target Milestone: --- → mozilla57
You need to log in before you can comment on or make changes to this bug.