Closed
Bug 1395176
Opened 7 years ago
Closed 7 years ago
Add eslint rule to forbid use of var, except at top-level
Categories
(Remote Protocol :: Marionette, enhancement)
Tracking
(firefox57 fixed)
RESOLVED
FIXED
mozilla57
Tracking | Status | |
---|---|---|
firefox57 | --- | fixed |
People
(Reporter: ato, Assigned: ato)
References
Details
Attachments
(4 files)
No description provided.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → ato
Status: NEW → ASSIGNED
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8902757 [details] Bug 1395176 - Use scoped remoteFrames instead of global. https://reviewboard.mozilla.org/r/174416/#review179714
Attachment #8902757 -
Flags: review?(dburns) → review+
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8902758 [details] Bug 1395176 - Turn marshal helper into function. https://reviewboard.mozilla.org/r/174418/#review179718
Attachment #8902758 -
Flags: review?(dburns) → review+
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8902759 [details] Bug 1395176 - Lint testing/marionette for var usage. https://reviewboard.mozilla.org/r/174420/#review179728
Attachment #8902759 -
Flags: review?(dburns) → review+
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8902760 [details] Bug 1395176 - Add eslint rule that forbids use of var. https://reviewboard.mozilla.org/r/174422/#review179730
Attachment #8902760 -
Flags: review?(dburns) → review+
Pushed by atolfsen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/5fcf97b0946a Use scoped remoteFrames instead of global. r=automatedtester https://hg.mozilla.org/integration/autoland/rev/db4255debad2 Turn marshal helper into function. r=automatedtester https://hg.mozilla.org/integration/autoland/rev/a9deb69ab381 Lint testing/marionette for var usage. r=automatedtester https://hg.mozilla.org/integration/autoland/rev/4b2c8d6a06b6 Add eslint rule that forbids use of var. r=automatedtester
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/5fcf97b0946a https://hg.mozilla.org/mozilla-central/rev/db4255debad2 https://hg.mozilla.org/mozilla-central/rev/a9deb69ab381 https://hg.mozilla.org/mozilla-central/rev/4b2c8d6a06b6
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox57:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla57
Updated•1 year ago
|
Product: Testing → Remote Protocol
You need to log in
before you can comment on or make changes to this bug.
Description
•