Closed Bug 1300016 Opened 3 years ago Closed 3 years ago
_speech _simple .html | application crashed [@ Ref Ptr<mozilla::dom::Speech Synthesis Utterance>::operator->()]
58 bytes, text/x-review-board-request
Eitan, any idea what might have made this angry around the beginning of September?
This didn't happen from a change in speech synth. I suspect it may have to do with bug 1262053. alwu wrote both our AudioChannelAgent support and the patches in bug 1262053. Do you have any idea?
Flags: needinfo?(eitan) → needinfo?(alwu)
Indeed, that looks like a very likely candidate. Bug 1299313 was filed on the 30th of August.
Comment on attachment 8808100 [details] Bug 1300016 - only suspend web-speech when mUtterance exists. https://reviewboard.mozilla.org/r/91026/#review92002 Thanks!
Attachment #8808100 - Flags: review?(eitan) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/117b0fa754f7 only suspend web-speech when mUtterance exists. r=eeejay
Please request Beta approval on this when you get a chance (for 51, assuming that this won't get approved and landed before Monday's uplift)?
Comment on attachment 8808100 [details] Bug 1300016 - only suspend web-speech when mUtterance exists. Approval Request Comment [Feature/regressing bug #]: Fix the intermittent crash because of using the null pointer. [User impact if declined]: Intermittent crash. [Describe test coverage new/current, TreeHerder]: Yes, it already be covered by our test cases. [Risks and why]: almost no risk, because we just added the null pointer checking. [String/UUID change made/needed]: no
Comment on attachment 8808100 [details] Bug 1300016 - only suspend web-speech when mUtterance exists. Fix an intermittent test failure. Take it in 51 aurora.
Attachment #8808100 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment on attachment 8808100 [details] Bug 1300016 - only suspend web-speech when mUtterance exists. This was uplifted to 51 before the merge to beta, so beta uplift is no longer relevant.
You need to log in before you can comment on or make changes to this bug.