Closed
Bug 1300016
Opened 8 years ago
Closed 8 years ago
Intermittent dom/media/webspeech/synth/test/test_speech_simple.html | application crashed [@ RefPtr<mozilla::dom::SpeechSynthesisUtterance>::operator->()]
Categories
(Core :: Web Speech, defect)
Core
Web Speech
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox50 | --- | unaffected |
firefox51 | --- | fixed |
firefox52 | --- | fixed |
People
(Reporter: intermittent-bug-filer, Assigned: alwu)
References
Details
(Keywords: crash, intermittent-failure)
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
eeejay
:
review+
gchang
:
approval-mozilla-aurora+
|
Details |
Filed by: philringnalda [at] gmail.com https://treeherder.mozilla.org/logviewer.html#?job_id=2939418&repo=autoland https://archive.mozilla.org/pub/firefox/tinderbox-builds/autoland-win32-debug/1472756001/autoland_xp_ix-debug_test-mochitest-media-bm127-tests1-windows-build21.txt.gz
Comment hidden (Intermittent Failures Robot) |
Comment 2•8 years ago
|
||
Eitan, any idea what might have made this angry around the beginning of September?
status-firefox51:
--- → affected
status-firefox52:
--- → affected
Flags: needinfo?(eitan)
Keywords: crash
See Also: → 1299313
Comment 3•8 years ago
|
||
This didn't happen from a change in speech synth. I suspect it may have to do with bug 1262053. alwu wrote both our AudioChannelAgent support and the patches in bug 1262053. Do you have any idea?
Flags: needinfo?(eitan) → needinfo?(alwu)
Comment 4•8 years ago
|
||
Indeed, that looks like a very likely candidate. Bug 1299313 was filed on the 30th of August.
Assignee | ||
Updated•8 years ago
|
Assignee: nobody → alwu
Flags: needinfo?(alwu)
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment hidden (mozreview-request) |
Assignee | ||
Updated•8 years ago
|
Attachment #8808100 -
Flags: review?(eitan)
Assignee | ||
Comment 14•8 years ago
|
||
https://treeherder.mozilla.org/#/jobs?repo=try&revision=0b4fdcafbb3b1485893b4266a5c13f7a158dd1fc&selectedJob=30556662
Comment 15•8 years ago
|
||
mozreview-review |
Comment on attachment 8808100 [details] Bug 1300016 - only suspend web-speech when mUtterance exists. https://reviewboard.mozilla.org/r/91026/#review92002 Thanks!
Attachment #8808100 -
Flags: review?(eitan) → review+
Comment 16•8 years ago
|
||
Pushed by alwu@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/117b0fa754f7 only suspend web-speech when mUtterance exists. r=eeejay
Comment 17•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/117b0fa754f7
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Comment 18•8 years ago
|
||
Please request Beta approval on this when you get a chance (for 51, assuming that this won't get approved and landed before Monday's uplift)?
status-firefox50:
--- → unaffected
Flags: needinfo?(alwu)
Assignee | ||
Comment 19•8 years ago
|
||
Comment on attachment 8808100 [details] Bug 1300016 - only suspend web-speech when mUtterance exists. Approval Request Comment [Feature/regressing bug #]: Fix the intermittent crash because of using the null pointer. [User impact if declined]: Intermittent crash. [Describe test coverage new/current, TreeHerder]: Yes, it already be covered by our test cases. [Risks and why]: almost no risk, because we just added the null pointer checking. [String/UUID change made/needed]: no
Flags: needinfo?(alwu)
Attachment #8808100 -
Flags: approval-mozilla-beta?
Attachment #8808100 -
Flags: approval-mozilla-aurora?
Comment 20•8 years ago
|
||
Comment on attachment 8808100 [details] Bug 1300016 - only suspend web-speech when mUtterance exists. Fix an intermittent test failure. Take it in 51 aurora.
Attachment #8808100 -
Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
Comment hidden (Intermittent Failures Robot) |
Comment 22•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/263190e20543
Comment 23•8 years ago
|
||
Comment on attachment 8808100 [details] Bug 1300016 - only suspend web-speech when mUtterance exists. This was uplifted to 51 before the merge to beta, so beta uplift is no longer relevant.
Attachment #8808100 -
Flags: approval-mozilla-beta?
You need to log in
before you can comment on or make changes to this bug.
Description
•