Closed Bug 1300206 Opened 4 years ago Closed 4 years ago

Preemptively fix unified build bustage in layout/generic

Categories

(Core :: Layout, defect)

Product:
Core
Component:
Layout
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla51
Tracking Flags:
Tracking Status
firefox51 --- fixed

People

(Reporter: dholbert, Assigned: dholbert)

References

Details

Attachments

(2 files)

log of build errors being fixed here
9.71 KB, text/plain
Details
Bug 1300206: Add some missing #includes & namespaces in layout/generic, to prevent unified build bustage.
58 bytes, text/x-review-board-request
mats
: review+
Details 
In bug 1269046, I'm tentatively planning on adding a new file called layout/generic/CSSAlignUtils.cpp.

When adding it (even as an empty file) to UNIFIED_SOURCES, it shifts unified-compilation grouping a bit, which breaks the build due to some files not including/"using" stuff that they should.

Patch coming up to preemptively add some missing includes & declarations to avoid this problem.
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Comment on attachment 8787781 [details]
Bug 1300206: Add some missing #includes & namespaces in layout/generic, to prevent unified build bustage.

https://reviewboard.mozilla.org/r/76468/#review74558
Attachment #8787781 - Flags: review?(mats) → review+
Pushed by dholbert@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/459476bdc5d6
Add some missing #includes & namespaces in layout/generic, to prevent unified build bustage. r=mats
https://hg.mozilla.org/mozilla-central/rev/459476bdc5d6
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Blocks: 1344954
You need to log in before you can comment on or make changes to this bug.