Closed
Bug 1300206
Opened 6 years ago
Closed 6 years ago
Preemptively fix unified build bustage in layout/generic
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla51
Tracking | Status | |
---|---|---|
firefox51 | --- | fixed |
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(2 files)
In bug 1269046, I'm tentatively planning on adding a new file called layout/generic/CSSAlignUtils.cpp. When adding it (even as an empty file) to UNIFIED_SOURCES, it shifts unified-compilation grouping a bit, which breaks the build due to some files not including/"using" stuff that they should. Patch coming up to preemptively add some missing includes & declarations to avoid this problem.
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → dholbert
Status: NEW → ASSIGNED
Comment hidden (mozreview-request) |
Comment 2•6 years ago
|
||
mozreview-review |
Comment on attachment 8787781 [details] Bug 1300206: Add some missing #includes & namespaces in layout/generic, to prevent unified build bustage. https://reviewboard.mozilla.org/r/76468/#review74558
Attachment #8787781 -
Flags: review?(mats) → review+
Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/459476bdc5d6 Add some missing #includes & namespaces in layout/generic, to prevent unified build bustage. r=mats
Comment 4•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/459476bdc5d6
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
You need to log in
before you can comment on or make changes to this bug.
Description
•