1300206 - Preemptively fix unified build bustage in layout/generic

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Daniel Holbert [:dholbert]]

Attachment: log of build errors being fixed here

In bug 1269046, I'm tentatively planning on adding a new file called layout/generic/CSSAlignUtils.cpp.

When adding it (even as an empty file) to UNIFIED_SOURCES, it shifts unified-compilation grouping a bit, which breaks the build due to some files not including/"using" stuff that they should.

Patch coming up to preemptively add some missing includes & declarations to avoid this problem.

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1300206: Add some missing #includes & namespaces in layout/generic, to prevent unified build bustage.

Review commit: https://reviewboard.mozilla.org/r/76468/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/76468/

Comment 2

[Mats Palmgren (inactive)]

Comment on attachment 8787781 [details]
Bug 1300206: Add some missing #includes & namespaces in layout/generic, to prevent unified build bustage.

https://reviewboard.mozilla.org/r/76468/#review74558

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/459476bdc5d6
Add some missing #includes & namespaces in layout/generic, to prevent unified build bustage. r=mats

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/459476bdc5d6