1344954 - Preemptively fix unified build bustage in layout/generic

Status: RESOLVED FIXED

(Core :: Layout, defect)

Description

[Daniel Holbert [:dholbert]]

Following up on bug 1300206 -- non-unified builds are busted in layout/generic again, with a build warning (fatal on treeherder):

 0:29.05 In file included from /scratch/work/builds/mozilla-inbound/mozilla/layout/generic/nsCanvasFrame.cpp:8:
 0:29.05 In file included from /scratch/work/builds/mozilla-inbound/mozilla/layout/generic/nsCanvasFrame.h:13:
 0:29.05 In file included from /scratch/work/builds/mozilla-inbound/mozilla/layout/generic/nsContainerFrame.h:12:
 0:29.05 In file included from /scratch/work/builds/mozilla-inbound/mozilla/layout/generic/nsSplittableFrame.h:15:
 0:29.05 In file included from /scratch/work/builds/mozilla-inbound/mozilla/layout/generic/nsFrame.h:14:
 0:29.05 In file included from /scratch/work/builds/mozilla-inbound/mozilla/layout/xul/nsBox.h:10:
 0:29.05 Warning: -Wundefined-inline in /scratch/work/builds/mozilla-inbound/mozilla/layout/generic/nsIFrame.h: inline function 'nsIFrame::PropagateRootElementWritingMode' is not defined
 0:29.05 /scratch/work/builds/mozilla-inbound/mozilla/layout/generic/nsIFrame.h:3650:15: warning: inline function 'nsIFrame::PropagateRootElementWritingMode' is not defined [-Wundefined-inline]
 0:29.05   inline void PropagateRootElementWritingMode(mozilla::WritingMode aRootElemWM);


nsCanvasFrame.cpp just needs to include nsIFrameInlines.h, to provide PropagateRootElementWritingMode (which it calls at line 818, added in bug 1342801).

Comment 1

[Daniel Holbert [:dholbert]]

Attachment: Bug 1344954: Give nsCanvasFrame.cpp an include for nsIFrameInlines.h.

It needs this #include in order to get the (inlined) impl for its call to
PropagateRootElementWritingMode().

Review commit: https://reviewboard.mozilla.org/r/117760/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/117760/

Comment 2

[Ting-Yu Lin [:TYLin] (PST, UTC-8)]

Comment on attachment 8844242 [details]
Bug 1344954: Give nsCanvasFrame.cpp an include for nsIFrameInlines.h.

https://reviewboard.mozilla.org/r/117760/#review119488

Steal this simple review. Looks good to me :)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/afb6ab597614
Give nsCanvasFrame.cpp an include for nsIFrameInlines.h. r=TYLin

Comment 4

[Daniel Holbert [:dholbert]]

Thanks! :)

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/afb6ab597614

Comment 6

[Mats Palmgren (inactive)]

Comment on attachment 8844242 [details]
Bug 1344954: Give nsCanvasFrame.cpp an include for nsIFrameInlines.h.

https://reviewboard.mozilla.org/r/117760/#review121320