Closed
Bug 1344954
Opened 7 years ago
Closed 7 years ago
Preemptively fix unified build bustage in layout/generic
Categories
(Core :: Layout, defect)
Core
Layout
Tracking
()
RESOLVED
FIXED
mozilla55
People
(Reporter: dholbert, Assigned: dholbert)
References
Details
Attachments
(1 file)
Following up on bug 1300206 -- non-unified builds are busted in layout/generic again, with a build warning (fatal on treeherder): 0:29.05 In file included from /scratch/work/builds/mozilla-inbound/mozilla/layout/generic/nsCanvasFrame.cpp:8: 0:29.05 In file included from /scratch/work/builds/mozilla-inbound/mozilla/layout/generic/nsCanvasFrame.h:13: 0:29.05 In file included from /scratch/work/builds/mozilla-inbound/mozilla/layout/generic/nsContainerFrame.h:12: 0:29.05 In file included from /scratch/work/builds/mozilla-inbound/mozilla/layout/generic/nsSplittableFrame.h:15: 0:29.05 In file included from /scratch/work/builds/mozilla-inbound/mozilla/layout/generic/nsFrame.h:14: 0:29.05 In file included from /scratch/work/builds/mozilla-inbound/mozilla/layout/xul/nsBox.h:10: 0:29.05 Warning: -Wundefined-inline in /scratch/work/builds/mozilla-inbound/mozilla/layout/generic/nsIFrame.h: inline function 'nsIFrame::PropagateRootElementWritingMode' is not defined 0:29.05 /scratch/work/builds/mozilla-inbound/mozilla/layout/generic/nsIFrame.h:3650:15: warning: inline function 'nsIFrame::PropagateRootElementWritingMode' is not defined [-Wundefined-inline] 0:29.05 inline void PropagateRootElementWritingMode(mozilla::WritingMode aRootElemWM); nsCanvasFrame.cpp just needs to include nsIFrameInlines.h, to provide PropagateRootElementWritingMode (which it calls at line 818, added in bug 1342801).
Comment hidden (mozreview-request) |
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8844242 [details] Bug 1344954: Give nsCanvasFrame.cpp an include for nsIFrameInlines.h. https://reviewboard.mozilla.org/r/117760/#review119488 Steal this simple review. Looks good to me :)
Attachment #8844242 -
Flags: review+
Pushed by dholbert@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/afb6ab597614 Give nsCanvasFrame.cpp an include for nsIFrameInlines.h. r=TYLin
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/afb6ab597614
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8844242 [details] Bug 1344954: Give nsCanvasFrame.cpp an include for nsIFrameInlines.h. https://reviewboard.mozilla.org/r/117760/#review121320
Attachment #8844242 -
Flags: review?(mats)
Updated•7 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•