1300395 - Port bug 1289951 to c-c [Introduce a mozIntl component that will be exposing non-public JS Intl APIs]

Status: RESOLVED FIXED

(Thunderbird :: Build Config, defect)

Description

[Richard Marti (:Paenglab)]

A new mozIntl toolkit component needs to be added to the installer.

SM has bug 1300349

Comment 1

[Richard Marti (:Paenglab)]

Attachment: mozintl.patch

Taking aleth as reviewer because of the im change.

Comment 2

[Jorg K (CEST = GMT+2)]

I think we should add suite as a service to them, they've been very helpful lately ;-)

Comment 3

[Jorg K (CEST = GMT+2)]

Attachment: mozintl.patch (added suite part).

Added suite part.

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 8787964 [details] [diff] [review]
mozintl.patch (added suite part).

r=jorgk for the mail part ;-)
And I'm happy to wear the blame for suite/ too.

Comment 5

[Jorg K (CEST = GMT+2)]

Oops, I forgot to post this comment:

Looks like we need this, since without it, we have a new test failure here:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=290c845b1d5569a8e3208669cb2ceaffa3d153b9&selectedJob=45403

TEST-UNEXPECTED-FAIL | toolkit/components/mozintl/test/test_mozintl.js | xpcshell return code: 0

Comment 6

[Richard Marti (:Paenglab)]

The suite part is in bug 1300349 with his own review request.

Comment 7

[Jorg K (CEST = GMT+2)]

Comment on attachment 8787964 [details] [diff] [review]
mozintl.patch (added suite part).

Sorry.

Comment 8

[Jorg K (CEST = GMT+2)]

Sorry again, you mentioned bug 1300349 in comment #0.

Comment 9

[aleth [:aleth]]

Comment on attachment 8787939 [details] [diff] [review]
mozintl.patch

Review of attachment 8787939 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 10

[Richard Marti (:Paenglab)]

https://hg.mozilla.org/comm-central/rev/0f5187adc68b