Closed Bug 1300395 Opened 5 years ago Closed 5 years ago

Port bug 1289951 to c-c [Introduce a mozIntl component that will be exposing non-public JS Intl APIs]

Categories

(Thunderbird :: Build Config, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 51.0

People

(Reporter: Paenglab, Assigned: Paenglab)

References

Details

Attachments

(1 file, 1 obsolete file)

A new mozIntl toolkit component needs to be added to the installer.

SM has bug 1300349
Attached patch mozintl.patchSplinter Review
Taking aleth as reviewer because of the im change.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8787939 - Flags: review?(aleth)
Blocks: 1289951
I think we should add suite as a service to them, they've been very helpful lately ;-)
Added suite part.
Attachment #8787939 - Attachment is obsolete: true
Attachment #8787939 - Flags: review?(aleth)
Attachment #8787964 - Flags: review?(aleth)
Comment on attachment 8787964 [details] [diff] [review]
mozintl.patch (added suite part).

r=jorgk for the mail part ;-)
And I'm happy to wear the blame for suite/ too.
Attachment #8787964 - Flags: review+
Oops, I forgot to post this comment:

Looks like we need this, since without it, we have a new test failure here:
https://treeherder.mozilla.org/#/jobs?repo=comm-central&revision=290c845b1d5569a8e3208669cb2ceaffa3d153b9&selectedJob=45403

TEST-UNEXPECTED-FAIL | toolkit/components/mozintl/test/test_mozintl.js | xpcshell return code: 0
The suite part is in bug 1300349 with his own review request.
Attachment #8787939 - Attachment is obsolete: false
Attachment #8787939 - Flags: review?(aleth)
Comment on attachment 8787964 [details] [diff] [review]
mozintl.patch (added suite part).

Sorry.
Attachment #8787964 - Attachment is obsolete: true
Attachment #8787964 - Flags: review?(aleth)
Sorry again, you mentioned bug 1300349 in comment #0.
Comment on attachment 8787939 [details] [diff] [review]
mozintl.patch

Review of attachment 8787939 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!
Attachment #8787939 - Flags: review?(aleth) → review+
https://hg.mozilla.org/comm-central/rev/0f5187adc68b
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 51.0
You need to log in before you can comment on or make changes to this bug.