Opening options for Web Extensions produces XML parsing errors on Android

RESOLVED FIXED in Firefox 51

Status

()

Toolkit
WebExtensions: Android
P2
normal
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: Wladimir Palant, Assigned: mattw)

Tracking

(Blocks: 2 bugs)

Trunk
mozilla51
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 fixed)

Details

(Whiteboard: triaged)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Reporter)

Description

2 years ago
I tried installing the Web Extension build of Easy Passwords on Android. Opening about:addons and clicking on Easy Passwords produces the following error:

> XML Parsing Error: mismatched tag. Expected: </link>.
Location: jar:file:///data/data/org.mozilla.fennec/files/mozilla/plt5hfoi.default/extensions/easypasswords@palant.de.xpi!/data/options/options.html
Line Number 15, Column 5:

It seems that Web Extensions options aren't supported on Android yet, it rather expects XUL options.
Component: WebExtensions → WebExtensions: Android

Comment 1

2 years ago
Let's see if we can fix that error and file another bug about adding in options_ui support.
Assignee: nobody → mwein
Priority: -- → P2
Whiteboard: triaged
(Assignee)

Updated

2 years ago
Blocks: 1302504
Comment hidden (mozreview-request)
Comment on attachment 8790996 [details]
Bug 1300808 - Only load options pages on Android for OPTIONS_TYPE_INLINE.

https://reviewboard.mozilla.org/r/78552/#review77152

This works, I guess, but I think that the correct solution is for the add-on manager UI to either ignore OPTIONS_TYPE_INLINE_BROWSER, or treat it as if it were OPTIONS_TYPE_TAB.
Attachment #8790996 - Flags: review?(kmaglione+bmo) → review-
Comment hidden (mozreview-request)
Comment on attachment 8790996 [details]
Bug 1300808 - Only load options pages on Android for OPTIONS_TYPE_INLINE.

https://reviewboard.mozilla.org/r/78552/#review77364

::: mobile/android/chrome/content/aboutAddons.js:229
(Diff revision 2)
>      let opType = this._getOpTypeForOperations(aAddon.pendingOperations);
>      let updateable = (aAddon.permissions & AddonManager.PERM_CAN_UPGRADE) > 0;
>      let uninstallable = (aAddon.permissions & AddonManager.PERM_CAN_UNINSTALL) > 0;
> +    let optionsURL = aAddon.optionsURL || "";
> +
> +    // TODO(matt): Remove once HTML options pages are supported - Bug 1302504.

We'll still need this check, and another one to decide how to handle options pages based on the type. So please re-word the comment to reflect this.
Attachment #8790996 - Flags: review?(kmaglione+bmo) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment on attachment 8791384 [details]
Bug 1300808 - Enable eslint for browser/mobile/chrome.

https://reviewboard.mozilla.org/r/78802/#review77428

Fine with me if everything else in that tree passes.
Attachment #8791384 - Flags: review?(kmaglione+bmo) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

2 years ago
Keywords: checkin-needed

Comment 15

2 years ago
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/fx-team/rev/5b40e209b9a7
Enable eslint for browser/mobile/chrome. r=kmag
https://hg.mozilla.org/integration/fx-team/rev/e3646efc3a07
Only load options pages on Android for OPTIONS_TYPE_INLINE. r=kmag
Keywords: checkin-needed

Comment 16

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/5b40e209b9a7
https://hg.mozilla.org/mozilla-central/rev/e3646efc3a07
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51

Updated

a year ago
Depends on: 1329027

Updated

a year ago
Depends on: 1360448
You need to log in before you can comment on or make changes to this bug.