1300808 - Opening options for Web Extensions produces XML parsing errors on Android

Status: RESOLVED FIXED

(WebExtensions :: Android, defect, P2)

Description

[Wladimir Palant]

I tried installing the Web Extension build of Easy Passwords on Android. Opening about:addons and clicking on Easy Passwords produces the following error:

> XML Parsing Error: mismatched tag. Expected: </link>.
Location: jar:file:///data/data/org.mozilla.fennec/files/mozilla/plt5hfoi.default/extensions/[e-mail]!/data/options/options.html
Line Number 15, Column 5:

It seems that Web Extensions options aren't supported on Android yet, it rather expects XUL options.

Comment 1

[Andy McKay]

Let's see if we can fix that error and file another bug about adding in options_ui support.

Comment 2

[Matthew Wein [:mattw]]

Attachment: Bug 1300808 - Only load options pages on Android for OPTIONS_TYPE_INLINE.

Review commit: https://reviewboard.mozilla.org/r/78552/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/78552/

Comment 3

[Kris Maglione [:kmag]]

Comment on attachment 8790996 [details]
Bug 1300808 - Only load options pages on Android for OPTIONS_TYPE_INLINE.

https://reviewboard.mozilla.org/r/78552/#review77152

This works, I guess, but I think that the correct solution is for the add-on manager UI to either ignore OPTIONS_TYPE_INLINE_BROWSER, or treat it as if it were OPTIONS_TYPE_TAB.

Comment 4

[Matthew Wein [:mattw]]

Comment on attachment 8790996 [details]
Bug 1300808 - Only load options pages on Android for OPTIONS_TYPE_INLINE.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/78552/diff/1-2/

Comment 5

[Kris Maglione [:kmag]]

Comment on attachment 8790996 [details]
Bug 1300808 - Only load options pages on Android for OPTIONS_TYPE_INLINE.

https://reviewboard.mozilla.org/r/78552/#review77364

::: mobile/android/chrome/content/aboutAddons.js:229
(Diff revision 2)
>      let opType = this._getOpTypeForOperations(aAddon.pendingOperations);
>      let updateable = (aAddon.permissions & AddonManager.PERM_CAN_UPGRADE) > 0;
>      let uninstallable = (aAddon.permissions & AddonManager.PERM_CAN_UNINSTALL) > 0;
> +    let optionsURL = aAddon.optionsURL || "";
> +
> +    // TODO(matt): Remove once HTML options pages are supported - Bug 1302504.

We'll still need this check, and another one to decide how to handle options pages based on the type. So please re-word the comment to reflect this.

Comment 6

[Matthew Wein [:mattw]]

Attachment: Bug 1300808 - Enable eslint for browser/mobile/chrome.

Review commit: https://reviewboard.mozilla.org/r/78802/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/78802/

Comment 7

[Matthew Wein [:mattw]]

Comment on attachment 8790996 [details]
Bug 1300808 - Only load options pages on Android for OPTIONS_TYPE_INLINE.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/78552/diff/2-3/

Comment 8

[Matthew Wein [:mattw]]

Comment on attachment 8790996 [details]
Bug 1300808 - Only load options pages on Android for OPTIONS_TYPE_INLINE.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/78552/diff/3-4/

Comment 9

[Matthew Wein [:mattw]]

Comment on attachment 8791384 [details]
Bug 1300808 - Enable eslint for browser/mobile/chrome.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/78802/diff/1-2/

Comment 10

[Matthew Wein [:mattw]]

Comment on attachment 8791384 [details]
Bug 1300808 - Enable eslint for browser/mobile/chrome.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/78802/diff/2-3/

Comment 11

[Matthew Wein [:mattw]]

Comment on attachment 8790996 [details]
Bug 1300808 - Only load options pages on Android for OPTIONS_TYPE_INLINE.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/78552/diff/4-5/

Comment 12

[Kris Maglione [:kmag]]

Comment on attachment 8791384 [details]
Bug 1300808 - Enable eslint for browser/mobile/chrome.

https://reviewboard.mozilla.org/r/78802/#review77428

Fine with me if everything else in that tree passes.

Comment 13

[Matthew Wein [:mattw]]

Comment on attachment 8791384 [details]
Bug 1300808 - Enable eslint for browser/mobile/chrome.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/78802/diff/3-4/

Comment 14

[Matthew Wein [:mattw]]

Comment on attachment 8790996 [details]
Bug 1300808 - Only load options pages on Android for OPTIONS_TYPE_INLINE.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/78552/diff/5-6/

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/5b40e209b9a7
Enable eslint for browser/mobile/chrome. r=kmag
https://hg.mozilla.org/integration/fx-team/rev/e3646efc3a07
Only load options pages on Android for OPTIONS_TYPE_INLINE. r=kmag

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5b40e209b9a7
https://hg.mozilla.org/mozilla-central/rev/e3646efc3a07