Closed Bug 1300808 Opened 7 years ago Closed 7 years ago

Opening options for Web Extensions produces XML parsing errors on Android


(WebExtensions :: Android, defect, P2)



(firefox51 fixed)

Tracking Status
firefox51 --- fixed


(Reporter: ecfbugzilla, Assigned: mattw)



(Whiteboard: triaged)


(2 files)

I tried installing the Web Extension build of Easy Passwords on Android. Opening about:addons and clicking on Easy Passwords produces the following error:

> XML Parsing Error: mismatched tag. Expected: </link>.
Location: jar:file:///data/data/org.mozilla.fennec/files/mozilla/plt5hfoi.default/extensions/!/data/options/options.html
Line Number 15, Column 5:

It seems that Web Extensions options aren't supported on Android yet, it rather expects XUL options.
Component: WebExtensions → WebExtensions: Android
Let's see if we can fix that error and file another bug about adding in options_ui support.
Assignee: nobody → mwein
Priority: -- → P2
Whiteboard: triaged
Blocks: 1302504
Comment on attachment 8790996 [details]
Bug 1300808 - Only load options pages on Android for OPTIONS_TYPE_INLINE.

This works, I guess, but I think that the correct solution is for the add-on manager UI to either ignore OPTIONS_TYPE_INLINE_BROWSER, or treat it as if it were OPTIONS_TYPE_TAB.
Attachment #8790996 - Flags: review?(kmaglione+bmo) → review-
Comment on attachment 8790996 [details]
Bug 1300808 - Only load options pages on Android for OPTIONS_TYPE_INLINE.

::: mobile/android/chrome/content/aboutAddons.js:229
(Diff revision 2)
>      let opType = this._getOpTypeForOperations(aAddon.pendingOperations);
>      let updateable = (aAddon.permissions & AddonManager.PERM_CAN_UPGRADE) > 0;
>      let uninstallable = (aAddon.permissions & AddonManager.PERM_CAN_UNINSTALL) > 0;
> +    let optionsURL = aAddon.optionsURL || "";
> +
> +    // TODO(matt): Remove once HTML options pages are supported - Bug 1302504.

We'll still need this check, and another one to decide how to handle options pages based on the type. So please re-word the comment to reflect this.
Attachment #8790996 - Flags: review?(kmaglione+bmo) → review+
Comment on attachment 8791384 [details]
Bug 1300808 - Enable eslint for browser/mobile/chrome.

Fine with me if everything else in that tree passes.
Attachment #8791384 - Flags: review?(kmaglione+bmo) → review+
Keywords: checkin-needed
Pushed by
Enable eslint for browser/mobile/chrome. r=kmag
Only load options pages on Android for OPTIONS_TYPE_INLINE. r=kmag
Keywords: checkin-needed
Depends on: 1329027
Depends on: 1360448
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.