Closed Bug 1360448 Opened 3 years ago Closed 3 years ago

addon options menus don't appear, redux

Categories

(Firefox for Android :: Add-on Manager, defect, P1)

51 Branch
All
Android
defect

Tracking

()

VERIFIED FIXED
Firefox 55
Tracking Status
firefox53 --- wontfix
firefox54 --- verified
firefox55 --- fixed

People

(Reporter: JanH, Assigned: mattw)

References

(Blocks 1 open bug)

Details

(Keywords: regression, Whiteboard: triaged)

Attachments

(1 file)

+++ This bug was initially created as a clone of Bug #1329027 +++

So bug 1329027 fixed the options UI on Android for the probably most common case (add-ons using OPTIONS_TYPE_INLINE), but it seems like some addons use other types, e.g. "Save Link Menus" uses OPTIONS_TYPE_DIALOG.

That is probably technically not correct, but it used to work nevertheless, so instead of blocking everything and only respecting the add-ons option URL for OPTIONS_TYPE_INLINE, we should just specifically block OPTIONS_TYPE_INLINE_BROWSER for bug 1300808 until that bit is properly supported.
Assignee: nobody → mwein
Whiteboard: triaged
Comment on attachment 8866613 [details]
Bug 1360448 - Only ignore OPTIONS_TYPE_INLINE_BROWSER instead of ignoring all types which aren't OPTIONS_TYPE_INLINE

Switching review request to mixedpuppy because kmag is behind on reviews.
Attachment #8866613 - Flags: review?(kmaglione+bmo) → review?(mixedpuppy)
Comment on attachment 8866613 [details]
Bug 1360448 - Only ignore OPTIONS_TYPE_INLINE_BROWSER instead of ignoring all types which aren't OPTIONS_TYPE_INLINE

https://reviewboard.mozilla.org/r/138216/#review144194
Attachment #8866613 - Flags: review?(mixedpuppy) → review+
Pushed by mwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/54d8c1a5ca9a
Only ignore OPTIONS_TYPE_INLINE_BROWSER instead of ignoring all types which aren't OPTIONS_TYPE_INLINE r=mixedpuppy
https://hg.mozilla.org/mozilla-central/rev/54d8c1a5ca9a
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Please request Beta approval on this when you get a chance. I've verified that it grafts cleanly.
Flags: needinfo?(mwein)
Comment on attachment 8866613 [details]
Bug 1360448 - Only ignore OPTIONS_TYPE_INLINE_BROWSER instead of ignoring all types which aren't OPTIONS_TYPE_INLINE

Thanks Ryan

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1300808 
[User impact if declined]: Options pages will not appear for non-WE options which don't use AddonManager.OPTIONS_TYPE_INLINE.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]: No
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: This change explicitly ignores the option type we don't want to support, instead of trying to only support the option type we expect. It turns out that some non-WE addons use other option types, so doing it this way fixes the problem and is less risky moving forward.
[String changes made/needed]: N/A
Flags: needinfo?(mwein)
Attachment #8866613 - Flags: approval-mozilla-beta?
> [Has the fix been verified in Nightly?]: No

I think this change is very low risk, but if you think it should be verified on Nightly first, I'll be happy to go ahead and do that.
Comment on attachment 8866613 [details]
Bug 1360448 - Only ignore OPTIONS_TYPE_INLINE_BROWSER instead of ignoring all types which aren't OPTIONS_TYPE_INLINE

Fix a follow-up issue of Bug #1329027. Beta54+. Should be in 54 beta 10.
Attachment #8866613 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Tested and verified with Asus ZenPad 8(Android 6.0.1) and Huawei Honor (Android 5.1.1). 
Build: 55.0a1 and 54 Beta 10. 
The testing was based on comments from Bug 1329027 and the issue is not reproducible.
Status: RESOLVED → VERIFIED
Sorry for confusion here, on Nightly from 05-19 isn't fixed or the patch is not landed. Verified only on Beta 10.
See Also: → 1402790
You need to log in before you can comment on or make changes to this bug.