1301040 - persist drop down filter state

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (frontend), defect, P3)

Description

[[e-mail] (:bhearsum)]

The new dropdown rules filter from bug 1241760 has made the rules page easier to navigate, but its state doesn't persist if you leave the page and go back to it (whether through the back/forward button), or by clicking back to "rules". We almost never want to view all of the rules at once, so I think the most sensible thing to do is to persist the state of that filter somehow.

Comment 1

[Nick Thomas [:nthomas] (UTC+12)]

Bonus points for being able to link to rules with a filter applied.

Comment 2

[Wasif Hyder]

Hi,

I'd like to work on this. Can you advise me on how to get started?

Comment 3

[[e-mail] (:bhearsum)]

(In reply to Wasif Hyder from comment #2)
> Hi,
> 
> I'd like to work on this. Can you advise me on how to get started?

Hi Wasif, thanks for your interest! To get started, I suggest making sure you can run the Balrog development environment first. Instructions for that are in the README: https://github.com/mozilla/balrog/blob/master/README.rst

Once you're able to browse to http://localhost:8080, go to the Rules page (http://localhost:8080/rules) and reproduce this issue by:
1) Changing the "Product/Channel filter" drop down
2) Browsing to a different page by clicking a link at the top
3) Browsing back to the Rules page by clicking the link at the top

Notice that the Product/Channel filter is reset to "All rules" after step 3. The desired behaviour is for it to use the previous value. Satisfying Nick's request in comment #1 most likely means that the state should be reflected in the URL somewhere.

I suspect that the fix for this is most likely in the controller that powers that page: https://github.com/mozilla/balrog/blob/master/ui/app/js/controllers/rules_controller.js

I know this is a lot of information to take in, so don't hesitate to ask if you have any questions! You can also join us in the developer channel at irc://irc.mozilla.org/#balrog.

Comment 4

[[e-mail] (:bhearsum)]

Did you make any progress here, Wasif?

Comment 5

[Wasif Hyder]

Hi Ben,

Yes. I've been learning up on Angular and managed to make the requested changes. I've created a pull request and submitted a patch here.

I tried adding the data to the URL but haven't been able to figure out how to do that. Would like advice on that, if its a useful feature. Otherwise, the task is done.

Cheers.

Comment 6

[Wasif Hyder]

Attachment: Pull Request

Comment 7

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/b709987df76d5d0ed9c3789463502c653b0a734c
bug 1301040: persist drop down filter state on Rules page (#239). r=bhearsum,aksareen

Comment 8

[Wasif Hyder]

Hi Ben,

Is there anything else I can work on?

Comment 9

[[e-mail] (:bhearsum)]

(In reply to Wasif Hyder from comment #8)
> Hi Ben,
> 
> Is there anything else I can work on?

It looks like found a few things!

Comment 10

[[e-mail] (:bhearsum)]

This is in production now, nice job Wasif!

Comment 11

[[e-mail] (:bhearsum)]

I know we still want to be able to send links to filtered versions of the Rules page. I filed that as https://bugzilla.mozilla.org/show_bug.cgi?id=1337929.