1301067 - don't close modals without confirmation when clicking outside of them

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (frontend), defect)

Description

[[e-mail] (:bhearsum)]

I sometimes misclick when trying to hit "Save Changes", and click outside of the modal area. Doing this is the equivalent of hitting "Cancel" - it throws away my changes and I have to do them again.

It would be good to either ask for confirmation before closing the modal, or simply don't do anything when clicking outside of (require the user to click "Cancel" specifically" to close it without saving changes).

Comment 1

[Aaron]

Hi I would like to take up this issue. Can you tell me how to proceed?

Comment 2

[Aaron]

Attachment: Solved the issue by adding static backdrop option to all modalInstance variable declarations(in 4 files).

Comment 3

[[e-mail] (:bhearsum)]

(In reply to Aaron from comment #1)
> Hi I would like to take up this issue. Can you tell me how to proceed?

Looks like you got the work itself figured out. The patch looks good to me! Would you mind sending this as a Pull Request to https://github.com/mozilla/balrog? That's where we do most of our work.

Comment 4

[Aaron]

Ok i added a pull request for the same. Please review it.

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/f379a802281469023154d023af3416326f59f480
bug 1301067: don't close modals without confirmation when clicking outside of them (#193). r=bhearsum

Comment 6

[[e-mail] (:bhearsum)]

This is in production now, thank you very much Aaron! If you'd like to do more UI work there's plenty available :)