1301104 - Add a probe for the big tab spinner for degenerate cases

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

We have the probe FX_TAB_SWITCH_SPINNER_VISIBLE_MS which measures how long the tab spinner is displayed. Unfortunately, the "high" on that probe is 1000, and we're seeing entries from Telemetry in a higher range. We'd like to understand that a bit more by creating a new probe which a higher ceiling.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1301104 - Add tab spinner interstitial probe with a higher ceiling to better measure degenerate cases.

Review commit: https://reviewboard.mozilla.org/r/77272/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77272/

Comment 2

[Mike Conley (:mconley) (:⚙️)]

Hey liuche, as a data stewardship peer, are you cool signing off on this new probe? I'll likely be taking it up to at least beta.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Hey lizzard,

This is something that the e10s team is hoping to have as a ridealong as part of the 49 RC1. It's a very straightforward, safe patch that just adds a new probe (same as an existing probe, but different buckets).

Comment 4

[Bill McCloskey [inactive unless it's an emergency] (:billm)]

Comment on attachment 8788970 [details]
Bug 1301104 - Add tab spinner interstitial probe with a higher ceiling to better measure degenerate cases.

https://reviewboard.mozilla.org/r/77272/#review75546

Changing the existing histogram will break something?

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8788970 [details]
Bug 1301104 - Add tab spinner interstitial probe with a higher ceiling to better measure degenerate cases.

https://reviewboard.mozilla.org/r/77272/#review75546

Apparently, yes. See bug 1300891 for gritty details.

Comment 6

[Chris H-C :chutten]

Comment on attachment 8788970 [details]
Bug 1301104 - Add tab spinner interstitial probe with a higher ceiling to better measure degenerate cases.

https://reviewboard.mozilla.org/r/77272/#review75568

::: toolkit/components/telemetry/Histograms.json:4499
(Diff revision 1)
>      "description": "Firefox: If the spinner interstitial displays during tab switching, records the time in ms the graphic is visible"
>    },
> +  "FX_TAB_SWITCH_SPINNER_VISIBLE_LONG_MS": {
> +    "expires_in_version": "default",
> +    "kind": "exponential",
> +    "high": 64000,

If this is only for long cases, you can specify a "low" value. It'll still accumulate values lower than "low" into a special 0-low bucket, to make counting easier, but it'll save your resolution for the part of the range you care about most.

Comment 7

[Chris H-C :chutten]

Comment on attachment 8788970 [details]
Bug 1301104 - Add tab spinner interstitial probe with a higher ceiling to better measure degenerate cases.

https://reviewboard.mozilla.org/r/77272/#review75570

::: toolkit/components/telemetry/Histograms.json:4497
(Diff revision 1)
>      "high": 1000,
>      "n_buckets": 20,
>      "description": "Firefox: If the spinner interstitial displays during tab switching, records the time in ms the graphic is visible"
>    },
> +  "FX_TAB_SWITCH_SPINNER_VISIBLE_LONG_MS": {
> +    "expires_in_version": "default",

Also, don't use "default". Either use "never" if you really mean "never", or specify a version

Comment 8

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8788970 [details]
Bug 1301104 - Add tab spinner interstitial probe with a higher ceiling to better measure degenerate cases.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77272/diff/1-2/

Comment 9

[Chris H-C :chutten]

Comment on attachment 8788970 [details]
Bug 1301104 - Add tab spinner interstitial probe with a higher ceiling to better measure degenerate cases.

https://reviewboard.mozilla.org/r/77272/#review75592

Comment 10

[Chenxia Liu [:liuche]]

Comment on attachment 8788970 [details]
Bug 1301104 - Add tab spinner interstitial probe with a higher ceiling to better measure degenerate cases.

https://reviewboard.mozilla.org/r/77272/#review75606

r+ from a data review perspective.

Comment 11

[Mike Conley (:mconley) (:⚙️)]

Author: Mike Conley <[e-mail]>
Bug number: 1301104
Commit message: Bug 1301104 - Add tab spinner interstitial probe with a higher ceiling to better measure degenerate cases. r=billm,chutten data-review=liuche

Comment 12

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8788970 [details]
Bug 1301104 - Add tab spinner interstitial probe with a higher ceiling to better measure degenerate cases.

Approval Request Comment
[Feature/regressing bug #]:

e10s

[User impact if declined]:

Unclear. This patch adds a Telemetry probe that we're hoping will shed some light on bug 1300411, and how widespread it is.

[Describe test coverage new/current, TreeHerder]:

No test coverage, but the new probe acts in the exact same way as a previous probe - it just uses different bucketing.

[Risks and why]: 

Very low risk.

[String/UUID change made/needed]:

None.

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c8096f896f7c
Add tab spinner interstitial probe with a higher ceiling to better measure degenerate cases. r=billm,chutten,liuche

Comment 14

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

We are just about to build RC2.  I could delay a short while and take this on m-r. Seems low risk enough.

Comment 15

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

Comment on attachment 8788970 [details]
Bug 1301104 - Add tab spinner interstitial probe with a higher ceiling to better measure degenerate cases.

[Triage Comment]

Uplift for RC2 so we will be better able to diagnose e10s tab switch issue on release.

Comment 16

[Liz Henry (:lizzard) (privacy/fingerprinting team)]

I think this will have to wait till rc3. Sorry.

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c8096f896f7c

Comment 18

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c580c468fdb4
 https://hg.mozilla.org/releases/mozilla-beta/rev/3cbdde40fc56
https://hg.mozilla.org/releases/mozilla-release/rev/2d23fe5dc5e2