1301435 - Make FX_TAB_SWITCH_SPINNER_VISIBLE_MS and FX_TAB_SWITCH_SPINNER_VISIBLE_LONG_MS opt-out probes

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Mike Conley (:mconley) (:⚙️)]

We talked about this in the e10s meeting today - to get a better sense of how often these spinners are being seen by our user base, we want a really high resolution pictures, which means an opt-out probe.

Comment 1

[Mike Conley (:mconley) (:⚙️)]

Attachment: Bug 1301435 - Make FX_TAB_SWITCH_SPINNER_VISIBLE_MS and FX_TAB_SWITCH_SPINNER_VISIBLE_LONG_MS opt-out probes.

Review commit: https://reviewboard.mozilla.org/r/77668/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/77668/

Comment 2

[Mike Conley (:mconley) (:⚙️)]

[Tracking Requested - why for this release]:

The e10s team is highly motivated to get a high-resolution picture of tab switch spinner sightings in the wild.

Comment 3

[Benjamin Smedberg]

Comment on attachment 8789466 [details]
Bug 1301435 - Make FX_TAB_SWITCH_SPINNER_VISIBLE_MS and FX_TAB_SWITCH_SPINNER_VISIBLE_LONG_MS opt-out probes.

https://reviewboard.mozilla.org/r/77668/#review75958

::: toolkit/components/telemetry/Histograms.json:4490
(Diff revision 1)
>      "high": 1000,
>      "n_buckets": 20,
>      "description": "Firefox: Time in ms between tab selection and tab content paint."
>    },
>    "FX_TAB_SWITCH_SPINNER_VISIBLE_MS": {
>      "expires_in_version": "default",

Please make both of these expires_in_version: 56

data-review=me with this change

BTW do these metrics have some automated test that verifies we won't break the metric? If not please file a followup bug for that (it's desirable for opt-in metrics, but required for opt-out metrics).

Comment 4

[Benjamin Smedberg]

Comment on attachment 8789466 [details]
Bug 1301435 - Make FX_TAB_SWITCH_SPINNER_VISIBLE_MS and FX_TAB_SWITCH_SPINNER_VISIBLE_LONG_MS opt-out probes.

https://reviewboard.mozilla.org/r/77668/#review75960

Comment 5

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8789466 [details]
Bug 1301435 - Make FX_TAB_SWITCH_SPINNER_VISIBLE_MS and FX_TAB_SWITCH_SPINNER_VISIBLE_LONG_MS opt-out probes.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/77668/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a036e98d75c1
Make FX_TAB_SWITCH_SPINNER_VISIBLE_MS and FX_TAB_SWITCH_SPINNER_VISIBLE_LONG_MS opt-out probes. r=bsmedberg

Comment 7

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8789466 [details]
Bug 1301435 - Make FX_TAB_SWITCH_SPINNER_VISIBLE_MS and FX_TAB_SWITCH_SPINNER_VISIBLE_LONG_MS opt-out probes.

Approval Request Comment
[Feature/regressing bug #]:

n/a. The e10s team met today and decided that we really want a high-resolution idea of how bad the big spinner problem is out in the wild. We therefore want these probes to be opt-out.

[User impact if declined]:

None - though we'll have not as good an understanding of big tab spinner sightings in the wild.

[Describe test coverage new/current, TreeHerder]:

None, I'm afraid - although this just changes some probe settings to make them both last longer, and make the opt-out instead of opt-in.

[Risks and why]: 

Very low risk, imo.

[String/UUID change made/needed]:

None.

Comment 8

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8789466 [details]
Bug 1301435 - Make FX_TAB_SWITCH_SPINNER_VISIBLE_MS and FX_TAB_SWITCH_SPINNER_VISIBLE_LONG_MS opt-out probes.

For e10s and glory, let us uplift this for 49 RC3.

Comment 9

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/a036e98d75c1

Comment 10

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/db18fa39e618

Comment 11

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

https://hg.mozilla.org/releases/mozilla-beta/rev/feb92d55b4b9

Comment 12

[Ryan VanderMeulen [:RyanVM][PTO June 24-28]]

https://hg.mozilla.org/releases/mozilla-release/rev/feb92d55b4b9

Comment 13

[Gerry Chang [:gchang]]

Track 49+/50+/51+ for spinner change for e10s.