Make sure to actually hold a death grip on callback in ErrorNotifier::Run() and CallbackResultNotifier::Run()

RESOLVED FIXED in Firefox 50

Status

()

Core
DOM
RESOLVED FIXED
2 years ago
a year ago

People

(Reporter: mystor, Assigned: mystor)

Tracking

unspecified
mozilla51
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox50 fixed, firefox51 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
This was causing tc-X(8) permafail on inbound.
(Assignee)

Comment 1

2 years ago
Created attachment 8788968 [details] [diff] [review]
Make sure to actually hold a death grip on callback in ErrorNotifier::Run() and CallbackResultNotifier::Run()

MozReview-Commit-ID: 28K4VmKoqgO
Attachment #8788968 - Flags: review?(bugs)
(Assignee)

Updated

2 years ago
Blocks: 1018486

Updated

2 years ago
Attachment #8788968 - Flags: review?(bugs) → review+

Comment 2

2 years ago
Pushed by michael@thelayzells.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b808c63a394
Make sure to actually hold a death grip on callback in ErrorNotifier::Run() and CallbackResultNotifier::Run(), r=smaug
(Assignee)

Updated

2 years ago
Blocks: 1301127

Comment 3

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1b808c63a394
Status: NEW → RESOLVED
Last Resolved: 2 years ago
status-firefox51: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
(Assignee)

Comment 4

a year ago
Comment on attachment 8788968 [details] [diff] [review]
Make sure to actually hold a death grip on callback in ErrorNotifier::Run() and CallbackResultNotifier::Run()

Approval Request Comment
[Feature/regressing bug #]:Bug 1018486 being uplifted caused this failure again on beta because I forgot about applying this patch and bug 1301127 too.
[User impact if declined]:Test failures on beta
[Describe test coverage new/current, TreeHerder]:This is a small fix to correct a test failure.
[Risks and why]: Very low risks. Changes nothing which could break anything.
[String/UUID change made/needed]:None

Land this patch before bug 1301127. bug 1301127 undoes the changes in this patch and applies the correct fix.
Attachment #8788968 - Flags: approval-mozilla-beta?
Comment on attachment 8788968 [details] [diff] [review]
Make sure to actually hold a death grip on callback in ErrorNotifier::Run() and CallbackResultNotifier::Run()

Fix has been in Nightly for ~2 weeks, it fixes a test failure, Beta50+
Attachment #8788968 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Updated

a year ago
status-firefox50: --- → affected

Comment 6

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/f6f6a67f5f1d
status-firefox50: affected → fixed
You need to log in before you can comment on or make changes to this bug.