1301124 - Make sure to actually hold a death grip on callback in ErrorNotifier::Run() and CallbackResultNotifier::Run()

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Nika Layzell [:nika] (ooo, ni? for response)]

This was causing tc-X(8) permafail on inbound.

Comment 1

[Nika Layzell [:nika] (ooo, ni? for response)]

Attachment: Make sure to actually hold a death grip on callback in ErrorNotifier::Run() and CallbackResultNotifier::Run()

MozReview-Commit-ID: 28K4VmKoqgO

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1b808c63a394
Make sure to actually hold a death grip on callback in ErrorNotifier::Run() and CallbackResultNotifier::Run(), r=smaug

Comment 3

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1b808c63a394

Comment 4

[Nika Layzell [:nika] (ooo, ni? for response)]

Comment on attachment 8788968 [details] [diff] [review]
Make sure to actually hold a death grip on callback in ErrorNotifier::Run() and CallbackResultNotifier::Run()

Approval Request Comment
[Feature/regressing bug #]:Bug 1018486 being uplifted caused this failure again on beta because I forgot about applying this patch and bug 1301127 too.
[User impact if declined]:Test failures on beta
[Describe test coverage new/current, TreeHerder]:This is a small fix to correct a test failure.
[Risks and why]: Very low risks. Changes nothing which could break anything.
[String/UUID change made/needed]:None

Land this patch before bug 1301127. bug 1301127 undoes the changes in this patch and applies the correct fix.

Comment 5

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8788968 [details] [diff] [review]
Make sure to actually hold a death grip on callback in ErrorNotifier::Run() and CallbackResultNotifier::Run()

Fix has been in Nightly for ~2 weeks, it fixes a test failure, Beta50+

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/f6f6a67f5f1d