1301127 - Some mozIStorageStatementCallback instances passed to ErrorNotifier or CallbackResultNotifier do not QueryInterface to mozIStorageStatementCallback

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Nika Layzell [:nika] (ni? for response)]

See bug 1301124, in which this issue is temporarily fixed.

The implementers of this interface should make sure that their QueryInterface implementation is correct.

Comment 1

[Nika Layzell [:nika] (ni? for response)]

Attachment: Make nsNavHistoryFolderResultNode QueryInterface to mozIStorageStatementCallback

MozReview-Commit-ID: 5CPNIz3w4Iy

Comment 2

[Olli Pettay [:smaug][[e-mail]]]

I guess we don't have any nice macros to deal this kind of multi-inheritance.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/15dfa78b6aab
Make nsNavHistoryFolderResultNode QueryInterface to mozIStorageStatementCallback, r=smaug

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/15dfa78b6aab

Comment 5

[Nika Layzell [:nika] (ni? for response)]

Comment on attachment 8788973 [details] [diff] [review]
Make nsNavHistoryFolderResultNode QueryInterface to mozIStorageStatementCallback

Approval Request Comment
[Feature/regressing bug #]:Bug 1018486 being uplifted caused this failure again on beta because I forgot about applying this patch and bug 1301124 too.
[User impact if declined]:Test failures on beta
[Describe test coverage new/current, TreeHerder]:This is a small fix to correct a test failure.
[Risks and why]: Very low risks. Changes nothing which could break anything.
[String/UUID change made/needed]:None

Comment 6

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8788973 [details] [diff] [review]
Make nsNavHistoryFolderResultNode QueryInterface to mozIStorageStatementCallback

Fix has been in Nightly for ~2 weeks, it fixes a test failure, Beta50+

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/917fe502471a