1301222 - Identify the Firefox theme clearly in crash reports

Status: RESOLVED FIXED

(Socorro :: Webapp, task)

Description

[Nicholas Nethercote [inactive]]

The Firefox theme shows up in crash reports (in the extensions tab) as "{972ce4c6-7e08-4474-a285-3208198ce6fd}". This often confuses people. (See bug 1300467 comment 3 for a recent example.)

Other built-in extensions get more identifiable names, like "[e-mail]", "[e-mail]", [e-mail]" and "[e-mail]". It should be possible to use "[e-mail]" or something like that for the default theme.

If that's too difficult, then crash-stats should be modified to handle this extension name specially.

Comment 1

[:Gijs (he/him)]

(In reply to Nicholas Nethercote [:njn] from comment #0)
> If that's too difficult

I think it's not difficult to change it (though IIRC there's a bunch of random places in the code and not a clear constant we could just change the value of), but what *would* be difficult is updating all the other software (add-ons etc.) that's used to the current situation. Cf. https://dxr.mozilla.org/addons/search?q=972ce4c6 (which has quite a lot of duplicate hits, so it's hard to determine exactly how big the problem there is... ).

So from my perspective it would be easier to update crash-stats.

Comment 2

[Dão Gottwald [:dao]]

We're not going to change the internal id at this point.

Comment 3

[Nicholas Nethercote [inactive]]

(In reply to Dão Gottwald [:dao] from comment #2)
> We're not going to change the internal id at this point.

That's fine, I can take the crash-stats route. Thanks for the info.

Comment 4

[Lonnen :lonnen]

I had some spare time so I grabbed this. PR is up here: https://github.com/mozilla/socorro/pull/3462

Comment 5

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/991171dcf54fbe40b247ede4a72e4b77b7c64a29
fixes bug 1301222 with a transform rule (#3462)

* fixes bug 1301222 with a transform rule

add a transform rule to mutate the default theme's extension id into a more easily identifiable string

* (no bug) - moar docstring for ThemePrettyNameRule

Add an additional caveat to the docstring of the ThemePrettyNameRule

* bug 130122 - fixup for reviewer comments

alters the prettified name of the default theme according to nnethercote's PR comments over the suggestion in the original bug

* bug 1301222 - reviewers comments 1

rework the ThemePrettyNameRule to use a dictionary of conversions
rather than detecting one specific conversion.

* (nobug) - pep8 mozilla_transform_rules

pep8 fixes to make mozilla_transform_rules comply with the style guide

* Bug 1301222 - Added tests for predicate.

* bug 1301222 - reviewers comments 2

This alters the predicate behavior in the case that a processed
crash is missing an addons property to use a null list rather than
test for the property. This preserves the structural similarity
between the predicate and action methods without sacrificing the
safety of the test method.

Comment 6

[Nicholas Nethercote [inactive]]

Thank you for doing this, lonnen.

Comment 7

[Lonnen :lonnen]

NP. It will go out in our next production push, probably tomorrow.

Comment 8

[Nicholas Nethercote [inactive]]

Attachment: Link to Github pull-request: https://github.com/mozilla/socorro/pull/3462

Comment 9

[Nicholas Nethercote [inactive]]

(In reply to Nicholas Nethercote [:njn] from comment #8)
> Created attachment 8791838 [details] [review]
> Link to Github pull-request: https://github.com/mozilla/socorro/pull/3462

Sorry, wrong bug.

Comment 10

[Peter Bengtsson [:peterbe]]

This is causing confusion for non-Firefox crashes. 
See this Thunderbird crash: https://crash-stats.mozilla.com/report/index/559957b9-ca90-4896-a445-df0072161001#tab-extensions

Interesting that the default theme is the same in Firefox as it is in Thunderbird. 

We could either solve this by changing the conversion to something like: "Default theme" (instead of "Default Firefox theme"). 
Or we can make it a more advanced thing like like: "Default {product} theme" and in the _action() method we extract the product name from the processed_crash. 

What do you prefer Lonnen?

Comment 11

[Lonnen :lonnen]

No strong preference

Comment 12

[Peter Bengtsson [:peterbe]]

Attachment: Link to Github pull-request: https://github.com/mozilla/socorro/pull/3524

Comment 13

[[github robot]]

Commit pushed to master at https://github.com/mozilla/socorro

https://github.com/mozilla/socorro/commit/d9ba4c0b5cd187e7efdae854107d25a416d0d18a
fixes bug 1301222 - label the default theme "Default theme" (#3524)