Closed Bug 1301351 Opened 3 years ago Closed 3 years ago

Remove bogus "toolbarbutton" class from manage-share-providers and add-share-provider buttons

Categories

(Firefox Graveyard :: SocialAPI, defect)

defect
Not set

Tracking

(firefox52 fixed)

RESOLVED FIXED
Firefox 52
Tracking Status
firefox52 --- fixed

People

(Reporter: dao, Assigned: vi.le, Mentored)

References

Details

(Keywords: good-first-bug, Whiteboard: [good first bug][lang=xul])

Attachments

(1 file)

AFAIK there's no CSS or JS code doing anything with a "toolbarbutton" class. We should remove it.

The manage-share-providers and add-share-provider buttons can be found in browser/base/content/browser.xul
Keywords: good-first-bug
Hello, can I work on it please ? :-)
(In reply to sky from comment #1)
> Hello, can I work on it please ? :-)

Sure. Let me know if you have questions.
Assignee: nobody → sky
Attachment #8793872 - Flags: review?(dao+bmo)
Comment on attachment 8793872 [details] [diff] [review]
remove-toolbarbutton-class.patch

Looks good. Thanks!
Attachment #8793872 - Flags: review?(dao+bmo) → review+
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/de39e964b958
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Mark 51 as fix-optional. If it's worth uplift to 51, feel free to nominate it.
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.