Closed
Bug 1301351
Opened 8 years ago
Closed 8 years ago
Remove bogus "toolbarbutton" class from manage-share-providers and add-share-provider buttons
Categories
(Firefox Graveyard :: SocialAPI, defect)
Firefox Graveyard
SocialAPI
Tracking
(firefox52 fixed)
RESOLVED
FIXED
Firefox 52
| Tracking | Status | |
|---|---|---|
| firefox52 | --- | fixed |
People
(Reporter: dao, Assigned: vincent, Mentored)
References
Details
(Keywords: good-first-bug, Whiteboard: [good first bug][lang=xul])
Attachments
(1 file)
|
1.61 KB,
patch
|
dao
:
review+
|
Details | Diff | Splinter Review |
AFAIK there's no CSS or JS code doing anything with a "toolbarbutton" class. We should remove it. The manage-share-providers and add-share-provider buttons can be found in browser/base/content/browser.xul
|
Reporter | |
Updated•8 years ago
|
Keywords: good-first-bug
|
Assignee | |
Comment 1•8 years ago
|
||
Hello, can I work on it please ? :-)
|
|
Reporter | |
Comment 2•8 years ago
|
||
(In reply to sky from comment #1) > Hello, can I work on it please ? :-) Sure. Let me know if you have questions.
Assignee: nobody → sky
|
|
Assignee | |
Comment 3•8 years ago
|
||
Attachment #8793872 -
Flags: review?(dao+bmo)
|
|
Reporter | |
Comment 4•8 years ago
|
||
Comment on attachment 8793872 [details] [diff] [review] remove-toolbarbutton-class.patch Looks good. Thanks!
Attachment #8793872 -
Flags: review?(dao+bmo) → review+
|
|
Reporter | |
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by dgottwald@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/de39e964b958 Remove the toolbarbutton class; r=dao
Keywords: checkin-needed
|
||
Comment 6•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/de39e964b958
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
|
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/de39e964b958
|
||
Comment 8•8 years ago
|
||
Mark 51 as fix-optional. If it's worth uplift to 51, feel free to nominate it.
|
|
Reporter | |
Updated•8 years ago
|
status-firefox51:
fix-optional → ---
|
||
Updated•5 years ago
|
Product: Firefox → Firefox Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•