Closed Bug 1301624 Opened 8 years ago Closed 8 years ago

Improve d3 graph style

Categories

(DevTools :: Shared Components, defect, P3)

Product:
DevTools
Component:
Shared Components
Type:
defect

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Firefox 52

People

(Reporter: ntim, Assigned: ntim)

References

Details

Attachments

(3 files)

Improve d3 graph style
6.11 KB, patch
jryans
: review+
hholmes
: ui-review+
Details | Diff | Splinter Review
dark-theme-graph.png
80.84 KB, image/png
Details
light-theme-graph.png
78.87 KB, image/png
Details
No description provided.
Attachment #8789698 - Flags: review?(bgrinstead)
Attached image dark-theme-graph.png —
Attached image light-theme-graph.png —
Attachment #8789698 - Flags: ui-review?(hholmes)
Priority: -- → P3
Just waiting for feedback from Helen before reviewing
ui-review ping.
Flags: needinfo?(hholmes)
Flags: needinfo?(hholmes)
Attachment #8789698 - Flags: ui-review?(hholmes) → ui-review+
review ping
Flags: needinfo?(bgrinstead)
oh, just saw bgrins is now unavailable
Flags: needinfo?(bgrinstead)
Attachment #8789698 - Flags: review?(bgrinstead) → review?(jryans)
Comment on attachment 8789698 [details] [diff] [review] Improve d3 graph style Review of attachment 8789698 [details] [diff] [review]: ----------------------------------------------------------------- Thanks, looks great to me! Update commit message to change reviewer.
Attachment #8789698 - Flags: review?(jryans) → review+
https://hg.mozilla.org/mozilla-central/rev/7e1ba3ec88a1
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Depends on: 1409684
Product: Firefox → DevTools
status-firefox52: fixed → ---
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: