1301705 - Update tests that directly interact with current debugger frontend to support the new frontend

Status: RESOLVED FIXED

(DevTools :: Debugger, defect, P3)

Description

[Brian Grinstead [:bgrins]]

In Bug 1300861 to land the new UI in nightly we will be forcing on the current debugger UI for tests that are directly interacting with it and expecting certain properties or DOM structure.

We should get these tests working with the new frontend or come up with alternate testing strategy for these things before preffing on further

Comment 1

[James Long (:jlongster)]

This is the etherpad that lists the tests we disabled: https://public.etherpad-mozilla.org/p/LSpcXe7hqC

Comment 2

[James Long (:jlongster)]

As far as I know, these are the remaining tests that need to be updated to work against the new debugger. Note that this doesn't mean features are broken; as far as I know, we've fixed every interaction between other tools and the debugger. The problem with these tests are they use the old debugger-specific APIs by accessing its window directly.

We should update these at some point, but it doesn't need to block the uplift to dev edition.


devtools/client/canvasdebugger/test/browser_canvas-frontend-call-stack-01.js
devtools/client/canvasdebugger/test/browser_canvas-frontend-call-stack-02.js

devtools/client/framework/test/browser_source_map-01.js
devtools/client/framework/test/browser_source_map-02.js

devtools/client/framework/test/browser_toolbox_split_console.js
devtools/client/framework/test/browser_toolbox_view_source_01.js
devtools/client/framework/test/browser_toolbox_view_source_02.js

devtools/client/webconsole/test/browser_console_optimized_out_vars.js
devtools/client/webconsole/test/browser_console_variables_view_while_debugging.js
devtools/client/webconsole/test/browser_console_variables_view_while_debugging_and_inspecting.js 
devtools/client/webconsole/test/browser_eval_in_debugger_stackframe.js
devtools/client/webconsole/test/browser_eval_in_debugger_stackframe2.js
devtools/client/webconsole/test/browser_webconsole_autocomplete_in_debugger_stackframe.js
devtools/client/webconsole/test/browser_webconsole_bug_1050691_click_function_to_source.js
devtools/client/webconsole/test/browser_webconsole_bug_766001_JS_Console_in_Debugger.js
devtools/client/webconsole/test/browser_webconsole_closure_inspection.js 
devtools/client/webconsole/test/browser_webconsole_input_field_focus_on_panel_select.js

Comment 3

[Nicolas Chevobbe [:nchevobbe]]

Some of those tests are going to be copied over the new console frontend.
Jason, why did you wontfix this ?

Comment 4

[Jason Laster [:jlast]]

That was a mistake.

Comment 5

[Jason Laster [:jlast]]

I believe this was fixed now that the old debugger is gone