Closed Bug 1302355 Opened 3 years ago Closed 3 years ago

Make --arrowpanel-dimmed* colors work with dark OS themes

Categories

(Firefox :: Theme, defect, P3)

defect

Tracking

()

RESOLVED FIXED
Firefox 51
Tracking Status
firefox51 --- fixed

People

(Reporter: dao, Assigned: dao)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Attached patch patchSplinter Review
--arrowpanel-dimmed and friends are currently invisible with dark OS themes such as Windows high-contrast themes and dark Gtk themes.

This change fixes that and shouldn't make a significant difference for light OS themes.
Attachment #8790592 - Flags: review?(past)
Comment on attachment 8790592 [details] [diff] [review]
patch

Review of attachment 8790592 [details] [diff] [review]:
-----------------------------------------------------------------

Semantically I like the 0% saturation, and as promised, the change wasn't obvious to me on Linux with the default theme, so yay!
Attachment #8790592 - Flags: review?(past) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/4ef3d01a12c6
Make --arrowpanel-dimmed* colors work with dark OS themes. r=past
https://hg.mozilla.org/mozilla-central/rev/4ef3d01a12c6
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
You need to log in before you can comment on or make changes to this bug.