1302907 - Run mozharness from source checkout if available

Status: RESOLVED FIXED

(Firefox Build System :: Task Configuration, task)

Description

[Gregory Szorc [:gps]]

In bug 1296397, I added source checkouts to WPT tests with the eventual intent of running tests from source checkouts.

The next step towards getting the tests running from the source checkout will be running mozharness from the source checkout (as opposed to downloading mozharness from a zip file).

I have patches written and am testing them now...

Comment 1

[Gregory Szorc [:gps]]

Attachment: Bug 1302907 - Merge test-ubuntu1204.sh and test-ubuntu1604.sh;

The only difference in these files was the order that pulseaudio is
started and whether compiz is started. We rename test-ubuntu1604.sh
to test-ubuntu.sh, add some distro release detection, and add
some conditional branches so it works on both Ubuntu 12.04 and 16.04.

Review commit: https://reviewboard.mozilla.org/r/78846/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/78846/

Comment 2

[Gregory Szorc [:gps]]

Attachment: Bug 1302907 - Use relative path to mozharness script;

Mozharness scripts all live in "mozharness/scripts." So, we don't need
to redundantly define this path. Let's define the script as the relative
path within "mozharness/scripts" instead.

IMO this cosmetic improvement can stand on its own. However, the real
reason for this change is to pave the way for running mozharness from
a source checkout instead of downloading a zip archive of it.

Review commit: https://reviewboard.mozilla.org/r/78848/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/78848/

Comment 3

[Gregory Szorc [:gps]]

Attachment: Bug 1302907 - Use relative path to mozharness configs;

Same deal as the last commit except for config paths.

Review commit: https://reviewboard.mozilla.org/r/78850/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/78850/

Comment 4

[Gregory Szorc [:gps]]

Attachment: Bug 1302907 - Run mozharness from source checkout if available;

Currently, build tasks produce a zip file artifact containing the
content of testing/mozharness.  This zip file is downloaded and applied
by any test using mozharness (which is most of them).

Now that some tests have a source checkout, we don't need to download
a mozharness zip because we can just use the source checkout.

This commit teaches test-ubuntu.sh to accept a custom path to
mozharness files. If that path is defined, we skip downloading the
mozharness zip.

The taskgraph has been updated to pass the path of mozharness in the
checkout to test-ubuntu.sh when a source checkout is available.

Review commit: https://reviewboard.mozilla.org/r/78852/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/78852/

Comment 5

[Gregory Szorc [:gps]]

Comment on attachment 8791446 [details]
Bug 1302907 - Run mozharness from source checkout if available;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/78852/diff/1-2/

Comment 6

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8791445 [details]
Bug 1302907 - Use relative path to mozharness configs;

https://reviewboard.mozilla.org/r/78850/#review77566

r+100

Comment 7

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8791446 [details]
Bug 1302907 - Run mozharness from source checkout if available;

https://reviewboard.mozilla.org/r/78852/#review77572

Comment 8

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8791444 [details]
Bug 1302907 - Use relative path to mozharness script;

https://reviewboard.mozilla.org/r/78848/#review77574

Comment 9

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8791443 [details]
Bug 1302907 - Merge test-ubuntu1204.sh and test-ubuntu1604.sh;

https://reviewboard.mozilla.org/r/78846/#review77576

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f227ea4d52fe
Merge test-ubuntu1204.sh and test-ubuntu1604.sh; r=dustin
https://hg.mozilla.org/integration/autoland/rev/11ffdc56f5be
Use relative path to mozharness script; r=dustin
https://hg.mozilla.org/integration/autoland/rev/dda84d1fb12b
Use relative path to mozharness configs; r=dustin
https://hg.mozilla.org/integration/autoland/rev/21fdf73bbb17
Run mozharness from source checkout if available; r=dustin

Comment 11

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/738d1903807f
Backed out changesets 11ffdc565be, dda84d1fb12b, and 21fdf73bbb17 for Windows build bustage

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

And the other patch backed out in https://hg.mozilla.org/integration/autoland/rev/9b42d4b1f448 because it caused updated packages to be pulled in, causing a number of tests to start failing on linux64 asan and debug:
https://treeherder.mozilla.org/logviewer.html#?job_id=3573922&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=3573974&repo=autoland
https://treeherder.mozilla.org/logviewer.html#?job_id=3573909&repo=autoland


2:37 PM <gps> regenerating the docker image caused us to pick up an updated package from upstream
2:37 PM <gps> and that somehow broke tests
2:38 PM <gps> this happened to the build image in bug 1272629
2:38 PM <gps> KWierso: if you back out f227ea4d52fe the old Docker images should be used
2:38 PM <gps> but the next person to cause the docker images to regenerate will cause the same bustage

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/11ffdc56f5be

Comment 14

[Gregory Szorc [:gps]]

Comment on attachment 8791443 [details]
Bug 1302907 - Merge test-ubuntu1204.sh and test-ubuntu1604.sh;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/78846/diff/1-2/

Comment 15

[Gregory Szorc [:gps]]

Comment on attachment 8791444 [details]
Bug 1302907 - Use relative path to mozharness script;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/78848/diff/1-2/

Comment 16

[Gregory Szorc [:gps]]

Comment on attachment 8791445 [details]
Bug 1302907 - Use relative path to mozharness configs;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/78850/diff/1-2/

Comment 17

[Gregory Szorc [:gps]]

Comment on attachment 8791446 [details]
Bug 1302907 - Run mozharness from source checkout if available;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/78852/diff/2-3/

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/320ba0b826ef
Merge test-ubuntu1204.sh and test-ubuntu1604.sh; r=dustin
https://hg.mozilla.org/integration/autoland/rev/f97b8171f208
Use relative path to mozharness script; r=dustin
https://hg.mozilla.org/integration/autoland/rev/e7bc7d69d75f
Use relative path to mozharness configs; r=dustin
https://hg.mozilla.org/integration/autoland/rev/1b9675d9049b
Run mozharness from source checkout if available; r=dustin

Comment 19

[Gregory Szorc [:gps]]

Fixed the underlying Docker issue in flight (twas a minor shell script issue) and relanded.

Comment 20

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/320ba0b826ef
https://hg.mozilla.org/mozilla-central/rev/f97b8171f208
https://hg.mozilla.org/mozilla-central/rev/e7bc7d69d75f
https://hg.mozilla.org/mozilla-central/rev/1b9675d9049b