Perform a firefox checkout when running wpt tests

RESOLVED FIXED in mozilla51

Status

task
RESOLVED FIXED
3 years ago
2 years ago

People

(Reporter: gps, Assigned: gps)

Tracking

(Blocks 1 bug)

unspecified
mozilla51
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

Before we actually run WPT tests from a source checkout (bug 1286900), I want automation to start performing a checkout as part of the task.

The main reason I want to do this is to validate that automation is capable of performing the checkout without issue. I'm particularly interested in what the new load to hg.mozilla.org will do to those servers. I'm pretty sure we have the capacity. But TC's patterns of spawning hundreds of workers at the same time could make things... interesting.
Comment on attachment 8782588 [details]
Bug 1296397 - Add source checkout to web platform test tasks;

https://reviewboard.mozilla.org/r/72694/#review70400

I'm OK with this landing as-is, even if I think it's a little "too much rope", as it is a good way to start judging total load on hg.m.o.

::: taskcluster/taskgraph/transforms/tests/test_description.py:118
(Diff revision 2)
>          int,
>          {'by-test-platform': {basestring: int}},
>      ),
>  
> +    # Where to put a VCS checkout of the Firefox repo.
> +    Optional('gecko-checkout'): basestring,

I'd prefer to have this be a boolean -- I don't think there will ever be a good reason to do checkouts in arbitrary directories, so allowing specification of a directory just means writing the same directory name several times, for a flexibility we'd rather not ever be used.
Attachment #8782588 - Flags: review?(dustin) → review+
Comment on attachment 8782588 [details]
Bug 1296397 - Add source checkout to web platform test tasks;

https://reviewboard.mozilla.org/r/72694/#review70400

> I'd prefer to have this be a boolean -- I don't think there will ever be a good reason to do checkouts in arbitrary directories, so allowing specification of a directory just means writing the same directory name several times, for a flexibility we'd rather not ever be used.

I like when someone calls YAGNI on me. I'll make this simpler.
Is this waiting for the build refactoring to make it into central?
Yes, this was stalled by Dustin's work and changes to TaskCluster's log parsing. Both landed today. I'm in the process of rebasing my commits.
Comment on attachment 8790950 [details]
Bug 1296397 - Move VCS task setup functionality to standalone function;

https://reviewboard.mozilla.org/r/78548/#review77278
Attachment #8790950 - Flags: review?(dustin) → review+
Comment on attachment 8782588 [details]
Bug 1296397 - Add source checkout to web platform test tasks;

https://reviewboard.mozilla.org/r/72694/#review77296

::: taskcluster/taskgraph/transforms/tests/test_description.py:123
(Diff revision 6)
>          int,
>          {'by-test-platform': {basestring: int}},
>      ),
>  
> +    # Whether to perform a gecko checkout.
> +    Optional('checkout'): bool,

I'd prefer `Required('checkout', default=False)` here, just to avoid the implied equivalence of property omission and False.
Pushed by gszorc@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/ab5198e198b5
Move VCS task setup functionality to standalone function; r=dustin
https://hg.mozilla.org/integration/autoland/rev/4b447ca3c1ae
Add source checkout to web platform test tasks; r=dustin
Blocks: 1302907
https://hg.mozilla.org/mozilla-central/rev/ab5198e198b5
https://hg.mozilla.org/mozilla-central/rev/4b447ca3c1ae
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla51
Blocks: 1305743
Product: TaskCluster → Firefox Build System
You need to log in before you can comment on or make changes to this bug.