1303076 - Plugincheck page is broken in Nightly 51.0a1

Status: RESOLVED FIXED

(www.mozilla.org :: Pages & Content, defect)

Description

[Alex Gibson [:agibson]]

STR:

1.) Visit https://www.mozilla.org/en-US/plugincheck/ in Firefox Nightly 51.0a1 (2016-09-12).

Expected results:

Plugins should be displayed

Actual results:

The page gets stuck on the loading spinner.

JS error:

TypeError: e is undefined

Comment 1

[Alex Gibson [:agibson]]

This is a regression as a result of Bug 1270364 and Bug 1270366.

I traced the error to this function:

https://github.com/mozilla/bedrock/blob/master/media/js/plugincheck/lib/plugincheck.js#L15-L29

I believe we need to try and avoid enumerating directly on navigator.mimeTypes.

Comment 2

[Alex Gibson [:agibson]]

Attachment: GitHub pull request

Comment 4

[[github robot]]

Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/05c4b3bf3ad084bc86b7d004caf93eabd0811dc4
[fix bug 1303076] Fix plugincheck to avoid enumerating on navigator.mimeTypes

https://github.com/mozilla/bedrock/commit/79d95c317696f958968b03816b78edb252fa8bd8
Merge pull request #4346 from alexgibson/bug-1303076-plugincheck-enumeration

[fix bug 1303076] Fix plugincheck to avoid enumerating on navigator.mimeTypes