Closed Bug 1303076 Opened 8 years ago Closed 8 years ago

Plugincheck page is broken in Nightly 51.0a1

Categories

(www.mozilla.org :: Pages & Content, defect)

Production
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: agibson, Assigned: agibson)

References

Details

Attachments

(1 file)

STR:

1.) Visit https://www.mozilla.org/en-US/plugincheck/ in Firefox Nightly 51.0a1 (2016-09-12).

Expected results:

Plugins should be displayed

Actual results:

The page gets stuck on the loading spinner.

JS error:

TypeError: e is undefined
This is a regression as a result of Bug 1270364 and Bug 1270366.

I traced the error to this function:

https://github.com/mozilla/bedrock/blob/master/media/js/plugincheck/lib/plugincheck.js#L15-L29

I believe we need to try and avoid enumerating directly on navigator.mimeTypes.
Assignee: nobody → agibson
Status: NEW → ASSIGNED
Blocks: 757726
Attached file GitHub pull request
Commits pushed to master at https://github.com/mozilla/bedrock

https://github.com/mozilla/bedrock/commit/05c4b3bf3ad084bc86b7d004caf93eabd0811dc4
[fix bug 1303076] Fix plugincheck to avoid enumerating on navigator.mimeTypes

https://github.com/mozilla/bedrock/commit/79d95c317696f958968b03816b78edb252fa8bd8
Merge pull request #4346 from alexgibson/bug-1303076-plugincheck-enumeration

[fix bug 1303076] Fix plugincheck to avoid enumerating on navigator.mimeTypes
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: