1303248 - Make modal highlighting nightly only.

Status: VERIFIED FIXED

(Toolkit :: Find Toolbar, defect)

Description

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/mozilla-central/rev/5febcc03a729
it's enabled by default on all branches now,

it should be behind NIGHTLY_BUILD.

Comment 1

[Tooru Fujisawa [:arai]]

Attachment: Make modal highlighting nightly only.

bug 1291278 should be fixed (or at least reduce the amount of blocking bugs) before enabling this on all branches.

Comment 2

[Mike de Boer [:mikedeboer]]

Comment on attachment 8791862 [details] [diff] [review]
Make modal highlighting nightly only.

Review of attachment 8791862 [details] [diff] [review]:
-----------------------------------------------------------------

::: browser/app/profile/firefox.js
@@ +1524,5 @@
>  // crash report notification across different days and shutdown
>  // without a user choice before we suppress the notification for
>  // some number of days.
>  pref("browser.crashReports.unsubmittedCheck.chancesUntilSuppress", 4);
> +pref("browser.crashReports.unsubmittedCheck.autoSubmit", false);

I can't see what happened here... \n\r vs \n?

Comment 3

[Tooru Fujisawa [:arai]]

Thank you for reviewing :)

(In reply to Mike de Boer [:mikedeboer] from comment #2)
> Comment on attachment 8791862 [details] [diff] [review]
> Make modal highlighting nightly only.
> 
> Review of attachment 8791862 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: browser/app/profile/firefox.js
> @@ +1524,5 @@
> >  // crash report notification across different days and shutdown
> >  // without a user choice before we suppress the notification for
> >  // some number of days.
> >  pref("browser.crashReports.unsubmittedCheck.chancesUntilSuppress", 4);
> > +pref("browser.crashReports.unsubmittedCheck.autoSubmit", false);
> 
> I can't see what happened here... \n\r vs \n?

accidentally added newline at the end of file, where newline wasn't there.
reverted locally.

Comment 4

[Tooru Fujisawa [:arai]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/00c35bd8acb960ce7e67ef3ee51aa84f8c2a78d4
Bug 1303248 - Make modal highlighting nightly only. r=mikedeboer

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/00c35bd8acb9

Comment 6

[Brindusa Tot, Desktop QA]

Verified as fixed on 
 - Nightly 52.0a1, BuildID: 20160919065232  - modal highlighting is on
 - Aurora 51.0a2. buildID: 20160920004004 -  modal highlighting is off

Comment 7

[Ricardo]

The new findbar in Firefox 50 does not keep highlight active after the bar is closed. All previous versions kept. This is being very uncomfortable for me. I would suggest an option for that, if it was desired. I would also go against "dim the page" change, it simply goes against my usability criteria in many ways.
What bug# tracks these changes to the findbar?