(Build) Remove inactive locales from Firefox Developer Edition builds

RESOLVED FIXED in Firefox 51

Status

RESOLVED FIXED
2 years ago
22 days ago

People

(Reporter: flod, Assigned: flod)

Tracking

unspecified
mozilla51
Dependency tree / graph

Firefox Tracking Flags

(firefox51 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

2 years ago
We have 4 locales that started localizing mozilla-aurora but never reached completion, and have been inactive for several months.

Time to remove them from the build system.

Locales: brx, kok, ks, sat.
(Assignee)

Updated

2 years ago
Summary: Remove stale locales from Firefox Developer Edition builds → Remove inactive locales from Firefox Developer Edition builds
(Assignee)

Comment 1

2 years ago
Created attachment 8792057 [details] [diff] [review]
bug1303401.patch

Users for these locales according to Telemetry
https://sql.telemetry.mozilla.org/queries/1229/source

Tableau's localization report only has 'sat' in the filters, and show 0 users.
Attachment #8792057 - Flags: review?(l10n)
CCing Henrik, not sure if there'd be anything in update tests that might try to update non-existing builds.

Also Justin, shouldn't affect automation, but just to be sure.

flod, should we do product details first?
Flags: needinfo?(francesco.lodolo)
(Assignee)

Comment 3

2 years ago
(In reply to Axel Hecht [:Pike] from comment #2)
> flod, should we do product details first?

Good point. Updating Ship It and product-details sounds like the first step to do, update scripts are going to complain a bit since these locales will be still available in all-locales.
Flags: needinfo?(francesco.lodolo)
(Assignee)

Updated

2 years ago
Depends on: 1303406

Updated

2 years ago
Attachment #8792057 - Flags: review?(l10n) → review+
(Assignee)

Updated

2 years ago
Component: Build Config → Ship It
Product: Firefox → Release Engineering
QA Contact: rail
(Assignee)

Updated

2 years ago
Component: Ship It → Build Config
Product: Release Engineering → Firefox
QA Contact: rail
(In reply to Axel Hecht [:Pike] from comment #2)
> Also Justin, shouldn't affect automation, but just to be sure.

If these had shipped to beta there would be automation impact (e.g. update tests and such)

Since they did not, relengs impact is for merge days (which has no impact):
https://dxr.mozilla.org/mozilla-central/source/testing/mozharness/scripts/merge_day/gecko_migration.py#328

If theres anything else on our end I'm unaware of it (and would like to learn anyway, so if it breaks I'll learn) :-)
Actually, http://hg.mozilla.org/releases/mozilla-beta/file/tip/browser/locales/all-locales has all 4 locales. they're not in shipped-locales, though.

I wouldn't mind removing the locales from all-locales on beta right away, too.
(Assignee)

Comment 6

2 years ago
(In reply to Axel Hecht [:Pike] from comment #5)
> Actually,
> http://hg.mozilla.org/releases/mozilla-beta/file/tip/browser/locales/all-
> locales has all 4 locales. they're not in shipped-locales, though.

I'm a bit surprised: why do we expose them on that page? They're only in all-locales, not in shipped-locales, and I assumed we would build beta and release only for locales in the latter.
(Assignee)

Comment 7

2 years ago
(In reply to Francesco Lodolo [:flod] from comment #6)
> I'm a bit surprised: why do we expose them on that page?

Forget the confusion, I though the link was to a download page on mozilla.org (Friday...).

The Ship It change has been merged, it will be deployed next Monday. I think we're safe to land this in mozilla-aurora, since we're going to have builds for a few more days (no 404 on mozilla.org).
(Assignee)

Comment 8

2 years ago
Comment on attachment 8792057 [details] [diff] [review]
bug1303401.patch

We're removing inactive locales from the build system.

This is a change only for mozilla-aurora, not needed for mozilla-central, and it doesn't affect other builds when riding the trains.

Also no need to relnote, since we only include Beta/Release updates in those.
Attachment #8792057 - Flags: approval-mozilla-aurora?
(Assignee)

Updated

2 years ago
Summary: Remove inactive locales from Firefox Developer Edition builds → (Build) Remove inactive locales from Firefox Developer Edition builds
We do not test any of those locales. But thanks for the heads-up.
50 moved to Beta today. Does this need to land there as well?
Flags: needinfo?(francesco.lodolo)
(Assignee)

Comment 11

2 years ago
(In reply to Ryan VanderMeulen [:RyanVM] from comment #10)
> 50 moved to Beta today. Does this need to land there as well?

No, this patch affects only for the build system on aurora, for Beta we use a different file. It can land on mozilla-aurora after merge day migration.
Flags: needinfo?(francesco.lodolo)
Comment on attachment 8792057 [details] [diff] [review]
bug1303401.patch

Remove inactive locales for aurora. Take it in 51 aurora.
Attachment #8792057 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
status-firefox51: --- → affected
(Assignee)

Comment 13

2 years ago
Thanks, asking for checkin. This needs to land directly in mozilla-aurora, no need for release notes (we track only new locales in beta/release).
Keywords: checkin-needed

Comment 14

2 years ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/f44e863b05e7
status-firefox51: affected → fixed
Keywords: checkin-needed
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 51
(Assignee)

Comment 15

2 years ago
@Pike
Does the dashboard require a manual update in these cases?
Flags: needinfo?(l10n)
(In reply to Francesco Lodolo [:flod] from comment #15)
> @Pike
> Does the dashboard require a manual update in these cases?

Yes. Manual in the "gotta open VPN and a shell" sense. Keeping the needinfo to remind me to do that.
Aurora done.

I'll need to Beta manually again after migration day.
Flags: needinfo?(l10n)
Component: Build Config → General
Product: Firefox → Firefox Build System
Target Milestone: Firefox 51 → mozilla51
You need to log in before you can comment on or make changes to this bug.