1303424 - upgrade to latest version of sqlalchemy and sqlalchemy-migrate

Status: RESOLVED FIXED

(Release Engineering Graveyard :: Applications: Balrog (backend), defect, P3)

Description

[[e-mail] (:bhearsum)]

Now that we're doing a Docker-based deployment, this should be easy :)

Comment 1

[[e-mail] (:bhearsum)]

Ninad is planning to look at this!

Comment 2

[[e-mail] (:bhearsum)]

In https://github.com/mozilla/balrog/pull/233, we discovered some issues with the "unique" constraint disappearing or not getting reported properly. Once this bug is done, we should make sure we re-enable the checks of that constraint (https://github.com/mozilla/balrog/blob/fac5aee1003d7a13810cf2b7fbdd7127921637da/auslib/test/test_db.py#L4052) and make sure we're enforcing it in db.py, too.

Comment 3

[[e-mail] (:bhearsum)]

Ninad, are you still planning to look at this?

Comment 4

[Ninad Bhat[:ninad101]]

I am busy with other things right now. Will unassign it for now. Sorry for the late reply.

Comment 5

[[e-mail] (:bhearsum)]

Some links that might be helpful when doing this:
http://docs.sqlalchemy.org/en/rel_0_9/changelog/migration_09.html
http://docs.sqlalchemy.org/en/rel_1_0/changelog/migration_10.html
http://docs.sqlalchemy.org/en/rel_1_1/changelog/migration_11.html
http://docs.sqlalchemy.org/en/rel_1_1/changelog/migration_11.html

Comment 6

[[e-mail] (:bhearsum)]

Updating summary - only sqlalchemy and sqlalchemy-migrate are out of date now.

Comment 7

[GitHub Bugzilla PR Linker]

Attachment: Link to GitHub pull-request: https://github.com/mozilla/balrog/pull/564

Comment 8

[[github robot]]

Commit pushed to master at https://github.com/mozilla/balrog

https://github.com/mozilla/balrog/commit/e96f058dca6ffd4298d7f4567daedb5a24669563
bug 1303424 - upgrade to latest version of sqlalchemy and sqlalchemy-migrate (#564). r=bhearsum

* SqlAlchemy migrate

* sa migration

* Upgrade SqlAlchemy 0.8.0b2 ---> 0.9.10

* Upgrade SqlAlchemy 0.9.10 ---> 1.0.19

* Upgrade SqlAlchemy 1.0.19 ---> 1.1.18

* Upgrade SqlAlchemy 1.1.18 ---> 1.2.7 (latest)

* Fix SAWarning

* Change MySql connector

* Go back notifications

* rm help comments

* Review

Comment 9

[Nick Thomas [:nthomas] (UTC+12)]

Deployed to prod today. Thanks for working on this Allan, so great to be completely up to date on our python deps.

Comment 10

[Allan [:asilva]]

That is great, let me know if you get any issue.