1303468 - [geckoview] Move files into and out of geckoview to help Gradle compilation

Status: RESOLVED FIXED

(GeckoView :: General, defect)

Description

[Nick Alexander :nalexander [he/him]]

This is follow-up to Bug 1291385 in service of Bug 1291363.  It tracks making the geckoview sources compile more easily under Gradle.

Comment 1

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1303468 - Part 1: Don't refer to Fennec's Locales.

Just duplicate the code.  We can refer to this version from Fennec in
the future.  (If it survives in GeckoView: I expect the ANR and
Telemetry ping code to move out of GeckoView eventually.)

Review commit: https://reviewboard.mozilla.org/r/79366/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79366/

Comment 2

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1303468 - Part 2: Move more things into GeckoView.

Review commit: https://reviewboard.mozilla.org/r/79368/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79368/

Comment 3

[Nick Alexander :nalexander [he/him]]

Attachment: Bug 1303468 - Part 3: Move Fennec- and Gradle-specific file back to base/.

This is only there to silence the linter.

Review commit: https://reviewboard.mozilla.org/r/79364/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79364/

Comment 4

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8792152 [details]
Bug 1303468 - Part 1: Don't refer to Fennec's Locales.

https://reviewboard.mozilla.org/r/79366/#review78186

I actually have a patch to move ANRReporter out of geckoview (it's a telemetry tool that really belongs in Fennec).

Comment 5

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8792153 [details]
Bug 1303468 - Part 2: Move more things into GeckoView.

https://reviewboard.mozilla.org/r/79368/#review78190

Comment 6

[(inactive) Jim Chen [:jchen] [:darchons]]

Comment on attachment 8792154 [details]
Bug 1303468 - Part 3: Move Fennec- and Gradle-specific file back to base/.

https://reviewboard.mozilla.org/r/79364/#review78192

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/49a5ddfbe8a5
Part 1: Move more things into GeckoView. r=jchen
https://hg.mozilla.org/integration/fx-team/rev/d5f96835f835
Part 2: Move Fennec- and Gradle-specific file back to base/. r=jchen

Comment 8

[Nick Alexander :nalexander [he/him]]

Landed the two pieces; jchen is actually going to remove the ANRReporter from GV entirely, so the first part of the original review request is not going to be needed.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/6105bfa46e9a
Follow-up: Unbust Gradle builds. r=me

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/fx-team/rev/d00cd0cd33e6
Follow-up: Unbust Gradle lint. r=me

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/49a5ddfbe8a5
https://hg.mozilla.org/mozilla-central/rev/d5f96835f835
https://hg.mozilla.org/mozilla-central/rev/6105bfa46e9a
https://hg.mozilla.org/mozilla-central/rev/d00cd0cd33e6