The ChromeFilePropertyBag versions of the File constructors are web-observable

RESOLVED FIXED in Firefox 52

Status

()

Core
DOM
P3
normal
RESOLVED FIXED
10 months ago
4 months ago

People

(Reporter: bz, Assigned: baku)

Tracking

({addon-compat, dev-doc-needed})

Trunk
mozilla52
addon-compat, dev-doc-needed
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox51 affected, firefox52 fixed)

Details

Attachments

(1 attachment)

(Reporter)

Description

10 months ago
In particular, if I take a Blob and make it iterable and try to create a File from it, the chrome-only ctor will get called (and throw) instead of calling the right constructor...

Maybe this is not an issue in practice much, but I would be a lot happier if we used chromeonly factory methods instead of the current chrome-ish constructor setup.
(In reply to Boris Zbarsky [:bz] (TPAC) from comment #0)
> Maybe this is not an issue in practice much, but I would be a lot happier if
> we used chromeonly factory methods instead of the current chrome-ish
> constructor setup.

This makes me think P3 but if it's more urgent please change the priority accordingly.
Flags: needinfo?(amarchesini)
Priority: -- → P3
(Assignee)

Updated

9 months ago
Assignee: nobody → amarchesini
Flags: needinfo?(amarchesini)
(Assignee)

Comment 2

9 months ago
Created attachment 8809759 [details] [diff] [review]
boom.patch
Attachment #8809759 - Flags: review?(kyle)
Attachment #8809759 - Flags: review?(kyle) → review+

Comment 3

9 months ago
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/938f7fd2ce2b
Remove the chrome only constructor for File, r=qdot
https://hg.mozilla.org/mozilla-central/rev/938f7fd2ce2b
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52

Updated

8 months ago
Keywords: addon-compat

Comment 5

8 months ago
Could you update the docs: https://developer.mozilla.org/en-US/docs/Extensions/Using_the_DOM_File_API_in_chrome_code
Keywords: dev-doc-needed

Comment 6

5 months ago
Congrats! Your changes - completed undocumented in FF 52 Release Notes - broke our add-on one more time. It took me several hours to figure out why our add-on is not working in FF 52 Beta anymore.

Other add-on authors might be affected too, so please be so kind and update Release Notes accordingly.
(Reporter)

Comment 7

5 months ago
Wait, this bug has addon-compat marked.  Why did that not result in relevant notes for addon developers?
Flags: needinfo?(jorge)
(Reporter)

Comment 8

5 months ago
Though note that general release notes likely wouldn't include something like this anyway except in the general "here's a list of all the changes" way; the "for developers" or addon-developer specific ones might.
It was included in the compat blog post: https://blog.mozilla.org/addons/2016/12/15/compatibility-for-firefox-52/

Not all developers follow it, though, and we didn't do automatic validation for this particular issue.
Flags: needinfo?(jorge)

Updated

4 months ago
Depends on: 1348663

Updated

4 months ago
Depends on: 1348691
You need to log in before you can comment on or make changes to this bug.