Closed Bug 1303518 Opened 3 years ago Closed 3 years ago

The ChromeFilePropertyBag versions of the File constructors are web-observable

Categories

(Core :: DOM: Core & HTML, defect, P3)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox51 --- affected
firefox52 --- fixed

People

(Reporter: bzbarsky, Assigned: baku)

References

Details

(Keywords: addon-compat, dev-doc-needed)

Attachments

(1 file)

In particular, if I take a Blob and make it iterable and try to create a File from it, the chrome-only ctor will get called (and throw) instead of calling the right constructor...

Maybe this is not an issue in practice much, but I would be a lot happier if we used chromeonly factory methods instead of the current chrome-ish constructor setup.
(In reply to Boris Zbarsky [:bz] (TPAC) from comment #0)
> Maybe this is not an issue in practice much, but I would be a lot happier if
> we used chromeonly factory methods instead of the current chrome-ish
> constructor setup.

This makes me think P3 but if it's more urgent please change the priority accordingly.
Flags: needinfo?(amarchesini)
Priority: -- → P3
Assignee: nobody → amarchesini
Flags: needinfo?(amarchesini)
Attached patch boom.patchSplinter Review
Attachment #8809759 - Flags: review?(kyle)
Attachment #8809759 - Flags: review?(kyle) → review+
Pushed by amarchesini@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/938f7fd2ce2b
Remove the chrome only constructor for File, r=qdot
https://hg.mozilla.org/mozilla-central/rev/938f7fd2ce2b
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Keywords: addon-compat
Congrats! Your changes - completed undocumented in FF 52 Release Notes - broke our add-on one more time. It took me several hours to figure out why our add-on is not working in FF 52 Beta anymore.

Other add-on authors might be affected too, so please be so kind and update Release Notes accordingly.
Wait, this bug has addon-compat marked.  Why did that not result in relevant notes for addon developers?
Flags: needinfo?(jorge)
Though note that general release notes likely wouldn't include something like this anyway except in the general "here's a list of all the changes" way; the "for developers" or addon-developer specific ones might.
It was included in the compat blog post: https://blog.mozilla.org/addons/2016/12/15/compatibility-for-firefox-52/

Not all developers follow it, though, and we didn't do automatic validation for this particular issue.
Flags: needinfo?(jorge)
Depends on: 1348663
Depends on: 1348691
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.