Closed
Bug 1348691
Opened 8 years ago
Closed 8 years ago
Box.com filelink uploads broken
Categories
(Thunderbird :: FileLink, defect)
Thunderbird
FileLink
Tracking
(thunderbird_esr52 fixed, thunderbird53 fixed, thunderbird54 fixed, thunderbird55 fixed)
RESOLVED
FIXED
Thunderbird 55.0
People
(Reporter: mkmelin, Assigned: mkmelin)
References
Details
(Keywords: regression)
Attachments
(1 file, 1 obsolete file)
|
1.59 KB,
patch
|
mkmelin
:
review+
jorgk-bmo
:
approval-comm-aurora+
jorgk-bmo
:
approval-comm-beta+
jorgk-bmo
:
approval-comm-esr52+
|
Details | Diff | Splinter Review |
Box.com filelink uploads broken.
TypeError: Not enough arguments to File.
(As you noted in bug 1348663).
Attachment #8848924 -
Flags: review?(jorgk)
|
||
Comment 1•8 years ago
|
||
Comment on attachment 8848924 [details] [diff] [review]
bugXXX_box-com-broken.patch
Review of attachment 8848924 [details] [diff] [review]:
-----------------------------------------------------------------
Looks good, I didn't test, did you?
::: mail/components/cloudfile/nsBox.js
@@ +784,1 @@
> .createInstance(Ci.nsIDOMFormData);
Nit: this should shift to spaces to the right, right?
Attachment #8848924 -
Flags: review?(jorgk) → review+
|
Assignee | |
Comment 2•8 years ago
|
||
Yes worked ok with the patch. I shifted the spaces two more to the right now (dunno if there's a style rule for this case).
Attachment #8848924 -
Attachment is obsolete: true
Attachment #8848925 -
Flags: review+
|
|
Assignee | |
Updated•8 years ago
|
Keywords: regression
|
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8848925 [details] [diff] [review]
bug1348691_box-com-broken.patch
[Approval Request Comment]
Regression caused by (bug #): bug 1303518
User impact if declined: Can't upload file to cloud storage.
Testing completed (on c-c, etc.): Manual.
Risk to taking this patch (and alternatives if risky):
Can't get worse ;-)
Attachment #8848925 -
Flags: approval-comm-esr52?
Attachment #8848925 -
Flags: approval-comm-beta+
Attachment #8848925 -
Flags: approval-comm-aurora+
|
|
||
Comment 4•8 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 55.0
|
|
||
Comment 5•8 years ago
|
||
C-A (TB 54): https://hg.mozilla.org/releases/comm-aurora/rev/6de7e3bb5102ae9756b2b1df056823f29c70c00e
C-B (TB 53): https://hg.mozilla.org/releases/comm-beta/rev/d0bd483dd2b5afe7a261d5e574d072e73e953d6b
status-thunderbird53:
--- → fixed
status-thunderbird54:
--- → fixed
status-thunderbird55:
--- → fixed
|
|
||
Updated•8 years ago
|
Attachment #8848925 -
Flags: approval-comm-esr52? → approval-comm-esr52+
|
|
||
Comment 6•8 years ago
|
||
status-thunderbird_esr52:
--- → fixed
|
|
||
Comment 7•8 years ago
|
||
Wrong uplift for TB 53 and TB 52. The async part .then() will only work from mozilla54 since
Bug 1338138 - Make call to createFromNsIFile() async (port bug 1335536 to mail). r=mkmelin
only landed on TB 54/mozilla54.
Same issue as in bug 1348663 comment #7.
Too late to fix TB 53 beta, but I'll fix TB 52 here and now.
TB 52 ESR:
https://hg.mozilla.org/releases/comm-esr52/rev/18a456796cf1c6ce4bb2f207a08cb66e40111222 (backout)
https://hg.mozilla.org/releases/comm-esr52/rev/b8034a160796746409a3a2a002243f3531e21198 (correct patch)
|
||
Comment 8•8 years ago
|
||
Thanks for fixing this in 52 ESR
You need to log in
before you can comment on or make changes to this bug.
Description
•