Closed Bug 1303525 Opened 3 years ago Closed 3 years ago

Ignore all of browser/branding/ for eslint (like we ignore all of browser/app)

Categories

(Firefox :: General, defect)

51 Branch
defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 52
Tracking Status
firefox51 --- affected
firefox52 --- fixed

People

(Reporter: Gijs, Assigned: standard8)

References

Details

Attachments

(1 file)

The only JS-like files there are the pref brandings, and those aren't really JS (pref files are 'special') and might have preprocessing instructions (I added some in bug 1289172 and initially got backed out for them...).

We should just be ignoring those files.
I agree we should just disable the pref files, I'm not convinced its a good idea to blanket those directories, as we could add something that does need it.

Although people should check to see if a rule needs enabling, I could see it easily being forgotten, so I'd fall on the side of caution.

I'm going to get a patch up for this, since it'll help the no-undef work.
Assignee: nobody → standard8
Blocks: 1311312
Attachment #8804322 - Flags: review?(jaws) → review?(gijskruitbosch+bugs)
Comment on attachment 8804322 [details]
Bug 1303525 - Ignore pref js files for eslint in browser/branding.

https://reviewboard.mozilla.org/r/88352/#review87602
Attachment #8804322 - Flags: review?(gijskruitbosch+bugs) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/82b5112c0bc3
Ignore pref js files for eslint in browser/branding. r=Gijs
https://hg.mozilla.org/mozilla-central/rev/82b5112c0bc3
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
You need to log in before you can comment on or make changes to this bug.