1303525 - Ignore all of browser/branding/ for eslint (like we ignore all of browser/app)

Status: RESOLVED FIXED

(Firefox :: General, defect)

Description

[:Gijs (he/him)]

The only JS-like files there are the pref brandings, and those aren't really JS (pref files are 'special') and might have preprocessing instructions (I added some in bug 1289172 and initially got backed out for them...).

We should just be ignoring those files.

Comment 1

[Mark Banner (:standard8)]

I agree we should just disable the pref files, I'm not convinced its a good idea to blanket those directories, as we could add something that does need it.

Although people should check to see if a rule needs enabling, I could see it easily being forgotten, so I'd fall on the side of caution.

I'm going to get a patch up for this, since it'll help the no-undef work.

Comment 2

[Mark Banner (:standard8)]

Attachment: Bug 1303525 - Ignore pref js files for eslint in browser/branding.

Review commit: https://reviewboard.mozilla.org/r/88352/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/88352/

Comment 3

[:Gijs (he/him)]

Comment on attachment 8804322 [details]
Bug 1303525 - Ignore pref js files for eslint in browser/branding.

https://reviewboard.mozilla.org/r/88352/#review87602

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/82b5112c0bc3
Ignore pref js files for eslint in browser/branding. r=Gijs

Comment 5

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/82b5112c0bc3