1303595 - Intermittent devtools/client/responsive.html/test/browser/browser_menu_item_01.js | uncaught exception - TypeError: tab is undefined at _getSwitcher/switcher.onLayersReady@chrome://browser/content/tabbrowser.xml:3770:46

Status: RESOLVED FIXED

(DevTools :: Responsive Design Mode, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: philringnalda [at] gmail.com

https://treeherder.mozilla.org/logviewer.html#?job_id=11630795&repo=fx-team

https://queue.taskcluster.net/v1/task/LSohsp5fTV-DhEDHpoy8zA/runs/0/artifacts/public%2Flogs%2Flive_backing.log

Comment 1

[Intermittent Failures Robot]

19 automation job failures were associated with this bug yesterday.

Repository breakdown:
* autoland: 11
* mozilla-inbound: 5
* try: 1
* mozilla-central: 1
* fx-team: 1

Platform breakdown:
* linux64: 18
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1303595&startday=2016-09-22&endday=2016-09-22&tree=all

Comment 2

[Intermittent Failures Robot]

68 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 32
* mozilla-inbound: 22
* fx-team: 7
* try: 4
* mozilla-aurora: 2
* mozilla-central: 1

Platform breakdown:
* linux64: 63
* linux32: 4
* windows8-64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1303595&startday=2016-09-19&endday=2016-09-25&tree=all

Comment 3

[Intermittent Failures Robot]

16 automation job failures were associated with this bug yesterday.

Repository breakdown:
* autoland: 9
* mozilla-inbound: 5
* mozilla-aurora: 1
* fx-team: 1

Platform breakdown:
* linux64: 15
* windows7-32-vm: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1303595&startday=2016-09-28&endday=2016-09-28&tree=all

Comment 4

[Intermittent Failures Robot]

15 automation job failures were associated with this bug yesterday.

Repository breakdown:
* autoland: 6
* mozilla-inbound: 4
* try: 2
* fx-team: 2
* mozilla-aurora: 1

Platform breakdown:
* linux64: 14
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1303595&startday=2016-09-29&endday=2016-09-29&tree=all

Comment 5

[Intermittent Failures Robot]

61 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* autoland: 31
* mozilla-inbound: 18
* try: 4
* mozilla-aurora: 4
* fx-team: 4

Platform breakdown:
* linux64: 59
* windows7-32-vm: 1
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1303595&startday=2016-09-26&endday=2016-10-02&tree=all

Comment 6

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

I can reproduce issues like this locally in production use of the tool.  I'll take a look.

Comment 7

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

STR to trigger infinite loop:

1. Open tab 1 with some content
2. Open new RDM for tab 1
3. Open a new tab 2
4. Switch back to tab 1 where new RDM is open

Obviously tab switching is a critical case to handle well!

Comment 8

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1303595 - Support preserveLayers in RDM tunnel.

Bug 1279086 removed setDocShellIsActiveAndForeground and added preserveLayers in
its place.  This updates the RDM tunnel to match.

Review commit: https://reviewboard.mozilla.org/r/83430/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/83430/

Comment 9

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1303595 - Update browser swap docs.

Review commit: https://reviewboard.mozilla.org/r/83432/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/83432/

Comment 10

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Attachment: Bug 1303595 - Add inner browser to browser -> tab map.

Assist tabbrowser.xml with processing some events such as MozLayerTreeReady
which bubble up from the remote content frame by adding the inner browser to the
WeakMap from browser to tab.

Most likely this should have been in place all along, but a change from bug
1279086 made it more apparent that it was missing because an error is now thrown
when no tab is found for a browser.

Review commit: https://reviewboard.mozilla.org/r/83434/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/83434/

Comment 11

[Alexandre Poirot [:ochameau]]

Comment on attachment 8797818 [details]
Bug 1303595 - Support preserveLayers in RDM tunnel.

https://reviewboard.mozilla.org/r/83430/#review82188

Do you think we can somehow test that all the overloaded things are actually useful?
But I also feel bad from preventing landing something in the platform or firefox because some RDM hacks is no longer relevant...

Comment 12

[Alexandre Poirot [:ochameau]]

Comment on attachment 8797819 [details]
Bug 1303595 - Update browser swap docs.

https://reviewboard.mozilla.org/r/83432/#review82190

Comment 13

[Alexandre Poirot [:ochameau]]

Comment on attachment 8797820 [details]
Bug 1303595 - Add inner browser to browser -> tab map.

https://reviewboard.mozilla.org/r/83434/#review82194

Comment 14

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

(In reply to Alexandre Poirot [:ochameau] from comment #11)
> Comment on attachment 8797818 [details]
> Bug 1303595 - Support preserveLayers in RDM tunnel.
> 
> https://reviewboard.mozilla.org/r/83430/#review82188
> 
> Do you think we can somehow test that all the overloaded things are actually
> useful?
> But I also feel bad from preventing landing something in the platform or
> firefox because some RDM hacks is no longer relevant...

That's tricky...  I'll keep thinking about the right balance of testing here.  At the moment, I agree with you that I'd prefer to keep RDM out of the way of Firefox and Platform changes, even if that means this code needs to play catch up to adjust for those changes.

Comment 15

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=f8ade9338bf99c5406bb37ac08d27a3add5d278f

Comment 16

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/239ce795d3d8
Support preserveLayers in RDM tunnel. r=ochameau
https://hg.mozilla.org/integration/autoland/rev/592de616971b
Update browser swap docs. r=ochameau
https://hg.mozilla.org/integration/autoland/rev/93a6f8a97410
Add inner browser to browser -> tab map. r=ochameau

Comment 17

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/239ce795d3d8
https://hg.mozilla.org/mozilla-central/rev/592de616971b
https://hg.mozilla.org/mozilla-central/rev/93a6f8a97410

Comment 18

[Ryan VanderMeulen [:RyanVM]]

Please request Aurora approval on this when you get a chance.

Comment 19

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8797818 [details]
Bug 1303595 - Support preserveLayers in RDM tunnel.

Approval Request Comment
[Feature/regressing bug #]: Updating new RDM to match browser changes from bug 1279086.
[User impact if declined]: If declined, new RDM will cause an infinite loop when switching tabs and pegs the CPU to 100%.  New RDM is disabled by default in Aurora, so the main impact there is to fix an intermittent test.
[Describe test coverage new/current, TreeHerder]: Landed on m-c, tested manually, fixes an automated test.
[Risks and why]: Low, feature is disabled by default in Aurora.
[String/UUID change made/needed]: None

Comment 20

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8797819 [details]
Bug 1303595 - Update browser swap docs.

See comment 19.

Comment 21

[J. Ryan Stinnett [:jryans] (Use needinfo, replies may be slow)]

Comment on attachment 8797820 [details]
Bug 1303595 - Add inner browser to browser -> tab map.

See comment 19.

Comment 22

[Gerry Chang [:gchang]]

Comment on attachment 8797818 [details]
Bug 1303595 - Support preserveLayers in RDM tunnel.

Now that the new RDM is disabled by default in Aurora, the risk should be low. We can take the fix in 51 aurora for the intermittent test error.

Comment 23

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/c23a22ac3765
https://hg.mozilla.org/releases/mozilla-aurora/rev/4e21028c661a
https://hg.mozilla.org/releases/mozilla-aurora/rev/a66ccdd53c4c

Comment 24

[Intermittent Failures Robot]

7 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-aurora: 5
* mozilla-inbound: 1
* autoland: 1

Platform breakdown:
* linux64: 7

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1303595&startday=2016-10-03&endday=2016-10-09&tree=all