1303802 - Beta web platform tests unexpectedly passing with /dom/historical.html | Node member must be nuked: rootNode - expected FAIL

Status: RESOLVED FIXED

(Testing :: web-platform-tests, defect)

Description

[Treeherder Bug Filer]

Filed by: wkocher [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=1607743&repo=mozilla-beta

https://archive.mozilla.org/pub/firefox/tinderbox-builds/mozilla-beta-linux-debug/1474292431/mozilla-beta_ubuntu32_vm-debug_test-web-platform-tests-2-bm07-tests1-linux32-build0.txt.gz

Comment 1

[Carsten Book [:Tomcat]]

james, something you can look into ?

Comment 2

[Carsten Book [:Tomcat]]

Attachment: bug1303802.patch

per irc

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Comment on attachment 8792818 [details] [diff] [review]
bug1303802.patch

Review of attachment 8792818 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks

Comment 4

[Carsten Book [:Tomcat]]

landed on beta: 

https://hg.mozilla.org/releases/mozilla-beta/rev/a7853dad14c9

thanks ms2ger!

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Needs to land on trunk/aurora still, unless I'm mistaken.

Comment 6

[Phil Ringnalda (:philor)]

How could it? It's an unexamined and probably spurious unexpected pass that only happens on RELEASE_BUILD, can't very well remove the expectation of failure on branches where it still does fail.

Comment 7

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

This is expected in the sense that it tests that we don't support the rootNode attribute; we currently do support it, but it is preffed off in release builds. There's no need to land anything on trunk.

Bug 1269155 is expected to fix this once and for all.

Comment 8

[Intermittent Failures Robot]

13 automation job failures were associated with this bug in the last 7 days.

Repository breakdown:
* mozilla-beta: 13

Platform breakdown:
* windows7-32-vm: 4
* windows8-64: 3
* windowsxp: 2
* osx-10-10: 2
* linux32: 2

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1303802&startday=2016-09-19&endday=2016-09-25&tree=all

Comment 9

[Phil Ringnalda (:philor)]

What verb tense are you using to call 51 and 52 unaffected, alternate-future-with-different-past? Bug 1269155 hasn't been meaningfully touched since last June, 51 merges to beta on November 7th, and when it does this test will again fail.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d2193462357a
Disable the part of historical.html which is permaorange on every merge to beta when we disable our rootNode implementation and let the test unexpectedly pass

Comment 11

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/7d18cbace7abdef39c2376c95ee999e8b94b8892

Comment 12

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/d2193462357a

Comment 13

[Aryeh Gregor (:ayg) (no longer with Mozilla)]

Can this be re-enabled now?

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/44edb197a893
reenable rootNode test chunk now that we don't have a rootNode implementation so the rootNode test which failed when we had one now passes when we don't have one

Comment 15

[Phil Ringnalda (:philor)]

Can't think why not.

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/44edb197a893