1303835 - The grey text in the location bar doesn't have enough contrast with dark theme

Status: NEW

(Firefox :: Theme, defect, P3)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Dark theme

See attached screenshot. The greytext (not the hostname) is barely visible due to the low contrast.

Comment 1

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Light theme

Comment 2

[:Gijs (he/him)]

Contrast on mac is 3.51:1 on the dark theme. To make it good enough, we'd need it to be 4.5:1. It's marginally better on the light and default theme (3.95:1), but that's still technically too low.

The code at https://searchfox.org/mozilla-central/rev/92d11a33250a8e368c8ca3e962e15ca67117f765/layout/generic/nsTextFrame.cpp#3978-3980 currently just uses text color with 0.5 alpha. Upping it to a higher alpha component would probably fix this issue.

Of course, that would de-prioritize the emphasis we currently put on the main part of the domain. I don't know what we could do about that. Perhaps Aaron can help.

Comment 3

[Jules Simplicio [:jules]]

Took a look at this with our latest dark theme colors. The location bar's background color is now #1C1B22. With the gray text being .5 alpha of the text color, this now passes WCAG AA (5.18:1) but not AAA. If we agree that is good enough, then we can close this.