130385 - Filter UI: Action dropdown shows no (blank) Priority default selection

Status: VERIFIED FIXED

(MailNews Core :: Filters, defect)

Description

[laurel]

Using mar12 commercial trunk

When switching the filter ui action dropdown to Priority there is no default
selection and the dropdown appears blank.  Available choices are shown and
selectable when pulling the list down and Normal is checked as default, but was
not initially shown in the dropdown when switching action to priority.

Regression... seems to have broken last week, mar6 trunk selects Highest as
default and is shown in dropdown as default selection on switching to action
Change Priority.

Note:  Normal is checked as the default where previously we had Highest as the
default.  I didn't see this specified in filters spec, so which is our lasting
decision?

1.  From mail window, Edit|Message Filters|New.
2.  Switch action dropdown from MoveToFolder to Change Priority.  Note the value
dropdown shows a blank selection. Pull down the list and choices are shown and
selectable, Normal checked as the default.

Comment 1

[Michael Buckland]

Discussed in Mail News bug meeting with Engineering, QA, Mktng and PjM. 
Decision was to minus this bug.

Comment 2

[(not reading, please use [e-mail] instead)]

taking, fix in hand.

Comment 3

[(not reading, please use [e-mail] instead)]

Attachment: fix

to make the default something else (like highest, normal seems like a weird
default) all we need to do is change const nsMsgPriorityValue Default = 4; in
MailNewsTypes2.idl

Comment 4

[(not reading, please use [e-mail] instead)]

Attachment: update.

Comment 5

[(not reading, please use [e-mail] instead)]

accepting.

Comment 6

[(not reading, please use [e-mail] instead)]

jglick, I think high or highest priority makes sense as a default.

why make the default normal, when most mail has normal priority?

(unless the common case is to create a filter to *normalize* priority, since 
it's set by sender, and not user)

Comment 7

[(not reading, please use [e-mail] instead)]

fixed.

if you want to change from normal to something else, let me know.

Comment 8

[laurel]

Using sep16 commercial trunk, we have a default selection, but the default is
"highest" on win98 and for linux and mac it's "normal".  Inconsistent -- what
was the final decision?

Comment 9

[jglick]

"highest" for all platforms.

Comment 10

[laurel]

 bug 174437 has been logged to change the default selection, making all
platforms consistent at Highest.

Marking this one verified as indeed the default isn't blank anymore, ok using
oct14 commercial trunk.