Priority levels in Filter search popup should be ordered Highest to Lowest

VERIFIED FIXED in Thunderbird 24.0

Status

MailNews Core
Filters
--
enhancement
VERIFIED FIXED
15 years ago
3 years ago

People

(Reporter: laurel, Assigned: sshagarwal)

Tracking

Trunk
Thunderbird 24.0

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

4.79 KB, patch
mconley
: review+
neil@parkwaycc.co.uk
: review+
bwinton
: ui-review+
aceman
: feedback+
InvisibleSmiley
: feedback+
Details | Diff | Splinter Review
(Reporter)

Description

15 years ago
carried over from bug 130385
Using oct14 commercial trunk, Mac OS 10.1, linux rh6.2

Mac and Linux both show a default selection of normal in the Filter UI's action
dropdown -- "Change the priority to".  

As stated in bug 130385, the default on all platforms should be Highest. Win98
does indeed already default so.

Steps:
1.  Open filter ui -- Tools|Message Filters, click New to get to rules dialog.
2.  Switch the filter action dropdown  (at bottom left of dialog)  to "Change
the priority to"

Result:  Mac & Linux have default selection of "Normal", whereas win98 does what
is intended and defaults to "Highest"
(Reporter)

Comment 1

15 years ago
*** Bug 174438 has been marked as a duplicate of this bug. ***
(Reporter)

Updated

15 years ago
QA Contact: olgam → laurel

Comment 2

15 years ago
I don't think this is a problem anymore.  On Linux, it goes highest, high,
normal, low, lowest, in that order.  With a check mark next to "normal".  All
you have to do is click on "highest" and you're done.  Highest is at the top, so
what's the problem?  I'm assuming that highest was not at the top some time in
the past...
Product: Browser → Seamonkey

Updated

12 years ago
Assignee: sspitzer → mail
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a2pre) Gecko/20070109 SeaMonkey/1.5a] (nightly) (W2Ksp4)

The list currently goes from Lowest "down" to Highest;
and "Lowest" is the default.

a) The order should be reversed, to be in sync with the list in the Compose window.

b) If possible, I agree the default selection should be Normal (or "None" ?).
OS: Linux → All
Assignee: mail → nobody
QA Contact: laurel → message-display
Hardware: PC → All
(In reply to comment #3)

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081011 Shredder/3.0b1pre] (nightly) (W2Ksp4)
[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9.1b2pre) Gecko/20081011 SeaMonkey/2.0a2pre] (nightly) (W2Ksp4)

> a) The order should be reversed, to be in sync with the list in the Compose
> window.

List now goes down from Highest to Lowest :-)

> b) If possible, I agree the default selection should be Normal (or "None" ?).

Highest is (still) the default. This part remains.
Severity: normal → enhancement
Component: MailNews: Message Display → Filters
Product: SeaMonkey → MailNews Core
QA Contact: message-display → filters
Summary: Default priority choice in Filter UI actions should be Highest → Default priority choice in Filter UI actions should be Normal
Whiteboard: [See comment 4]

Comment 5

4 years ago
In the filter search terms (in contrast to actions) the priority list is still Lowest to Highest so that can be fixed.

But Serge, why do you think Normal should be the default? I think the discussions were to make Highest the default. Also all other dropdowns have the first item as the default.

I propose to remove the "const nsMsgPriorityValue Default = 4;" in mailnews/base/public/MailNewsTypes2.idl as it is not used anywhere. Seems the functionality from https://bug130385.bugzilla.mozilla.org/attachment.cgi?id=99182 was removed, maybe in the filter editor redesign.
Whiteboard: [See comment 4] → [See comment 4][good first bug][lang=XUL/javascript][mentor=aceman]

Comment 6

4 years ago
So what I propose can be done by reordering tags at http://hg.mozilla.org/comm-central/file/16f11f7df3c5/mail/base/content/mailWidgets.xml#l1730 and also the /suite version of that file.
(Assignee)

Comment 7

4 years ago
Created attachment 748311 [details] [diff] [review]
Patch

Sir,

I have tried to make the changes as mentioned in the comments.
Attachment #748311 - Flags: ui-review?(bwinton)
Attachment #748311 - Flags: review?(mconley)
Attachment #748311 - Flags: feedback?(acelists)

Comment 8

4 years ago
Comment on attachment 748311 [details] [diff] [review]
Patch

We found that nsMsgPriority::Default is actually used so the patch does not contain its removal, in contrast to my comment earlier.

Other than that the patch does what I proposed. Tested on Thunderbird.
Attachment #748311 - Flags: feedback?(jh)
Attachment #748311 - Flags: feedback?(acelists)
Attachment #748311 - Flags: feedback+
Comment on attachment 748311 [details] [diff] [review]
Patch

I didn't actually test this (got caught by bug 869490) but it's certainly the right thing to align the order with the filter actions one.
Attachment #748311 - Flags: feedback?(jh) → feedback+
Comment on attachment 748311 [details] [diff] [review]
Patch

Looks good to me!  ui-r=bwinton  :)

Thanks,
Blake.
Attachment #748311 - Flags: ui-review?(bwinton) → ui-review+
(Assignee)

Updated

4 years ago
Assignee: nobody → syshagarwal

Comment 11

4 years ago
I'd really like to hear from Serge.
Status: NEW → ASSIGNED
Flags: needinfo?(sgautherie.bz)
The summary of this bug doesn't really reflect what it's become about. Updating for that.
Summary: Default priority choice in Filter UI actions should be Normal → Priority levels in Filter search popup should be ordered Highest to Lowest
Comment on attachment 748311 [details] [diff] [review]
Patch

Looks good to me. Thanks!
Attachment #748311 - Flags: review?(mconley) → review+

Comment 14

4 years ago
Does this need any other review for Seamonkey UI part?
Flags: needinfo?(neil)

Updated

4 years ago
Attachment #748311 - Flags: review+

Updated

4 years ago
Flags: needinfo?(neil)

Updated

4 years ago
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/b072cd0b99c6
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 24.0
(In reply to :aceman from comment #11)
> I'd really like to hear from Serge.

(Sorry for the very long delay.)


(In reply to :aceman from comment #5)
> But Serge, why do you think Normal should be the default? I think the
> discussions were to make Highest the default. Also all other dropdowns have
> the first item as the default.

Yes, comment 0 wanted "Highest" to be the default.
I thought that "(notSet / none / ) normal" might be more "neutral".
Yet, I won't argue further at this point.


[Mozilla/5.0 (Windows NT 6.0; rv:29.0) Gecko/20100101 Firefox/29.0 SeaMonkey/2.26]

V.Fixed. (I checked both "condition" and "action" dropdowns.)
Status: RESOLVED → VERIFIED
Flags: needinfo?(bugzillamozillaorg_serge_20140323)
Whiteboard: [See comment 4][good first bug][lang=XUL/javascript][mentor=aceman] → [See comment 4]
Whiteboard: [See comment 4]
You need to log in before you can comment on or make changes to this bug.