Change tab switching telemetry probes to be opt-out

RESOLVED FIXED in Firefox 49

Status

()

Firefox
Tabbed Browser
P1
normal
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Felipe, Assigned: Felipe)

Tracking

unspecified
Firefox 52
Points:
---

Firefox Tracking Flags

(firefox49 fixed, firefox50 fixed, firefox51 fixed, firefox52 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

a year ago
We want to keep a closer eye on the tab switching performance for users on the wild, and it will be good to have the related probes to be all opt-out so that we have better data on it.
Comment hidden (mozreview-request)
(Assignee)

Comment 2

a year ago
Comment on attachment 8792990 [details]
Bug 1304113 - Change tab switching telemetry probes to be opt-out.  data-r=bsmedberg

Benjamin for the data review
Attachment #8792990 - Flags: review?(benjamin)
Comment on attachment 8792990 [details]
Bug 1304113 - Change tab switching telemetry probes to be opt-out.  data-r=bsmedberg

https://reviewboard.mozilla.org/r/79802/#review78554

::: toolkit/components/telemetry/Histograms.json:4329
(Diff revision 1)
>      "high": 1000,
>      "n_buckets": 20,
>      "description": "Firefox: Time in ms spent updating UI in response to a tab switch"
>    },
>    "FX_TAB_SWITCH_TOTAL_MS": {
>      "expires_in_version": "default",

I seem to recall bsmedberg wanting the expires_in_version to be 56 for the spinner probes (see [his review comment here](https://bugzilla.mozilla.org/show_bug.cgi?id=1301435#c3)).

I suspect we'll want to do that here as well?
Attachment #8792990 - Flags: review?(mconley) → review+
Comment hidden (mozreview-request)
(Assignee)

Comment 5

a year ago
Comment on attachment 8792990 [details]
Bug 1304113 - Change tab switching telemetry probes to be opt-out.  data-r=bsmedberg

Updated the patch to make those probes expire in 56.

Although I think these measurements should exist forever because it's one of the best metrics we have to keep an eye on tab switching in the wild and spotting any major regression.

I'll let Benjamin choose which one to land :)
Attachment #8792990 - Flags: review?(benjamin)

Comment 6

a year ago
mozreview-review
Comment on attachment 8792990 [details]
Bug 1304113 - Change tab switching telemetry probes to be opt-out.  data-r=bsmedberg

https://reviewboard.mozilla.org/r/79802/#review78572

::: toolkit/components/telemetry/Histograms.json:4337
(Diff revision 2)
>      "n_buckets": 20,
> +    "releaseChannelCollection": "opt-out",
>      "description": "Firefox: Time in ms till a tab switch is complete including the first paint"
>    },
>    "FX_TAB_SWITCH_TOTAL_E10S_MS": {
> -    "expires_in_version": "default",
> +    "expires_in_version": "56",

I do think we should eventually make this permanent. But that involves having monitoring and dashboards and we don't have that yet. So let's do 56 for now, file a followup, and hopefully that will become easy with new aggregation/alerting systems we have planned for Q4.

data-review=me
Attachment #8792990 - Flags: review?(benjamin)

Comment 7

a year ago
mozreview-review
Comment on attachment 8792990 [details]
Bug 1304113 - Change tab switching telemetry probes to be opt-out.  data-r=bsmedberg

https://reviewboard.mozilla.org/r/79802/#review78574

hrmph mozreview
Attachment #8792990 - Flags: review+

Comment 8

a year ago
Pushed by felipc@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d619a8596986
Change tab switching telemetry probes to be opt-out. r=bsmedberg,mconley data-r=bsmedberg
(Assignee)

Comment 9

a year ago
Comment on attachment 8792990 [details]
Bug 1304113 - Change tab switching telemetry probes to be opt-out.  data-r=bsmedberg

Approval Request Comment
[Feature/regressing bug #]: tab switching telemetry probes to be used on release to analyze that related to bug 1301131
[User impact if declined]: It would be harder to understand the reports from some users about long tab switching times
[Describe test coverage new/current, TreeHerder]: Landed on inbound
[Risks and why]: small, just changes the probe configuration. data-review was done by bsmedberg
[String/UUID change made/needed]: none
Attachment #8792990 - Flags: approval-mozilla-release?
Attachment #8792990 - Flags: approval-mozilla-beta?
Attachment #8792990 - Flags: approval-mozilla-aurora?

Comment 10

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/d619a8596986
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52
Comment on attachment 8792990 [details]
Bug 1304113 - Change tab switching telemetry probes to be opt-out.  data-r=bsmedberg

Makes sense, Aurora51+, Beta50+
Attachment #8792990 - Flags: approval-mozilla-beta?
Attachment #8792990 - Flags: approval-mozilla-beta+
Attachment #8792990 - Flags: approval-mozilla-aurora?
Attachment #8792990 - Flags: approval-mozilla-aurora+

Updated

a year ago
status-firefox50: --- → affected
status-firefox51: --- → affected

Comment 12

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/e77a60c374ed
status-firefox51: affected → fixed

Comment 13

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/fe80efc4acef
status-firefox50: affected → fixed
Comment on attachment 8792990 [details]
Bug 1304113 - Change tab switching telemetry probes to be opt-out.  data-r=bsmedberg

Taking this as a ridealong for 49.0.2, to improve our telemetry info about tab switching delays. We are planning to push this the middle of next week.
Attachment #8792990 - Flags: approval-mozilla-release? → approval-mozilla-release+
status-firefox49: --- → affected

Comment 15

a year ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-release/rev/7339d82b4a5d
status-firefox49: affected → fixed
You need to log in before you can comment on or make changes to this bug.