1304113 - Change tab switching telemetry probes to be opt-out

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect, P1)

Description

[:Felipe Gomes (needinfo for replies!)]

We want to keep a closer eye on the tab switching performance for users on the wild, and it will be good to have the related probes to be all opt-out so that we have better data on it.

Comment 1

[:Felipe Gomes (needinfo for replies!)]

Attachment: Bug 1304113 - Change tab switching telemetry probes to be opt-out. data-r=bsmedberg

Review commit: https://reviewboard.mozilla.org/r/79802/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79802/

Comment 2

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8792990 [details]
Bug 1304113 - Change tab switching telemetry probes to be opt-out.  data-r=bsmedberg

Benjamin for the data review

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8792990 [details]
Bug 1304113 - Change tab switching telemetry probes to be opt-out.  data-r=bsmedberg

https://reviewboard.mozilla.org/r/79802/#review78554

::: toolkit/components/telemetry/Histograms.json:4329
(Diff revision 1)
>      "high": 1000,
>      "n_buckets": 20,
>      "description": "Firefox: Time in ms spent updating UI in response to a tab switch"
>    },
>    "FX_TAB_SWITCH_TOTAL_MS": {
>      "expires_in_version": "default",

I seem to recall bsmedberg wanting the expires_in_version to be 56 for the spinner probes (see [his review comment here](https://bugzilla.mozilla.org/show_bug.cgi?id=1301435#c3)).

I suspect we'll want to do that here as well?

Comment 4

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8792990 [details]
Bug 1304113 - Change tab switching telemetry probes to be opt-out.  data-r=bsmedberg

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/79802/diff/1-2/

Comment 5

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8792990 [details]
Bug 1304113 - Change tab switching telemetry probes to be opt-out.  data-r=bsmedberg

Updated the patch to make those probes expire in 56.

Although I think these measurements should exist forever because it's one of the best metrics we have to keep an eye on tab switching in the wild and spotting any major regression.

I'll let Benjamin choose which one to land :)

Comment 6

[Benjamin Smedberg]

Comment on attachment 8792990 [details]
Bug 1304113 - Change tab switching telemetry probes to be opt-out.  data-r=bsmedberg

https://reviewboard.mozilla.org/r/79802/#review78572

::: toolkit/components/telemetry/Histograms.json:4337
(Diff revision 2)
>      "n_buckets": 20,
> +    "releaseChannelCollection": "opt-out",
>      "description": "Firefox: Time in ms till a tab switch is complete including the first paint"
>    },
>    "FX_TAB_SWITCH_TOTAL_E10S_MS": {
> -    "expires_in_version": "default",
> +    "expires_in_version": "56",

I do think we should eventually make this permanent. But that involves having monitoring and dashboards and we don't have that yet. So let's do 56 for now, file a followup, and hopefully that will become easy with new aggregation/alerting systems we have planned for Q4.

data-review=me

Comment 7

[Benjamin Smedberg]

Comment on attachment 8792990 [details]
Bug 1304113 - Change tab switching telemetry probes to be opt-out.  data-r=bsmedberg

https://reviewboard.mozilla.org/r/79802/#review78574

hrmph mozreview

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d619a8596986
Change tab switching telemetry probes to be opt-out. r=bsmedberg,mconley data-r=bsmedberg

Comment 9

[:Felipe Gomes (needinfo for replies!)]

Comment on attachment 8792990 [details]
Bug 1304113 - Change tab switching telemetry probes to be opt-out.  data-r=bsmedberg

Approval Request Comment
[Feature/regressing bug #]: tab switching telemetry probes to be used on release to analyze that related to bug 1301131
[User impact if declined]: It would be harder to understand the reports from some users about long tab switching times
[Describe test coverage new/current, TreeHerder]: Landed on inbound
[Risks and why]: small, just changes the probe configuration. data-review was done by bsmedberg
[String/UUID change made/needed]: none

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/d619a8596986

Comment 11

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8792990 [details]
Bug 1304113 - Change tab switching telemetry probes to be opt-out.  data-r=bsmedberg

Makes sense, Aurora51+, Beta50+

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/e77a60c374ed

Comment 13

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/fe80efc4acef

Comment 14

[Liz Henry (:lizzard) (relman/hg->git project)]

Comment on attachment 8792990 [details]
Bug 1304113 - Change tab switching telemetry probes to be opt-out.  data-r=bsmedberg

Taking this as a ridealong for 49.0.2, to improve our telemetry info about tab switching delays. We are planning to push this the middle of next week.

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-release/rev/7339d82b4a5d