1304207 - [EME] Add telemetry tracking CDM usage

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Chris Pearce [:cpearce (Not reading bugmail)]]

I'd like some telemetry to track how often the Adobe and Widevine CDMs are used.

Comment 1

[Chris Pearce [:cpearce (Not reading bugmail)]]

Attachment: Bug 1304207 - Add telemetry to track when EME CDMs are instantiated.

Add opt-out telemetry probe to track which EME CDMs are being instantiated.
This will enable us to determine when it's safe to remove the Adobe CDM.

Review commit: https://reviewboard.mozilla.org/r/79880/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/79880/

Comment 2

[Gerald Squelart (he/him) (not at Mozilla since 2022-09-15)]

Comment on attachment 8793100 [details]
Bug 1304207 - Add telemetry to track when EME CDMs are instantiated.

https://reviewboard.mozilla.org/r/79880/#review78640

r+ with typo fixed:

::: toolkit/components/telemetry/Histograms.json:8594
(Diff revision 1)
> +    "alert_emails": ["[e-mail]"],
> +    "expires_in_version": "58",
> +    "bug_numbers": [1304207],
> +    "kind": "enumerated",
> +    "n_values": 6,
> +    "description": "MediaKeys CDM instanitated. 0=ClearKey, 1=Primetime, 2=Widevine, 3=unknown",

Typo: 'instanitated' -> 'instantiated'.

Comment 3

[François Marier [:francois]]

Comment on attachment 8793100 [details]
Bug 1304207 - Add telemetry to track when EME CDMs are instantiated.

https://reviewboard.mozilla.org/r/79880/#review78680

::: toolkit/components/telemetry/Histograms.json:8594
(Diff revision 1)
> +    "alert_emails": ["[e-mail]"],
> +    "expires_in_version": "58",
> +    "bug_numbers": [1304207],
> +    "kind": "enumerated",
> +    "n_values": 6,
> +    "description": "MediaKeys CDM instanitated. 0=ClearKey, 1=Primetime, 2=Widevine, 3=unknown",

In addition to fixing the typo that Gerald pointed out, I would suggest improving the description in two other ways:

- mention "EME" in the description
- clarify when the data is collected

For example, would this be accurate?

    Note the type of CDM (0=ClearKey...) every time we instantiate an EME video.

or maybe there's some caching and it's more like:

    Note the type of CDM (0=ClearKey...) every time we need to instantiate one to play an EME video.

Comment 4

[François Marier [:francois]]

FYI, I need to double-check something with Benjamin before approving this. I'm going to leave the r? as a reminder.

Comment 5

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8793100 [details]
Bug 1304207 - Add telemetry to track when EME CDMs are instantiated.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/79880/diff/1-2/

Comment 6

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8793100 [details]
Bug 1304207 - Add telemetry to track when EME CDMs are instantiated.

(re-requesting review manually, as reviewboard isn't smart enough to parse r=gerald,r?=francois)

Comment 7

[François Marier [:francois]]

Comment on attachment 8793100 [details]
Bug 1304207 - Add telemetry to track when EME CDMs are instantiated.

https://reviewboard.mozilla.org/r/79880/#review78794

datareview+

Comment 8

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8793100 [details]
Bug 1304207 - Add telemetry to track when EME CDMs are instantiated.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/79880/diff/2-3/

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2c9c2f19170d
Add telemetry to track when EME CDMs are instantiated. r=francois,gerald

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2c9c2f19170d

Comment 11

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8793100 [details]
Bug 1304207 - Add telemetry to track when EME CDMs are instantiated.

Approval Request Comment
[Feature/regressing bug #]: EME
[User impact if declined]: To help facilitate making a decision as to when we can remove Adobe EME from Firefox, we'd like to know how often the Adobe CDM is used for EME. This telemetry will help with that.
[Describe test coverage new/current, TreeHerder]: We have lots of EME tests.
[Risks and why]: Low; we're just adding telemetry.
[String/UUID change made/needed]: None.

Comment 12

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8793100 [details]
Bug 1304207 - Add telemetry to track when EME CDMs are instantiated.

New telemetry probe to understand EME CDM distribution, Aurora51+, Beta50+

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5de999a139fc

Comment 14

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/ec2921feb3b5

Comment 15

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out of beta for bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=1665730&repo=mozilla-beta 

https://hg.mozilla.org/releases/mozilla-beta/rev/865939f4946d

Comment 16

[Chris Pearce [:cpearce (Not reading bugmail)]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d1a2da10c74b