Closed Bug 1305552 Opened 3 years ago Closed 3 years ago

[EME] Add telemetry to track uses of MediaKeySession.generateRequest

Categories

(Core :: Audio/Video: Playback, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox50 --- fixed
firefox51 --- fixed
firefox52 --- fixed

People

(Reporter: cpearce, Assigned: cpearce)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

In bug 1304207 I added telemetry to track instantiations of EME CDMs. However, some sites (notably the Shaka Player Demo) instantiate CDMs but don't actually use the CDMs. So in order to determine via telemetry whether CDMs are being used, we actually need a new probe which tracks how often the CDMs are used to generate licenses.
Comment on attachment 8795095 [details]
Bug 1305552 - Add telemetry to track uses of MediaKeySession.generateRequest.

https://reviewboard.mozilla.org/r/81264/#review79872
Attachment #8795095 - Flags: review?(gsquelart) → review+
Comment on attachment 8795095 [details]
Bug 1305552 - Add telemetry to track uses of MediaKeySession.generateRequest.

https://reviewboard.mozilla.org/r/81264/#review80064

datareview+
Attachment #8795095 - Flags: review?(francois) → review+
Will need to uplift this too.
Flags: needinfo?(cpearce)
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3bbbac2f6775
Add telemetry to track uses of MediaKeySession.generateRequest. r=francois,gerald
Not just android, for the record, looks like all platforms.
https://hg.mozilla.org/integration/mozilla-inbound/rev/0ef0d8d926014e14bde37d3a65e53e57085c0b44
Bug 1305552 - Add telemetry to track uses of MediaKeySession.generateRequest. r=francois,gerald
https://hg.mozilla.org/mozilla-central/rev/0ef0d8d92601
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Comment on attachment 8795095 [details]
Bug 1305552 - Add telemetry to track uses of MediaKeySession.generateRequest.

Approval Request Comment
[Feature/regressing bug #]: EME
[User impact if declined]: To help facilitate making a decision as to when we can remove Adobe EME from Firefox, we'd like to know how often the Adobe CDM is used for EME. The previous telemetry I added in bug 1304207 wasn't precise enough to help with that. This telemetry is more accurate.
[Describe test coverage new/current, TreeHerder]: We have lots of EME tests.
[Risks and why]: Low; we're just adding telemetry.
[String/UUID change made/needed]: None.
Attachment #8795095 - Flags: approval-mozilla-beta?
Attachment #8795095 - Flags: approval-mozilla-aurora?
Hi Chris, does the data from this new probe looking good on Nightly52?
Comment on attachment 8795095 [details]
Bug 1305552 - Add telemetry to track uses of MediaKeySession.generateRequest.

New CDM usage telemetry probe, Aurora51+, Beta50+
Attachment #8795095 - Flags: approval-mozilla-beta?
Attachment #8795095 - Flags: approval-mozilla-beta+
Attachment #8795095 - Flags: approval-mozilla-aurora?
Attachment #8795095 - Flags: approval-mozilla-aurora+
This doesn't apply cleanly to beta, can we get a rebased patch?
(In reply to Ritu Kothari (:ritu) from comment #13)
> Hi Chris, does the data from this new probe looking good on Nightly52?

Yes, the data reported by the probe is matching my expectations.
Flags: needinfo?(cpearce)
You need to log in before you can comment on or make changes to this bug.