Closed Bug 1304522 Opened 8 years ago Closed 8 years ago

Fix the "when" argument to check_header

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(firefox52 fixed)

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: chmanchester, Assigned: chmanchester)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1304522 - Fix the "when" argument to check_header to actually make checks conditional.
58 bytes, text/x-review-board-request
glandium
: review+
Details
I saw a bug go by (can't find it now) that made it seem like conditionally checking headers is not working, I checked today on Windows and this is the case.
Assignee: nobody → cmanchester
Comment on attachment 8793521 [details] Bug 1304522 - Fix the "when" argument to check_header to actually make checks conditional. https://reviewboard.mozilla.org/r/80236/#review79888
Attachment #8793521 - Flags: review?(mh+mozilla) → review+
Pushed by cmanchester@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/e1e55d3898c8 Fix the "when" argument to check_header to actually make checks conditional. r=glandium
https://hg.mozilla.org/mozilla-central/rev/e1e55d3898c8
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox52: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: