Closed Bug 1304529 Opened 5 years ago Closed 5 years ago

remove preprocessing from mail/base/content/plugins.js

Categories

(Thunderbird :: General, enhancement)

enhancement
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird 52.0

People

(Reporter: aceman, Assigned: aceman)

References

Details

Attachments

(1 file)

Some #ifdef MOZ_CRASHREPORTER and #ifdef XP_MACOSX .
Attached patch patchSplinter Review
Attachment #8793527 - Flags: review?(mkmelin+mozilla)
Blocks: 1211005
Comment on attachment 8793527 [details] [diff] [review]
patch

Review of attachment 8793527 [details] [diff] [review]:
-----------------------------------------------------------------

r=mkmelin

::: mail/base/content/plugins.js
@@ +478,1 @@
>      let pluginDumpID = propertyBag.getPropertyAsAString("pluginDumpID");

please fix up the indention of the block here

@@ +521,5 @@
>      let doc = plugin.ownerDocument;
>      let overlay = this.getPluginUI(plugin, "main");
>      let statusDiv = this.getPluginUI(plugin, "submitStatus");
> +
> +    if (AppConstants.MOZ_CRASHREPORTER) {

and here

@@ +650,5 @@
>          accessKey: reloadKey,
>          popup: null,
>          callback: function() { browser.reload(); },
>        }];
> +      if (AppConstants.MOZ_CRASHREPORTER) {

and here
Attachment #8793527 - Flags: review?(mkmelin+mozilla) → review+
Thanks, done:
https://hg.mozilla.org/comm-central/rev/fcb58e25b5820f0399dea5a9d37dc2f95513fe43
Status: ASSIGNED → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 52.0
You need to log in before you can comment on or make changes to this bug.