1304680 - browser_downloads_panel_footer.js | Test timed out - after beta uplift simulation

Status: RESOLVED FIXED

(Firefox :: Downloads Panel, defect)

Description

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

If mozilla-central gets run as beta https://wiki.mozilla.org/Sheriffing/Uplift-Sim/Trunk-Beta , the following error will be found in the logs:

https://treeherder.mozilla.org/logviewer.html#?job_id=27844175&repo=try

16:51:22     INFO -  27 INFO TEST-UNEXPECTED-FAIL | browser/components/downloads/test/browser/browser_downloads_panel_footer.js | Test timed out -

browser.download.showPanelDropmarker is set to false is such an environment:
https://hg.mozilla.org/mozilla-central/rev/c4f6eb3d1fd8#l1.12

Setting it to true at the start of browser_downloads_panel_footer.js didn't fix it for me.

Comment 1

[Sean Lee [:seanlee][:weilonge]]

Hi Sebastian,

May I know how do you change "browser.download.showPanelDropmarker" in your environment? use about:config?
I wonder if mochitest doesn't share the same profile with the normal mode. So even the flag is changed in Firefox manually with about:config, it can be "false" in mochitest mode.

Thank you for reporting this issue.

Comment 2

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

This is what I tried: https://hg.mozilla.org/try/rev/8f7bef902d83a84c92b1230c50b6ef1327be72f3

Comment 3

[Sean Lee [:seanlee][:weilonge]]

Attachment: turn_on_dropmarker_in_mochitest

Please try this patch to turn the dropmarker on in mochitest. Thank you.

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Attachment: beta-simulation.patch

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Thank you for the patch, pushed it to Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e119759799f6

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Thank you, the patch attached fixes the issue, see the Try push results: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e119759799f6

Comment 7

[:Paolo Amadini]

Comment on attachment 8794094 [details] [diff] [review]
turn_on_dropmarker_in_mochitest

You should actually call pushPrefEnv inside the Task, so that the preference is reset for the following tests. Example:

https://dxr.mozilla.org/mozilla-central/rev/f0e6cc6360213ba21fd98c887b55fce5c680df68/browser/base/content/test/tabPrompts/browser_openPromptInBackgroundTab.js#18

Comment 8

[Sean Lee [:seanlee][:weilonge]]

Attachment: turn_on_dropmarker_in_mochitest_v2.diff

Use SpecialPowers.pushPrefEnv to turn on Dropmarker in Downloads Panel

Comment 9

[Sean Lee [:seanlee][:weilonge]]

Hi Sebastian,

Based on comment 7 and [1], I think pushPrefEnv is the correct solution for mochitest.
Could you help to verify the patch attachment 8797163 [details] [diff] [review] again?
Thank you!

[1] https://developer.mozilla.org/en-US/docs/Mozilla/Projects/Mochitest#What_if_I_need_to_change_a_preference_to_run_my_test.3F

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Hi, yes, the updated patch passes the tests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6cac99bfd48cda54618b1866e36c8ab3a16b439f

Comment 11

[Sean Lee [:seanlee][:weilonge]]

Attachment: Bug 1304680 - Turn on "browser.download.showPanelDropmarker" in Downloads Panel footer test.;

Review commit: https://reviewboard.mozilla.org/r/83270/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/83270/

Comment 12

[Sean Lee [:seanlee][:weilonge]]

Hi Paolo, Could you help to review the patch which has the changes with pushPrefEnv? Thank you.

Comment 13

[Sean Lee [:seanlee][:weilonge]]

Comment on attachment 8797598 [details]
Bug 1304680 - Turn on "browser.download.showPanelDropmarker" in Downloads Panel footer test.;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/83270/diff/1-2/

Comment 14

[:Paolo Amadini]

Comment on attachment 8797598 [details]
Bug 1304680 - Turn on "browser.download.showPanelDropmarker" in Downloads Panel footer test.;

https://reviewboard.mozilla.org/r/83270/#review81736

Thanks!

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86a18cc7342e
Turn on "browser.download.showPanelDropmarker" in Downloads Panel footer test.; r=Paolo

Comment 16

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/86a18cc7342e

Comment 17

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/12bb1ab66dac