Note: There are a few cases of duplicates in user autocompletion which are being worked on.

browser_downloads_panel_footer.js | Test timed out - after beta uplift simulation

RESOLVED FIXED in Firefox 51

Status

()

Firefox
Downloads Panel
RESOLVED FIXED
10 months ago
10 months ago

People

(Reporter: aryx, Assigned: seanlee)

Tracking

(Blocks: 1 bug)

Trunk
Firefox 52
Points:
---
Dependency tree / graph
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox49 unaffected, firefox50 unaffected, firefox51 fixed, firefox52 fixed, firefox-esr45 unaffected)

Details

(Whiteboard: [CHE-MVP])

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(4 attachments)

If mozilla-central gets run as beta https://wiki.mozilla.org/Sheriffing/Uplift-Sim/Trunk-Beta , the following error will be found in the logs:

https://treeherder.mozilla.org/logviewer.html#?job_id=27844175&repo=try

16:51:22     INFO -  27 INFO TEST-UNEXPECTED-FAIL | browser/components/downloads/test/browser/browser_downloads_panel_footer.js | Test timed out -

browser.download.showPanelDropmarker is set to false is such an environment:
https://hg.mozilla.org/mozilla-central/rev/c4f6eb3d1fd8#l1.12

Setting it to true at the start of browser_downloads_panel_footer.js didn't fix it for me.
(Assignee)

Comment 1

10 months ago
Hi Sebastian,

May I know how do you change "browser.download.showPanelDropmarker" in your environment? use about:config?
I wonder if mochitest doesn't share the same profile with the normal mode. So even the flag is changed in Firefox manually with about:config, it can be "false" in mochitest mode.

Thank you for reporting this issue.
Flags: needinfo?(aryx.bugmail)
This is what I tried: https://hg.mozilla.org/try/rev/8f7bef902d83a84c92b1230c50b6ef1327be72f3
Flags: needinfo?(aryx.bugmail)
(Assignee)

Comment 3

10 months ago
Created attachment 8794094 [details] [diff] [review]
turn_on_dropmarker_in_mochitest

Please try this patch to turn the dropmarker on in mochitest. Thank you.
Created attachment 8794097 [details] [diff] [review]
beta-simulation.patch
Thank you for the patch, pushed it to Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e119759799f6
Thank you, the patch attached fixes the issue, see the Try push results: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e119759799f6

Comment 7

10 months ago
Comment on attachment 8794094 [details] [diff] [review]
turn_on_dropmarker_in_mochitest

You should actually call pushPrefEnv inside the Task, so that the preference is reset for the following tests. Example:

https://dxr.mozilla.org/mozilla-central/rev/f0e6cc6360213ba21fd98c887b55fce5c680df68/browser/base/content/test/tabPrompts/browser_openPromptInBackgroundTab.js#18
status-firefox49: --- → unaffected
status-firefox50: --- → unaffected
status-firefox51: --- → affected
status-firefox-esr45: --- → unaffected
Blocks: 1307010
(Assignee)

Comment 8

10 months ago
Created attachment 8797163 [details] [diff] [review]
turn_on_dropmarker_in_mochitest_v2.diff

Use SpecialPowers.pushPrefEnv to turn on Dropmarker in Downloads Panel
(Assignee)

Comment 9

10 months ago
Hi Sebastian,

Based on comment 7 and [1], I think pushPrefEnv is the correct solution for mochitest.
Could you help to verify the patch attachment 8797163 [details] [diff] [review] again?
Thank you!

[1] https://developer.mozilla.org/en-US/docs/Mozilla/Projects/Mochitest#What_if_I_need_to_change_a_preference_to_run_my_test.3F
Flags: needinfo?(aryx.bugmail)
Hi, yes, the updated patch passes the tests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6cac99bfd48cda54618b1866e36c8ab3a16b439f
Flags: needinfo?(aryx.bugmail)
Comment hidden (mozreview-request)
(Assignee)

Comment 12

10 months ago
Hi Paolo, Could you help to review the patch which has the changes with pushPrefEnv? Thank you.
Comment hidden (mozreview-request)
(Assignee)

Updated

10 months ago
Assignee: nobody → selee

Comment 14

10 months ago
mozreview-review
Comment on attachment 8797598 [details]
Bug 1304680 - Turn on "browser.download.showPanelDropmarker" in Downloads Panel footer test.;

https://reviewboard.mozilla.org/r/83270/#review81736

Thanks!
Attachment #8797598 - Flags: review?(paolo.mozmail) → review+
(Assignee)

Updated

10 months ago
Status: NEW → ASSIGNED
Keywords: checkin-needed

Comment 15

10 months ago
Pushed by philringnalda@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/86a18cc7342e
Turn on "browser.download.showPanelDropmarker" in Downloads Panel footer test.; r=Paolo
Keywords: checkin-needed

Comment 16

10 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/86a18cc7342e
Status: ASSIGNED → RESOLVED
Last Resolved: 10 months ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 52

Updated

10 months ago
Whiteboard: [CHE-MVP]
(Assignee)

Updated

10 months ago
Blocks: 1269956
Whiteboard: [CHE-MVP] → [CHE-MVP][checkin-needed-aurora]

Comment 17

10 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-aurora/rev/12bb1ab66dac
status-firefox51: affected → fixed
Flags: in-testsuite+
Whiteboard: [CHE-MVP][checkin-needed-aurora] → [CHE-MVP]
You need to log in before you can comment on or make changes to this bug.