1304732 - Markup view container becomes scrollable if toolbox height < 250px

Status: VERIFIED FIXED

(DevTools :: Inspector, defect, P1)

Description

[Julian Descottes [:jdescottes]]

Attachment: markup_view_scrollable.gif

Probably linked to Bug 1304727, but different STRs and symptoms.
Regression from Bug 1262443.

STRs:
- open inspector, devtools docked to the bottom
- resize the toolbox to be lower than 250px

AR: Breadcrumbs are scrolled out and disappear, if you scroll with your mouse pointer on the inspector toolbar, you will be able to scroll the markup view container.
ER: Breadcrumbs should not disappear, only the markup view tree should ever be scrollable.

Comment 1

[Julian Descottes [:jdescottes]]

Attachment: Bug 1304732 - prevent scrollbars in markupview container when resizing toolbox;

Review commit: https://reviewboard.mozilla.org/r/80740/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/80740/

Comment 2

[Jan Honza Odvarko [:Honza] (always need-info? me)]

Comment on attachment 8794195 [details]
Bug 1304732 - prevent scrollbars in markupview container when resizing toolbox;

https://reviewboard.mozilla.org/r/80740/#review79404

Works for me, just one comment.

Honza

::: devtools/client/themes/inspector.css:201
(Diff revision 1)
>  }
>  
>  #markup-box {
>    width: 100%;
> -  flex: 1 1 auto;
> +  flex: 1;
> +  min-height: 1px;

Why not 0 as min-height?

Comment 3

[Julian Descottes [:jdescottes]]

Comment on attachment 8794195 [details]
Bug 1304732 - prevent scrollbars in markupview container when resizing toolbox;

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/80740/diff/1-2/

Comment 4

[Julian Descottes [:jdescottes]]

Comment on attachment 8794195 [details]
Bug 1304732 - prevent scrollbars in markupview container when resizing toolbox;

https://reviewboard.mozilla.org/r/80740/#review79404

> Why not 0 as min-height?

Was pretty sure a non-null min-height was needed, but looks like you are right. Thanks for catching this.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e26037d2a253
prevent scrollbars in markupview container when resizing toolbox;r=Honza

Comment 6

[Iris Hsiao [:ihsiao]]

https://hg.mozilla.org/mozilla-central/rev/e26037d2a253

Comment 7

[Cristian Comorasu, QA [:ccomorasu], Releae Desktop QA - Please contact [e-mail]]

I reproduced this bug using Fx 52.0a1, build ID:20160922030437, on Windows 10 x64.
I can confirm this issue is fixed, I verified using Fx 52.0a1 build ID:20160927030200, on Windows 10 x64, Ubuntu 14.04 LTS and Mac OS X 10.10.5.