130477 - Double-click on last file in filepicker window opens 2nd file past target file

Status: RESOLVED FIXED

(Core :: XUL, defect)

Description

[Peter B. West]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:0.9.9+) Gecko/20020311
BuildID:    2002031121

Double-clicking on the last file in a filepicker list has the following results:
1) the window scrolls down one against the file list.  The target file is
highlighted and becomes the 2nd-last file in the window.
2) the file following the now-last file in the window (i.e. 2nd file following
the target file) is actually selected by the double-click action.

Reproducible: Always
Steps to Reproduce:
1.When the default directory has 11 or more files, Ctrl-O
2.Double-click on the last visible file in the window
3.

Actual Results:  The 2nd file past the targeted file is selected

Expected Results:  The targeted file is selected

Double-click acts as though it is divided into three steps:
1. Single click selects last file and promotes its position in the filepicker window
2. Single click over last slot in the window selects the now-last file and
promotes its position in the window
3. Double click selects the now-last file in the window

Comment 1

[Boris Zbarsky [:bzbarsky]]

The problem is an outliner that shows only part of the last visible entry and
scrolls by a full entry up to bring it into view if that top half is clicked on.

Is there a way to disable this "scroll it into view" behavior?

Comment 2

[Jan Varga [:janv]]

One of problems here is that doubleclick is preceeded by mousedown and click
event. I'm not sure if it's a bug.
We call ensureRowIsVisible(index) in mousedown and click.
click would be sufficient I think.

Comment 3

[Peter B. West]

It's a bug.  Yes, I can click to select a file, then click Open.  But it is a
standard idiom to take a shortcut to that point by double-clicking, and it's a
standard idiom that mozilla supports, except that it gets the wrong file.

Comment 4

[Peter B. West]

This bug also afflicts the filepicker when selecting a file to attach. 
Double-clicking on the last file shown will attach a file not even visible in
the window at the time.  This has potentially disastrous consequences.

Comment 5

[John Morrison]

*** Bug 148017 has been marked as a duplicate of this bug. ***

Comment 6

[Jan Varga [:janv]]

-> me

Comment 7

[Jan Varga [:janv]]

Nominating for buffy.
This bug is annoying.

Comment 8

[Samir Gehani]

Nav triage team: nsbeta1+/adt3

Comment 9

[Boris Zbarsky [:bzbarsky]]

*** Bug 162636 has been marked as a duplicate of this bug. ***

Comment 10

[Jan Varga [:janv]]

*** Bug 184302 has been marked as a duplicate of this bug. ***

Comment 11

[Olli Pettay [:smaug][[e-mail]]]

Attachment: One suggestion to solve the problem

One my friend has complained about this bug so many times, that
I decided to make at least some kind of patch.

Comment 12

[Samir Gehani]

Nav triage team: nsbeta1-

Comment 13

[Olli Pettay [:smaug][[e-mail]]]

Reviews?
Varga?

The fix is simple and it is working fine.
And the severity of this bug is 'major'.

Comment 14

[Jan Varga [:janv]]

Comment on attachment 109456 [details] [diff] [review]
One suggestion to solve the problem

ok, I don't like this patch, since it doesn't solve original problem in
general.
It just disables particular feature in file picker.

Comment 15

[[e-mail]]

Hmmm... I tried the approach in bug 167682 (which is probably a dup, rather than
a blocker) but unfortunately clickcount="1" isn't terribly reliable :-/

Comment 16

[Jan Kozanek]

*** Bug 167682 has been marked as a duplicate of this bug. ***

Comment 17

[Boris Zbarsky [:bzbarsky]]

See bug 167682 comment 7

Comment 18

[[e-mail]]

Attachment: Only change the selection on the first of a double click

Comment 19

[Jan Varga [:janv]]

Comment on attachment 149268 [details] [diff] [review]
Only change the selection on the first of a double click

r=varga

Comment 20

[Alec Flett]

Comment on attachment 149268 [details] [diff] [review]
Only change the selection on the first of a double click

Add a comment on this last line:
+	  if (!col.value.cycler && obj.value != "twisty")
+	    v.toggleOpenState(row);

perhaps something like "don't toggle twisty's on double-click" ?

sr=alecf with some comment there

Comment 21

[[e-mail]]

Fix checked in.