1305671 - Bogus </a> after GitHub sign-in button

Status: RESOLVED FIXED

(bugzilla.mozilla.org :: Extensions, defect)

Description

[Wladimir Palant]

From extensions/GitHubAuth/template/en/default/hook/account/auth/login-small-additional_methods.html.tmpl:

>         <input type="image" src="extensions/GitHubAuth/web/images/sign_in.png" height="22" width="75" align="absmiddle"
>             alt="Sign in with GitHub"
>             title="Sign in with GitHub"></a> or 

The closing </a> tag is bogus here - there is no link to be closed. This code can be seen on https://bugzilla.mozilla.org/ when you are not logged in for example.

The HTML code in extensions/GitHubAuth/template/en/default/hook/account/auth/login-additional_methods.html.tmpl is also invalid by the way:

>  <p>
>    <form method="post" action="[% urlbase FILTER html %]github.cgi">
>    ...
>    </form>
>  </p>

<form> is a block level element and cannot be placed inside a paragraph. So the browser auto-closes the opening <p>, leaving the closing </p> dangling. This code can be seen on https://bugzilla.mozilla.org/enter_bug.cgi when not logged in.

Comment 1

[David Lawrence [:dkl]]

To https://github.com/mozilla-bteam/bmo.git
   4ac7c1e..381c4dd  master -> master