Closed
Bug 1306137
Opened 6 years ago
Closed 6 years ago
Remove MOZ_B2G_CAMERA and dom/camera/
Categories
(Core :: DOM: Device Interfaces, defect)
Core
DOM: Device Interfaces
Tracking
()
RESOLVED
FIXED
mozilla52
Tracking | Status | |
---|---|---|
firefox52 | --- | fixed |
People
(Reporter: aryx, Assigned: aryx)
References
(Blocks 1 open bug)
Details
Attachments
(2 files)
According to https://groups.google.com/forum/#!topic/mozilla.dev.fxos/FoAwifahNPY , B2G code should be removed from mozilla-central. This bug removes MOZ_B2G_CAMERA and files which get obsoleted by that.
Comment hidden (mozreview-request) |
![]() |
Assignee | |
Comment 2•6 years ago
|
||
Successful Try push: https://treeherder.mozilla.org/#/jobs?repo=try&revision=64bd888b8eca&selectedJob=28176877
Comment 3•6 years ago
|
||
Comment on attachment 8795918 [details] Bug 1306137 - remove b2g camera code: Remove MOZ_B2G_CAMERA. Handing off to Andrew who is more familiar with the backend Camera code.
Attachment #8795918 -
Flags: review?(jdarcangelo) → review?(aosmond)
Comment 4•6 years ago
|
||
mozreview-review |
Comment on attachment 8795918 [details] Bug 1306137 - remove b2g camera code: Remove MOZ_B2G_CAMERA. https://reviewboard.mozilla.org/r/81876/#review80612
Comment 5•6 years ago
|
||
(In reply to Sebastian Hengst [:aryx][:archaeopteryx] from comment #0) > According to > https://groups.google.com/forum/#!topic/mozilla.dev.fxos/FoAwifahNPY , B2G > code should be removed from mozilla-central. > > This bug removes MOZ_B2G_CAMERA and files which get obsoleted by that. I believe as a follow up / part 2, the entire dom/camera tree should be removed, along with dom/webidl/Camera*.webidl, along with any code that breaks due to that :). Nothing uses it outside of B2G and it has no real functionality.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
![]() |
Assignee | |
Comment 8•6 years ago
|
||
Successful Try runs: https://treeherder.mozilla.org/#/jobs?repo=try&revision=3a0a76ba746cf2612878d488e93322e745ad6d1d https://treeherder.mozilla.org/#/jobs?repo=try&revision=6f53f1855e06c888aadc0a20a9be2d5de779d70f
![]() |
Assignee | |
Updated•6 years ago
|
Summary: Remove MOZ_B2G_CAMERA → Remove MOZ_B2G_CAMERA and dom/camera/
Comment 10•6 years ago
|
||
mozreview-review |
Comment on attachment 8795918 [details] Bug 1306137 - remove b2g camera code: Remove MOZ_B2G_CAMERA. https://reviewboard.mozilla.org/r/81878/#review82222
Attachment #8795918 -
Flags: review?(aosmond) → review+
Comment 11•6 years ago
|
||
mozreview-review |
Comment on attachment 8797999 [details] Bug 1306137 - remove b2g camera code: Remove dom/camera/ and code which depends on it. https://reviewboard.mozilla.org/r/83600/#review82224 This will require a DOM peer to review to remove the webidl bits.
Attachment #8797999 -
Flags: review?(aosmond) → review+
![]() |
Assignee | |
Updated•6 years ago
|
Attachment #8797999 -
Flags: review?(bkelly)
Comment 12•6 years ago
|
||
mozreview-review |
Comment on attachment 8797999 [details] Bug 1306137 - remove b2g camera code: Remove dom/camera/ and code which depends on it. https://reviewboard.mozilla.org/r/83600/#review83264 I only looked at the webidl file removal. Thanks.
Attachment #8797999 -
Flags: review?(bkelly) → review+
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 15•6 years ago
|
||
Pushed by archaeopteryx@coole-files.de: https://hg.mozilla.org/integration/autoland/rev/d3e988b1b480 remove b2g camera code: Remove MOZ_B2G_CAMERA. r=aosmond https://hg.mozilla.org/integration/autoland/rev/09943651fa85 remove b2g camera code: Remove dom/camera/ and code which depends on it. r=aosmond,bkelly
Comment 16•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d3e988b1b480 https://hg.mozilla.org/mozilla-central/rev/09943651fa85
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Comment 17•6 years ago
|
||
Small size win for Android apk on this: == Change summary for alert #3701 (as of October 14 2016 10:59 UTC) == Improvements: 0% installer size summary android-4-0-armv7-api15 opt 39525147.67 -> 39395339.75 For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=3701
You need to log in
before you can comment on or make changes to this bug.
Description
•