Closed Bug 1306137 Opened 4 years ago Closed 4 years ago

Remove MOZ_B2G_CAMERA and dom/camera/

Categories

(Core :: DOM: Device Interfaces, defect)

Product:
Core
Component:
DOM: Device Interfaces
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla52
Tracking Flags:
Tracking Status
firefox52 --- fixed

People

(Reporter: aryx, Assigned: aryx)

References

(Blocks 1 open bug)

Details

Attachments

(2 files)

Bug 1306137 - remove b2g camera code: Remove MOZ_B2G_CAMERA.
58 bytes, text/x-review-board-request
aosmond
: review+
Details
Bug 1306137 - remove b2g camera code: Remove dom/camera/ and code which depends on it.
58 bytes, text/x-review-board-request
aosmond
: review+
Details 
According to https://groups.google.com/forum/#!topic/mozilla.dev.fxos/FoAwifahNPY , B2G code should be removed from mozilla-central.

This bug removes MOZ_B2G_CAMERA and files which get obsoleted by that.
Comment on attachment 8795918 [details]
Bug 1306137 - remove b2g camera code: Remove MOZ_B2G_CAMERA.

Handing off to Andrew who is more familiar with the backend Camera code.
Attachment #8795918 - Flags: review?(jdarcangelo) → review?(aosmond)
Comment on attachment 8795918 [details]
Bug 1306137 - remove b2g camera code: Remove MOZ_B2G_CAMERA.

https://reviewboard.mozilla.org/r/81876/#review80612
(In reply to Sebastian Hengst [:aryx][:archaeopteryx] from comment #0)
> According to
> https://groups.google.com/forum/#!topic/mozilla.dev.fxos/FoAwifahNPY , B2G
> code should be removed from mozilla-central.
> 
> This bug removes MOZ_B2G_CAMERA and files which get obsoleted by that.

I believe as a follow up / part 2, the entire dom/camera tree should be removed, along with dom/webidl/Camera*.webidl, along with any code that breaks due to that :). Nothing uses it outside of B2G and it has no real functionality.
Summary: Remove MOZ_B2G_CAMERA → Remove MOZ_B2G_CAMERA and dom/camera/
Comment on attachment 8795918 [details]
Bug 1306137 - remove b2g camera code: Remove MOZ_B2G_CAMERA.

https://reviewboard.mozilla.org/r/81878/#review82222
Attachment #8795918 - Flags: review?(aosmond) → review+
Comment on attachment 8797999 [details]
Bug 1306137 - remove b2g camera code: Remove dom/camera/ and code which depends on it.

https://reviewboard.mozilla.org/r/83600/#review82224

This will require a DOM peer to review to remove the webidl bits.
Attachment #8797999 - Flags: review?(aosmond) → review+
Comment on attachment 8797999 [details]
Bug 1306137 - remove b2g camera code: Remove dom/camera/ and code which depends on it.

https://reviewboard.mozilla.org/r/83600/#review83264

I only looked at the webidl file removal.  Thanks.
Attachment #8797999 - Flags: review?(bkelly) → review+
Pushed by archaeopteryx@coole-files.de:
https://hg.mozilla.org/integration/autoland/rev/d3e988b1b480
remove b2g camera code: Remove MOZ_B2G_CAMERA. r=aosmond
https://hg.mozilla.org/integration/autoland/rev/09943651fa85
remove b2g camera code: Remove dom/camera/ and code which depends on it. r=aosmond,bkelly
https://hg.mozilla.org/mozilla-central/rev/d3e988b1b480
https://hg.mozilla.org/mozilla-central/rev/09943651fa85
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
status-firefox52: affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Small size win for Android apk on this:

== Change summary for alert #3701 (as of October 14 2016 10:59 UTC) ==

Improvements:

  0%  installer size summary android-4-0-armv7-api15 opt     39525147.67 -> 39395339.75

For up to date results, see: https://treeherder.mozilla.org/perf.html#/alerts?id=3701
No longer blocks: 1369194
You need to log in before you can comment on or make changes to this bug.