1306174 - ES3.0 compressed textures are now an extension to WebGL 2

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, defect, P1)

Comment 1

[Kelsey Gilbert [:jgilbert] (returns Nov01)]

Attachment: Bug 1306174 - Remove ETC support from core WebGL2. -

Review commit: https://reviewboard.mozilla.org/r/81944/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/81944/

Comment 2

[Ethan Lin[:ethlin]]

Comment on attachment 8795965 [details]
Bug 1306174 - Remove ETC support from core WebGL2. -

https://reviewboard.mozilla.org/r/81944/#review80646

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/182bf7777a51
Remove ETC support from core WebGL2. - r=ethlin
https://hg.mozilla.org/integration/mozilla-inbound/rev/a6c046d149d0
Update tests.

Comment 4

[Kelsey Gilbert [:jgilbert] (returns Nov01)]

Comment on attachment 8795965 [details]
Bug 1306174 - Remove ETC support from core WebGL2. -

Approval Request Comment
[Feature/regressing bug #]: webgl2
[User impact if declined]: -
[Describe test coverage new/current, TreeHerder]: tests included
[Risks and why]: very low
[String/UUID change made/needed]: none

Comment 5

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Hi Milan, Jeff, as you may know Beta50 crash rates are slightly worse than Beta49. I know WebGL2 is now targeted for Fx51 and not 50. Do we still want to uplift this to Beta or just Aurora? I would prefer Aurora only.

Comment 6

[Milan Sreckovic [:milan] (needinfo for best results)]

For the most part, the split between 50 and 51 for WebGL2 is "old features" and "new features", with the new features those that were only introduced into the spec a few weeks ago.  We are trying not to have broken things in 50, but rather just the missing things in 51.  If that makes any sense :)  This particular one should help with the 50 crashes (though I don't know that we're seeing these in numbers.)

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/182bf7777a51
https://hg.mozilla.org/mozilla-central/rev/a6c046d149d0

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8795965 [details]
Bug 1306174 - Remove ETC support from core WebGL2. -

Thanks Milan! This may be the last of the WebGL2 fixes that I will take for Beta50 cycle.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-aurora/rev/5a3299a08cb7
https://hg.mozilla.org/releases/mozilla-aurora/rev/5da0f51ab6de

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/releases/mozilla-beta/rev/63c697ca56e5
https://hg.mozilla.org/releases/mozilla-beta/rev/0b924dbd174b

Comment 11

[Florian Scholz (Open Web Docs)]

Noted on: 
https://developer.mozilla.org/en-US/docs/Web/API/WEBGL_compressed_texture_etc
https://developer.mozilla.org/en-US/Firefox/Releases/51#WebGL

Updated:
https://developer.mozilla.org/en-US/docs/Web/API/WebGLRenderingContext/compressedTexImage2D
https://developer.mozilla.org/en-US/docs/Web/API/WebGLRenderingContext/compressedTexSubImage2D
https://developer.mozilla.org/en-US/docs/Web/API/WebGL_API/Constants