Closed
Bug 1306174
Opened 8 years ago
Closed 8 years ago
ES3.0 compressed textures are now an extension to WebGL 2
Categories
(Core :: Graphics: CanvasWebGL, defect, P1)
Core
Graphics: CanvasWebGL
Tracking
()
RESOLVED
FIXED
mozilla52
People
(Reporter: jgilbert, Assigned: jgilbert)
References
Details
(Keywords: dev-doc-complete, Whiteboard: gfx-noted)
Attachments
(1 file)
58 bytes,
text/x-review-board-request
|
ethlin
:
review+
ritu
:
approval-mozilla-aurora+
ritu
:
approval-mozilla-beta+
|
Details |
No description provided.
Comment hidden (mozreview-request) |
Comment 2•8 years ago
|
||
mozreview-review |
Comment on attachment 8795965 [details]
Bug 1306174 - Remove ETC support from core WebGL2. -
https://reviewboard.mozilla.org/r/81944/#review80646
Attachment #8795965 -
Flags: review?(ethlin) → review+
Updated•8 years ago
|
Keywords: dev-doc-needed
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/182bf7777a51
Remove ETC support from core WebGL2. - r=ethlin
https://hg.mozilla.org/integration/mozilla-inbound/rev/a6c046d149d0
Update tests.
Assignee | ||
Updated•8 years ago
|
Assignee | ||
Comment 4•8 years ago
|
||
Comment on attachment 8795965 [details]
Bug 1306174 - Remove ETC support from core WebGL2. -
Approval Request Comment
[Feature/regressing bug #]: webgl2
[User impact if declined]: -
[Describe test coverage new/current, TreeHerder]: tests included
[Risks and why]: very low
[String/UUID change made/needed]: none
Attachment #8795965 -
Flags: approval-mozilla-beta?
Attachment #8795965 -
Flags: approval-mozilla-aurora?
Hi Milan, Jeff, as you may know Beta50 crash rates are slightly worse than Beta49. I know WebGL2 is now targeted for Fx51 and not 50. Do we still want to uplift this to Beta or just Aurora? I would prefer Aurora only.
Flags: needinfo?(milan)
Flags: needinfo?(jgilbert)
For the most part, the split between 50 and 51 for WebGL2 is "old features" and "new features", with the new features those that were only introduced into the spec a few weeks ago. We are trying not to have broken things in 50, but rather just the missing things in 51. If that makes any sense :) This particular one should help with the 50 crashes (though I don't know that we're seeing these in numbers.)
Flags: needinfo?(milan)
Comment 7•8 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/182bf7777a51
https://hg.mozilla.org/mozilla-central/rev/a6c046d149d0
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Comment on attachment 8795965 [details]
Bug 1306174 - Remove ETC support from core WebGL2. -
Thanks Milan! This may be the last of the WebGL2 fixes that I will take for Beta50 cycle.
Attachment #8795965 -
Flags: approval-mozilla-beta?
Attachment #8795965 -
Flags: approval-mozilla-beta+
Attachment #8795965 -
Flags: approval-mozilla-aurora?
Attachment #8795965 -
Flags: approval-mozilla-aurora+
Comment 9•8 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-aurora/rev/5a3299a08cb7
https://hg.mozilla.org/releases/mozilla-aurora/rev/5da0f51ab6de
Flags: in-testsuite+
Comment 10•8 years ago
|
||
bugherder uplift |
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(jgilbert)
Comment 11•8 years ago
|
||
Noted on:
https://developer.mozilla.org/en-US/docs/Web/API/WEBGL_compressed_texture_etc
https://developer.mozilla.org/en-US/Firefox/Releases/51#WebGL
Updated:
https://developer.mozilla.org/en-US/docs/Web/API/WebGLRenderingContext/compressedTexImage2D
https://developer.mozilla.org/en-US/docs/Web/API/WebGLRenderingContext/compressedTexSubImage2D
https://developer.mozilla.org/en-US/docs/Web/API/WebGL_API/Constants
Keywords: dev-doc-needed → dev-doc-complete
You need to log in
before you can comment on or make changes to this bug.
Description
•