Closed Bug 1306174 Opened 3 years ago Closed 3 years ago

ES3.0 compressed textures are now an extension to WebGL 2

Categories

(Core :: Canvas: WebGL, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla52
Tracking Status
firefox50 --- fixed
firefox51 --- fixed
firefox52 --- fixed

People

(Reporter: jgilbert, Assigned: jgilbert)

References

Details

(Keywords: dev-doc-complete, Whiteboard: gfx-noted)

Attachments

(1 file)

No description provided.
Comment on attachment 8795965 [details]
Bug 1306174 - Remove ETC support from core WebGL2. -

https://reviewboard.mozilla.org/r/81944/#review80646
Attachment #8795965 - Flags: review?(ethlin) → review+
Blocks: 1306454
Blocks: 1306480
No longer blocks: 1306454
Blocks: 1305035
Comment on attachment 8795965 [details]
Bug 1306174 - Remove ETC support from core WebGL2. -

Approval Request Comment
[Feature/regressing bug #]: webgl2
[User impact if declined]: -
[Describe test coverage new/current, TreeHerder]: tests included
[Risks and why]: very low
[String/UUID change made/needed]: none
Attachment #8795965 - Flags: approval-mozilla-beta?
Attachment #8795965 - Flags: approval-mozilla-aurora?
Hi Milan, Jeff, as you may know Beta50 crash rates are slightly worse than Beta49. I know WebGL2 is now targeted for Fx51 and not 50. Do we still want to uplift this to Beta or just Aurora? I would prefer Aurora only.
Flags: needinfo?(milan)
Flags: needinfo?(jgilbert)
For the most part, the split between 50 and 51 for WebGL2 is "old features" and "new features", with the new features those that were only introduced into the spec a few weeks ago.  We are trying not to have broken things in 50, but rather just the missing things in 51.  If that makes any sense :)  This particular one should help with the 50 crashes (though I don't know that we're seeing these in numbers.)
Flags: needinfo?(milan)
https://hg.mozilla.org/mozilla-central/rev/182bf7777a51
https://hg.mozilla.org/mozilla-central/rev/a6c046d149d0
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla52
Comment on attachment 8795965 [details]
Bug 1306174 - Remove ETC support from core WebGL2. -

Thanks Milan! This may be the last of the WebGL2 fixes that I will take for Beta50 cycle.
Attachment #8795965 - Flags: approval-mozilla-beta?
Attachment #8795965 - Flags: approval-mozilla-beta+
Attachment #8795965 - Flags: approval-mozilla-aurora?
Attachment #8795965 - Flags: approval-mozilla-aurora+
Flags: needinfo?(jgilbert)
Blocks: 1316778
You need to log in before you can comment on or make changes to this bug.