1306181 - Remove IDBEnvironment in favor of partial interface in WindowOrWorkerGlobalScope

Status: RESOLVED FIXED

(Core :: Storage: IndexedDB, defect, P3)

Description

[Bevis Tseng[:bevis][:btseng](Exited)]

This is a followup bug to address the webidl change of removing IDBEnvrionment in favor of: 
partial interface WindowOrWorkerGlobalScope {
   readonly attribute IDBFactory indexedDB;
};
according to https://github.com/w3c/IndexedDB/pull/95

However, there is no WindowOrWorkerGlobalScope interface defined in gecko yet which is specified in 
https://html.spec.whatwg.org/multipage/webappapis.html#windoworworkerglobalscope-mixin

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Boris just landed WindowOrWorkerGlobalScope in bug 1269052.

Comment 2

[Bevis Tseng[:bevis][:btseng](Exited)]

Cool!
Thanks for updating this. I'll follow up this bug.

Comment 3

[Bevis Tseng[:bevis][:btseng](Exited)]

Attachment: (v1) Patch: Remove IDBEnvironment in favor of partial interface in WindowOrWorkerGlobalScope.

Update Webidl for IndexedDB according to the change in https://github.com/w3c/IndexedDB/pull/95 after WindowOrWorkerGlobalScope was introduced in bug 1269052.

Note: 
1. The [Exposed] attribute in WPT test is required as explained in 1312330.
2. Treeherder result for reference:
   https://treeherder.mozilla.org/#/jobs?repo=try&revision=f0808d6f2979

Comment 4

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8804542 [details] [diff] [review]
(v1) Patch: Remove IDBEnvironment in favor of partial interface in WindowOrWorkerGlobalScope.

Review of attachment 8804542 [details] [diff] [review]:
-----------------------------------------------------------------

::: dom/webidl/WindowOrWorkerGlobalScope.webidl
@@ +56,5 @@
> +// http://w3c.github.io/IndexedDB/#factory-interface
> +partial interface WindowOrWorkerGlobalScope {
> +   // readonly attribute IDBFactory indexedDB;
> +   [Throws]
> +   readonly attribute IDBFactory? indexedDB;

Why do we have the nullable "?" IDBFactory here?  Is it to enable some gecko specific mode like disabled 3rd party cookies or something?

Comment 5

[Ben Kelly [:bkelly, not reviewing]]

NI for question in comment 4.

Comment 6

[Bevis Tseng[:bevis][:btseng](Exited)]

(In reply to Ben Kelly [:bkelly] from comment #4)
> Comment on attachment 8804542 [details] [diff] [review]
> (v1) Patch: Remove IDBEnvironment in favor of partial interface in
> WindowOrWorkerGlobalScope.
> 
> Review of attachment 8804542 [details] [diff] [review]:
> -----------------------------------------------------------------
> 
> ::: dom/webidl/WindowOrWorkerGlobalScope.webidl
> @@ +56,5 @@
> > +// http://w3c.github.io/IndexedDB/#factory-interface
> > +partial interface WindowOrWorkerGlobalScope {
> > +   // readonly attribute IDBFactory indexedDB;
> > +   [Throws]
> > +   readonly attribute IDBFactory? indexedDB;
> 
> Why do we have the nullable "?" IDBFactory here?  Is it to enable some gecko
> specific mode like disabled 3rd party cookies or something?

Yes, the null will be returned in the following case:
http://searchfox.org/mozilla-central/rev/4012e61cc38758ffa1f7ce26039173f67b048853/dom/indexedDB/IDBFactory.cpp#290-296
So I moved the modification done in IDBEnvironment to this partial interface.
Sorry for not mentioning this when asking for the review. :|

Comment 7

[Ben Kelly [:bkelly, not reviewing]]

Comment on attachment 8804542 [details] [diff] [review]
(v1) Patch: Remove IDBEnvironment in favor of partial interface in WindowOrWorkerGlobalScope.

Review of attachment 8804542 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks!

Comment 8

[Bevis Tseng[:bevis][:btseng](Exited)]

treeherder result looks fine:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=41424161e5a0

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/67fbbeb0677b
Remove IDBEnvironment in favor of partial interface in WindowOrWorkerGlobalScope. r=bkelly

Comment 10

[Phil Ringnalda (:philor)]

https://hg.mozilla.org/mozilla-central/rev/67fbbeb0677b