1306276 - Deprecate History RemovePage and RemovePages

Status: RESOLVED FIXED

(Toolkit :: Places, defect, P2)

Description

[Marco Bonardo [:mak]]

We have replacements in History.jsm::remove.

The scope here is to add a @deprecated javadoc in nsIBrowserHistory.idl with a comment like "Please use PlacesUtils.history.remove instead." and to add PLACES_WARN_DEPRECATED(); in the implementation in nsNavHistory.cpp

This is not actually breaking add-ons yet, but it will when we'll remove the methods in future.

Comment 1

[Marco Bonardo [:mak]]

We can make the patch now, but before landing it we need to fix Bug 1087255 and, if possible, bug 1086549, to avoid spamming the console on debug builds.

There are previous patches in both bugs that need unbitrotting and likely test fixes.

Comment 2

[Marco Bonardo [:mak]]

Attachment: Bug 1306276 - Deprecate History RemovePage and RemovePages.

Review commit: https://reviewboard.mozilla.org/r/122738/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/122738/

Comment 3

[Mark Banner (:standard8)]

Comment on attachment 8849969 [details]
Bug 1306276 - Deprecate History RemovePage and RemovePages.

https://reviewboard.mozilla.org/r/122738/#review125416

Nice!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c370886b741c
Deprecate History RemovePage and RemovePages. r=standard8

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c370886b741c