1306290 - Build fails with --disable-webrtc on trunk

Status: RESOLVED FIXED

(Core :: WebRTC, defect, P3)

Description

[Mats Palmgren (inactive)]

It seems bug 1304490 is only about fixing --disable-webrtc on the beta-branch.
But --disable-webrtc is also broken on trunk (rev 01cd7a8a158d):

ipc/ipdl/_ipdlheaders/mozilla/camera/PCamerasChild.h:17:10: fatal error: 'CamerasTypes.h' file not found
 0:36.91 #include "CamerasTypes.h"
 0:36.91          ^
 0:37.42 1 error generated.

Comment 1

[Paul Adenot (:padenot)]

Gian-Carlo, looks like this was caused by your patch in bug 1303713.

Comment 2

[Gian-Carlo Pascutto [:gcp]]

Attachment: Bug 1306290 - Always export CamerasTypes.h.

Review commit: https://reviewboard.mozilla.org/r/82830/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/82830/

Comment 3

[Gian-Carlo Pascutto [:gcp]]

Patch is up.

Comment 4

[Randell Jesup [:jesup] (needinfo me)]

Comment on attachment 8797232 [details]
Bug 1306290 - Always export CamerasTypes.h.

https://reviewboard.mozilla.org/r/82830/#review81506

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/4a938cf41515
Always export CamerasTypes.h. r=jesup

Comment 7

[Gian-Carlo Pascutto [:gcp]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5f144c03aa57

Comment 8

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/4a938cf41515