Closed
Bug 1304490
Opened 8 years ago
Closed 8 years ago
Build fails with --disable-webrtc
Categories
(Core :: WebRTC, defect, P1)
Tracking
()
RESOLVED
FIXED
People
(Reporter: ricotz, Assigned: jesup)
References
Details
(Whiteboard: [tor][fingerprinting])
User Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Firefox/45.0 Build ID: 20160921101315 Steps to reproduce: Tried to build firefox 50.0~beta1 (91faf7ec36cd) from mozilla-beta branch including the --disable-webrtc confflag. Actual results: The build still tries to compile webrtc related sources: ( Full log available at https://launchpadlibrarian.net/285760721/buildlog_ubuntu-yakkety-armhf.firefox_50.0~b1+build1-0ubuntu0.16.10.1_BUILDING.txt.gz ) /usr/bin/g++ -std=gnu++11 -o Unified_cpp_dom_media_webrtc0.o -c -I/«BUILDDIR»/firefox-50.0~b1+build1/obj-arm-linux-gnueabihf/dist/stl_wrappers -I/«BUILDDIR»/firefox-50.0~b1+build1/obj-arm-linux-gnueabihf/dist/system_wrappers -include /«BUILDDIR»/firefox-50.0~b1+build1/config/gcc_hidden.h -DNDEBUG=1 -DTRIMMED=1 -DOS_POSIX=1 -DOS_LINUX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/«BUILDDIR»/firefox-50.0~b1+build1/dom/media/webrtc -I/«BUILDDIR»/firefox-50.0~b1+build1/obj-arm-linux-gnueabihf/dom/media/webrtc -I/«BUILDDIR»/firefox-50.0~b1+build1/obj-arm-linux-gnueabihf/ipc/ipdl/_ipdlheaders -I/«BUILDDIR»/firefox-50.0~b1+build1/ipc/chromium/src -I/«BUILDDIR»/firefox-50.0~b1+build1/ipc/glue -I/«BUILDDIR»/firefox-50.0~b1+build1/obj-arm-linux-gnueabihf/dist/include -I/«BUILDDIR»/firefox-50.0~b1+build1/obj-arm-linux-gnueabihf/dist/include/nspr -I/«BUILDDIR»/firefox-50.0~b1+build1/obj-arm-linux-gnueabihf/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /«BUILDDIR»/firefox-50.0~b1+build1/obj-arm-linux-gnueabihf/mozilla-config.h -MD -MP -MF .deps/Unified_cpp_dom_media_webrtc0.o.pp -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wc++14-compat -Wno-invalid-offsetof -Wno-error=maybe-uninitialized -Wno-error=deprecated-declarations -Wno-error=array-bounds -fno-exceptions -fno-strict-aliasing -fno-rtti -ffunction-sections -fdata-sections -fno-exceptions -fno-math-errno -pthread -pipe -g -freorder-blocks -Os -fomit-frame-pointer -Wno-error=attributes -Wno-error=shadow /«BUILDDIR»/firefox-50.0~b1+build1/obj-arm-linux-gnueabihf/dom/media/webrtc/Unified_cpp_dom_media_webrtc0.cpp In file included from /«BUILDDIR»/firefox-50.0~b1+build1/dom/media/webrtc/MediaEngineDefault.h:21:0, from /«BUILDDIR»/firefox-50.0~b1+build1/dom/media/webrtc/MediaEngineDefault.cpp:5, from /«BUILDDIR»/firefox-50.0~b1+build1/obj-arm-linux-gnueabihf/dom/media/webrtc/Unified_cpp_dom_media_webrtc0.cpp:2: /«BUILDDIR»/firefox-50.0~b1+build1/dom/media/webrtc/MediaEngineCameraVideoSource.h:14:53: fatal error: webrtc/video_engine/include/vie_capture.h: No such file or directory #include "webrtc/video_engine/include/vie_capture.h" ^ compilation terminated. make[6]: *** [Unified_cpp_dom_media_webrtc0.o] Error 1 /«BUILDDIR»/firefox-50.0~b1+build1/config/rules.mk:934: recipe for target 'Unified_cpp_dom_media_webrtc0.o' failed make[6]: Leaving directory '/«BUILDDIR»/firefox-50.0~b1+build1/obj-arm-linux-gnueabihf/dom/media/webrtc' make[5]: *** [dom/media/webrtc/target] Error 2 Expected results: Successful build without webrtc references.
Reporter | ||
Updated•8 years ago
|
OS: Unspecified → Linux
Version: 45 Branch → 50 Branch
Updated•8 years ago
|
Component: Build Config → WebRTC
Comment 1•8 years ago
|
||
Latest build from mozilla central does not reproduce the issue. changeset: 313650:f5d043ce6d36. Can you please retry with a later version. I tried it on a Linux box as reported in Platform field. I note that you report the bug from a windows machine. Just mentioning it to avoid any confusion.
Flags: needinfo?(ricotz)
Updated•8 years ago
|
Whiteboard: [needinfo 2016-09-22 to reporter]
Reporter | ||
Comment 2•8 years ago
|
||
The bug is targeting and was filed from linux ;-) (but the user-agent was tweaked) I can confirm the mozilla aurora branch (changeset: 340134) doesn't seem show the problem.
Comment 3•8 years ago
|
||
Clear the NI flag
Flags: needinfo?(ricotz)
Whiteboard: [needinfo 2016-09-22 to reporter]
Comment 4•8 years ago
|
||
Seems to have been fixed already. Reopen if this is not the case.
Status: UNCONFIRMED → RESOLVED
Closed: 8 years ago
Resolution: --- → WORKSFORME
Reporter | ||
Comment 5•8 years ago
|
||
This is still happening with FIREFOX_50_0b2_BUILD1 To clarify while this seems to be working correctly in central and aurora branches, it is broken in the *beta* channel which this bug is targeting.
Status: RESOLVED → UNCONFIRMED
Resolution: WORKSFORME → ---
Comment 6•8 years ago
|
||
Is this going to be something we would get a beta uplift for?
Flags: needinfo?(rjesup)
Assignee | ||
Comment 7•8 years ago
|
||
I'll try it today.
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(rjesup)
Whiteboard: [needinfo to jesup 9/29]
Comment 8•8 years ago
|
||
I had forgotten the --disable-webrtc in my debug mozconfig and build failed. I had just pulled latest changes from central. The error is: 6:59.00 libdom_bindings.a.desc 7:01.84 In file included from /Users/achronopoulos/repos/mozilla/firefox/obj-x86_64-apple-darwin15.6.0/ipc/ipdl/UnifiedProtocols1.cpp:110: 7:01.84 In file included from /Users/achronopoulos/repos/mozilla/firefox/obj-x86_64-apple-darwin15.6.0/ipc/ipdl/PBackgroundChild.cpp:26: 7:01.84 /Users/achronopoulos/repos/mozilla/firefox/obj-x86_64-apple-darwin15.6.0/ipc/ipdl/_ipdlheaders/mozilla/camera/PCamerasChild.h:17:10: fatal error: 'CamerasTypes.h' file not found 7:01.84 #include "CamerasTypes.h" 7:01.84 ^ 7:02.36 1 error generated. 7:02.40 7:02.40 In the directory /Users/achronopoulos/repos/mozilla/firefox/obj-x86_64-apple-darwin15.6.0/ipc/ipdl 7:02.40 The following command failed to execute properly: 7:02.40 /usr/bin/clang++ -std=gnu++11 -o UnifiedProtocols1.o -c -fvisibility=hidden -fvisibility-inlines-hidden -DDEBUG=1 -DTRACING=1 -DOS_POSIX=1 -DOS_MACOSX=1 -DSTATIC_EXPORTABLE_JS_API -DMOZILLA_INTERNAL_API -DIMPL_LIBXUL -I/Users/achronopoulos/repos/mozilla/firefox/ipc/ipdl -I/Users/achronopoulos/repos/mozilla/firefox/obj-x86_64-apple-darwin15.6.0/ipc/ipdl -I/Users/achronopoulos/repos/mozilla/firefox/obj-x86_64-apple-darwin15.6.0/ipc/ipdl/_ipdlheaders -I/Users/achronopoulos/repos/mozilla/firefox/ipc/chromium/src -I/Users/achronopoulos/repos/mozilla/firefox/ipc/glue -I/Users/achronopoulos/repos/mozilla/firefox/obj-x86_64-apple-darwin15.6.0/dist/include -I/Users/achronopoulos/repos/mozilla/firefox/obj-x86_64-apple-darwin15.6.0/dist/include/nspr -I/Users/achronopoulos/repos/mozilla/firefox/obj-x86_64-apple-darwin15.6.0/dist/include/nss -fPIC -DMOZILLA_CLIENT -include /Users/achronopoulos/repos/mozilla/firefox/obj-x86_64-apple-darwin15.6.0/mozilla-config.h -MD -MP -MF .deps/UnifiedProtocols1.o.pp -Qunused-arguments -Qunused-arguments -Wall -Wc++11-compat -Wempty-body -Wignored-qualifiers -Woverloaded-virtual -Wpointer-arith -Wsign-compare -Wtype-limits -Wunreachable-code -Wwrite-strings -Wno-invalid-offsetof -Wclass-varargs -Wloop-analysis -Wc++11-compat-pedantic -Wc++14-compat -Wc++14-compat-pedantic -Wc++1z-compat -Wimplicit-fallthrough -Wstring-conversion -Wthread-safety -Wno-inline-new-delete -Wno-error=deprecated-declarations -Wno-error=array-bounds -Wno-unknown-warning-option -Wno-return-type-c-linkage -fno-exceptions -fno-strict-aliasing -stdlib=libc++ -fno-rtti -fno-exceptions -fno-math-errno -pthread -pipe -g -fno-omit-frame-pointer /Users/achronopoulos/repos/mozilla/firefox/obj-x86_64-apple-darwin15.6.0/ipc/ipdl/UnifiedProtocols1.cpp 7:02.49 make[5]: *** [UnifiedProtocols1.o] Error 1 7:02.49 make[5]: *** Waiting for unfinished jobs.... 7:03.03 libgfx_config.a.desc
Updated•8 years ago
|
Whiteboard: [needinfo to jesup 9/29] → [needinfo to jesup 9/29] [tor]
Assignee | ||
Comment 10•8 years ago
|
||
(In reply to Alex Chronopoulos [:achronop] from comment #8) > I had forgotten the --disable-webrtc in my debug mozconfig and build failed. > /Users/achronopoulos/repos/mozilla/firefox/obj-x86_64-apple-darwin15.6.0/ipc/ > ipdl/_ipdlheaders/mozilla/camera/PCamerasChild.h:17:10: fatal error: > 'CamerasTypes.h' file not found > 7:01.84 #include "CamerasTypes.h" This specific failure was fixed in bug 1306290. I'll see where this general bug is now
Flags: needinfo?(rjesup)
Assignee | ||
Updated•8 years ago
|
Flags: needinfo?(rjesup)
Assignee | ||
Comment 11•8 years ago
|
||
builds fine currently with --disable-webrtc on inbound (and I'm sure m-c)
Assignee | ||
Comment 12•8 years ago
|
||
Builds for beta 50 with patch from bug 1290629. Uplift requested. Might be taken since it's NPOTB (doesn't affect our normal builds).
Assignee: nobody → rjesup
Status: UNCONFIRMED → NEW
Rank: 19
Ever confirmed: true
Flags: needinfo?(rjesup)
Priority: -- → P1
Whiteboard: [needinfo to jesup 9/29] [tor] → [tor]
Assignee | ||
Comment 13•8 years ago
|
||
Fixed and the patch uplifted to 50 in bug 1290629
Status: NEW → RESOLVED
Closed: 8 years ago → 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•